ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity

feat: converge findings notification presentation #265

Merged
ahmido merged 2 commits from 230-findings-notification-convergence into dev 2026-04-22 20:26:19 +00:00
Conversation 0 Commits 2 Files Changed 19 +2173 -155
ahmido commented 2026-04-22 20:24:48 +00:00
Owner
Copy Link

Summary

  • converge finding, queued, and completed database notifications on one shared OperationUxPresenter presentation contract
  • preserve existing finding and operation deep-link authorities while standardizing title, body, status/icon treatment, and single primary action
  • add focused notification, findings, and guard coverage plus the full feature 230 spec artifacts

Validation

  • cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent
  • cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Notifications/SharedDatabaseNotificationContractTest.php tests/Feature/Notifications/OperationRunNotificationTest.php tests/Feature/Notifications/FindingNotificationLinkTest.php
  • cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings/FindingsNotificationEventTest.php tests/Feature/Findings/FindingsNotificationRoutingTest.php tests/Feature/OpsUx/Constitution/LegacyNotificationGuardTest.php

Filament / Platform Notes

  • Livewire v4.0+ compliance preserved on Filament v5 primitives
  • provider registration remains unchanged in apps/platform/bootstrap/providers.php
  • no globally searchable resource behavior changed in this feature
  • no destructive actions were introduced
  • asset strategy is unchanged; the existing cd apps/platform && php artisan filament:assets deploy step remains sufficient
## Summary - converge finding, queued, and completed database notifications on one shared `OperationUxPresenter` presentation contract - preserve existing finding and operation deep-link authorities while standardizing title, body, status/icon treatment, and single primary action - add focused notification, findings, and guard coverage plus the full feature 230 spec artifacts ## Validation - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Notifications/SharedDatabaseNotificationContractTest.php tests/Feature/Notifications/OperationRunNotificationTest.php tests/Feature/Notifications/FindingNotificationLinkTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings/FindingsNotificationEventTest.php tests/Feature/Findings/FindingsNotificationRoutingTest.php tests/Feature/OpsUx/Constitution/LegacyNotificationGuardTest.php` ## Filament / Platform Notes - Livewire v4.0+ compliance preserved on Filament v5 primitives - provider registration remains unchanged in `apps/platform/bootstrap/providers.php` - no globally searchable resource behavior changed in this feature - no destructive actions were introduced - asset strategy is unchanged; the existing `cd apps/platform && php artisan filament:assets` deploy step remains sufficient
ahmido added 2 commits 2026-04-22 20:24:48 +00:00
merge: agent session work
Some checks failed
PR Fast Feedback / fast-feedback (pull_request) Failing after 52s
Details
1058cab1a8
ahmido merged commit 742d65f0d9 into dev 2026-04-22 20:26:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ahmido/TenantAtlas#265
No description provided.
Delete Branch "230-findings-notification-convergence"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?