feat: implement finding outcome taxonomy #267

ahmido · 2026-04-23T07:25:49Z

ahmido commented

2026-04-23 07:25:49 +00:00

Summary

implement the finding outcome taxonomy end-to-end with canonical resolve, close, reopen, and verification semantics
align finding UI, filters, audit metadata, review summaries, and export/read-model consumers to the shared outcome semantics
add focused Pest coverage and complete the spec artifacts for feature 231

Details

manual resolve is limited to the canonical remediated outcome
close and reopen flows now use bounded canonical reasons
trusted system clear and reopen distinguish verified-clear from verification-failed and recurrence paths
duplicate lifecycle backfill now closes findings canonically as duplicate
accepted-risk recording now uses the canonical accepted_risk reason
finding detail and list surfaces now expose terminal outcome and verification summaries
review, snapshot, and review-pack consumers now propagate the same outcome buckets

Filament / Platform Contract

Livewire v4.0+ compatibility remains intact
provider registration is unchanged and remains in bootstrap/providers.php
no new globally searchable resource was introduced; FindingResource still has a View page and TenantReviewResource remains globally searchable false
lifecycle mutations still run through confirmed Filament actions with capability enforcement
no new asset family was added; the existing filament:assets deploy step is unchanged

Verification

cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings/FindingWorkflowServiceTest.php tests/Feature/Findings/FindingRecurrenceTest.php tests/Feature/Findings/FindingsListFiltersTest.php tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Findings/FindingOutcomeSummaryReportingTest.php tests/Feature/Findings/FindingRiskGovernanceProjectionTest.php
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Models/FindingResolvedTest.php tests/Unit/Findings/FindingWorkflowServiceTest.php
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewExplanationSurfaceTest.php tests/Feature/TenantReview/TenantReviewRegisterTest.php tests/Feature/ReviewPack/TenantReviewDerivedReviewPackTest.php
browser smoke: /admin/findings/my-work -> finding detail resolve flow -> queue regression check passed

Notes

this commit also includes the existing .github/agents/copilot-instructions.md workspace change that was already present in the worktree when all changes were committed

## Summary - implement the finding outcome taxonomy end-to-end with canonical resolve, close, reopen, and verification semantics - align finding UI, filters, audit metadata, review summaries, and export/read-model consumers to the shared outcome semantics - add focused Pest coverage and complete the spec artifacts for feature 231 ## Details - manual resolve is limited to the canonical `remediated` outcome - close and reopen flows now use bounded canonical reasons - trusted system clear and reopen distinguish verified-clear from verification-failed and recurrence paths - duplicate lifecycle backfill now closes findings canonically as `duplicate` - accepted-risk recording now uses the canonical `accepted_risk` reason - finding detail and list surfaces now expose terminal outcome and verification summaries - review, snapshot, and review-pack consumers now propagate the same outcome buckets ## Filament / Platform Contract - Livewire v4.0+ compatibility remains intact - provider registration is unchanged and remains in `bootstrap/providers.php` - no new globally searchable resource was introduced; `FindingResource` still has a View page and `TenantReviewResource` remains globally searchable false - lifecycle mutations still run through confirmed Filament actions with capability enforcement - no new asset family was added; the existing `filament:assets` deploy step is unchanged ## Verification - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings/FindingWorkflowServiceTest.php tests/Feature/Findings/FindingRecurrenceTest.php tests/Feature/Findings/FindingsListFiltersTest.php tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Findings/FindingOutcomeSummaryReportingTest.php tests/Feature/Findings/FindingRiskGovernanceProjectionTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Models/FindingResolvedTest.php tests/Unit/Findings/FindingWorkflowServiceTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewExplanationSurfaceTest.php tests/Feature/TenantReview/TenantReviewRegisterTest.php tests/Feature/ReviewPack/TenantReviewDerivedReviewPackTest.php` - browser smoke: `/admin/findings/my-work` -> finding detail resolve flow -> queue regression check passed ## Notes - this commit also includes the existing `.github/agents/copilot-instructions.md` workspace change that was already present in the worktree when all changes were committed

ahmido added 1 commit 2026-04-23 07:25:50 +00:00

feat: implement finding outcome taxonomy

PR Fast Feedback / fast-feedback (pull_request) Failing after 4m16s

Details

807578dd9c

ahmido added 1 commit 2026-04-23 07:28:10 +00:00

merge: update from dev

PR Fast Feedback / fast-feedback (pull_request) Failing after 54s

Details

8552d7fe9d

ahmido merged commit 421261a517 into dev

2026-04-23 07:29:06 +00:00