ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

feat(onboarding): decision-first verify-step & contextual-help callout fix #282

Merged
ahmido merged 2 commits from 244-product-knowledge-contextual-help-session-1777248340 into dev 2026-04-27 00:09:47 +00:00
Conversation 0 Commits 2 Files Changed 18 +2455 -52
ahmido commented 2026-04-27 00:08:18 +00:00
Owner
Copy Link

This PR implements the onboarding verify-step changes and ProductKnowledge contextual-help fixes:

  • Hide the top-level "Permission diagnostics" when a stored verification report exists.
  • Move permission details to "Supporting evidence" / "View required permissions" and into stored report technical details.
  • Rename "Current checkpoint" to "Step" in onboarding readiness.
  • Rename the inner verification card title to "Stored verification details" to avoid duplicate headings.
  • Keep "Grant admin consent" as primary CTA when admin consent is the dominant blocker by deriving the CTA from the verification primary reason.
  • Replace the custom Safe Next Action with Filament Callout for correct dark-mode styling.
  • Add/adjust focused feature tests proving the above behaviors.

Verification:

  • Tests: 36 passed (173 assertions) locally.
  • Pint: pass.

Created from local session branch 244-product-knowledge-contextual-help-session-1777248340. Please review and merge into dev when ready.

This PR implements the onboarding verify-step changes and ProductKnowledge contextual-help fixes: - Hide the top-level "Permission diagnostics" when a stored verification report exists. - Move permission details to "Supporting evidence" / "View required permissions" and into stored report technical details. - Rename "Current checkpoint" to "Step" in onboarding readiness. - Rename the inner verification card title to "Stored verification details" to avoid duplicate headings. - Keep "Grant admin consent" as primary CTA when admin consent is the dominant blocker by deriving the CTA from the verification primary reason. - Replace the custom Safe Next Action with Filament `Callout` for correct dark-mode styling. - Add/adjust focused feature tests proving the above behaviors. Verification: - Tests: 36 passed (173 assertions) locally. - Pint: pass. Created from local session branch `244-product-knowledge-contextual-help-session-1777248340`. Please review and merge into `dev` when ready.
ahmido added 2 commits 2026-04-27 00:08:18 +00:00
feat(onboarding): align verify-step hierarchy; contextual-help dark-mode callout
Some checks failed
PR Fast Feedback / fast-feedback (pull_request) Failing after 4m46s
Details
80bd9e3087
ahmido merged commit bf43e55848 into dev 2026-04-27 00:09:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ahmido/TenantAtlas#282
No description provided.
Delete Branch "244-product-knowledge-contextual-help-session-1777248340"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?