ahmido
0b5cadc234
## Summary - add a shared diff presentation layer under `app/Support/Diff` with deterministic row classification, summary derivation, and value stringification - centralize diff-state badge semantics through `BadgeCatalog` with a dedicated `DiffRowStatusBadge` - add reusable Filament diff partials, focused Pest coverage, and the full SpecKit artifact set for spec 141 ## Testing - `vendor/bin/sail artisan test --compact tests/Unit/Support/Diff/DiffRowStatusTest.php tests/Unit/Support/Diff/DiffRowTest.php tests/Unit/Support/Diff/DiffPresenterTest.php tests/Unit/Support/Diff/ValueStringifierTest.php tests/Unit/Badges/DiffRowStatusBadgeTest.php tests/Feature/Support/Diff/SharedDiffSummaryPartialTest.php tests/Feature/Support/Diff/SharedDiffRowPartialTest.php tests/Feature/Support/Diff/SharedInlineListDiffPartialTest.php` - `vendor/bin/sail bin pint --dirty --format agent` ## Filament / Livewire Contract - Livewire v4.0+ compliance: unchanged and respected; this feature adds presentation support only within the existing Filament v5 / Livewire v4 stack - Provider registration: unchanged; no panel/provider changes were required, so `bootstrap/providers.php` remains the correct registration location - Global search: unchanged; no Resource or global-search behavior was added or modified - Destructive actions: none introduced in this feature - Asset strategy: no new registered Filament assets; shared Blade partials rely on the existing asset pipeline and standard deploy step for `php artisan filament:assets` when assets change generally - Testing coverage: presenter, DTOs, stringifier, badge semantics, summary partial, row partial, and inline-list partial are covered by focused Pest unit and feature tests ## Notes - Spec checklist status is complete for `specs/141-shared-diff-presentation-foundation/checklists/requirements.md` - This PR preserves specialized diff renderers and documents incremental adoption rather than forcing migration in the same change Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #170
45 lines
1.5 KiB
PHP
45 lines
1.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Support\Diff\DiffRow;
|
|
use App\Support\Diff\DiffRowStatus;
|
|
|
|
it('requires a non-empty key and label', function (): void {
|
|
expect(fn (): DiffRow => new DiffRow(
|
|
key: '',
|
|
label: 'Display name',
|
|
status: DiffRowStatus::Changed,
|
|
))->toThrow(\InvalidArgumentException::class, 'DiffRow key must be a non-empty string.');
|
|
|
|
expect(fn (): DiffRow => new DiffRow(
|
|
key: 'display_name',
|
|
label: ' ',
|
|
status: DiffRowStatus::Changed,
|
|
))->toThrow(\InvalidArgumentException::class, 'DiffRow label must be a non-empty string.');
|
|
});
|
|
|
|
it('stores optional list fragments and meta for rendering', function (): void {
|
|
$row = new DiffRow(
|
|
key: 'assignments',
|
|
label: 'Assignments',
|
|
status: DiffRowStatus::Changed,
|
|
oldValue: ['old-a', 'shared'],
|
|
newValue: ['new-b', 'shared'],
|
|
isListLike: true,
|
|
addedItems: ['new-b'],
|
|
removedItems: ['old-a'],
|
|
unchangedItems: ['shared'],
|
|
meta: ['hint' => 'policy level'],
|
|
);
|
|
|
|
expect($row->key)->toBe('assignments')
|
|
->and($row->label)->toBe('Assignments')
|
|
->and($row->status)->toBe(DiffRowStatus::Changed)
|
|
->and($row->isListLike)->toBeTrue()
|
|
->and($row->addedItems)->toBe(['new-b'])
|
|
->and($row->removedItems)->toBe(['old-a'])
|
|
->and($row->unchangedItems)->toBe(['shared'])
|
|
->and($row->meta)->toBe(['hint' => 'policy level']);
|
|
});
|