ahmido
eceeee9c5c
## Summary - retire the remaining tenant-scoped provider-connection legacy routes and update canonical verification and link behavior - complete the provider target-scope fallback cleanup so neutral shared scope data falls back to the managed environment when the raw connection tenant identifier is blank - stop mirroring workspace roles into managed-environment scope persistence and cut the targeted admin-panel test helpers over to the post-cutover context path - add and update the Spec 287 artifact package and targeted regression coverage for route retirement, provider-core neutralization, workspace-first RBAC, and helper cutover ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/LegacyRedirectTest.php tests/Feature/ProviderConnections/TenantlessListRouteTest.php tests/Feature/ProviderConnections/TenantlessListScopingTest.php tests/Feature/Auth/WorkspaceFirstManagedEnvironmentAccessTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php tests/Feature/Reviews/CustomerReviewWorkspaceLaunchLinksTest.php tests/Feature/Rbac/TriageReviewStateAuthorizationTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec281ProviderConnectionScopeSmokeTest.php tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - Filament remains on Livewire v4 and provider registration stays unchanged in `apps/platform/bootstrap/providers.php`. - No new asset registration or deployment-step changes are included in this slice. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #346
50 lines
3.6 KiB
Markdown
50 lines
3.6 KiB
Markdown
# Requirements Checklist: Cutover Prerequisite Completion
|
|
|
|
## Scope and problem framing
|
|
|
|
- [x] The package describes the real repo problem as unfinished runtime and test-harness prerequisites, not as missing quality gates.
|
|
- [x] The package keeps scope limited to the five named prerequisite areas.
|
|
- [x] The package explicitly moves quality gates and no-legacy enforcement to Spec `288`.
|
|
- [x] The package explicitly excludes full-suite baselines, package execution, guided operations, UI copy cleanup, and provider capability expansion.
|
|
|
|
## Repo-truth anchoring
|
|
|
|
- [x] The package names the surviving provider-connection legacy route family in `apps/platform/routes/web.php`.
|
|
- [x] The package pins the in-slice provider-connection launch-point inventory in `apps/platform/app/Providers/Filament/AdminPanelProvider.php`, `apps/platform/app/Filament/Resources/TenantResource.php`, `apps/platform/app/Filament/Pages/TenantRequiredPermissions.php`, `apps/platform/app/Support/OperationRunLinks.php`, `apps/platform/app/Support/Providers/ProviderReasonTranslator.php`, and `apps/platform/app/Support/Verification/VerificationLinkBehavior.php`.
|
|
- [x] The package anchors provider target-scope completion to the real shared provider-core seams from the `281` workstream.
|
|
- [x] The package anchors environment-scope cleanup to role-bearing `ManagedEnvironmentMembership` persistence drift on the existing auth seams.
|
|
- [x] The package anchors helper cutover to `apps/platform/tests/Pest.php`, `apps/platform/tests/Feature/Reviews/CustomerReviewWorkspaceLaunchLinksTest.php`, and `apps/platform/tests/Feature/Rbac/TriageReviewStateAuthorizationTest.php`.
|
|
|
|
## Completion inventory and boundedness
|
|
|
|
- [x] The same completion categories appear across `spec.md`, `plan.md`, `data-model.md`, and `quickstart.md`.
|
|
- [x] The package defines canonical replacements instead of adding compatibility aliases or a guard inventory.
|
|
- [x] The package keeps provider-owned Microsoft detail nested and bounded instead of pretending it disappears entirely.
|
|
- [x] The package forbids introducing a new guard subsystem or full-suite wrapper here.
|
|
|
|
## Validation and workflow
|
|
|
|
- [x] Planned proof stays bounded to targeted feature tests, targeted browser validation, and formatting.
|
|
- [x] The same validation commands appear in `spec.md`, `plan.md`, `tasks.md`, and `quickstart.md`.
|
|
- [x] The task package explicitly re-verifies Filament/Livewire/provider-registration invariants and the no-asset-registration / no-deployment-step boundary.
|
|
- [x] The package keeps review outcome, workflow outcome, and test-governance outcome aligned.
|
|
- [x] The package uses `RuntimePrerequisite` rather than `Guardrail` as the close-out intent.
|
|
|
|
## Adjacent-spec control
|
|
|
|
- [x] Spec `288` is named as the explicit follow-up package for quality gates and no-legacy enforcement.
|
|
- [x] The package does not silently absorb UI copy cleanup from Spec `286`.
|
|
- [x] The package does not silently absorb provider capability expansion from Spec `283`.
|
|
- [x] The package does not silently absorb package execution or guided operations work.
|
|
|
|
## Notes
|
|
|
|
- Reviewed against `.specify/memory/constitution.md`, current repo route, provider-core, auth, and test-support seams, and adjacent Specs `280`, `281`, `285`, and `286` on 2026-05-10.
|
|
- This artifact package is implementation-ready and no longer uses the earlier blocked-by-prerequisites posture.
|
|
|
|
## Outcome
|
|
|
|
- **Review outcome class**: `acceptable-special-case`
|
|
- **Workflow outcome**: `keep`
|
|
- **Test-governance outcome**: `keep`
|
|
- **Readiness note**: implementation is ready as a bounded prerequisite-completion slice; no-legacy enforcement is deferred to Spec `288` |