ahmido 38523814c2 fix: restore full-suite green signals across platform workflows (#351 )

## Summary
- restore broad full-suite green-signal coverage across platform governance, operations, onboarding, dashboard/productization, and customer review flows
- align related platform tests and supporting behavior with the current expected state for this restoration pass
- update the spec-candidates queue as part of the same suite-restoration sweep

## Validation
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Dashboard/TenantDashboardProductizationSmokeTest.php tests/Browser/Reviews/CustomerReviewWorkspaceSmokeTest.php tests/Browser/Spec194GovernanceFrictionSmokeTest.php tests/Browser/Spec265DecisionRegisterSmokeTest.php`

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #351

2026-05-12 18:50:40 +00:00

3.0 KiB

Raw Permalink Blame History

Quickstart: Full Suite Green Signal Restoration

1. Safety Gate

git branch --show-current
git status --short
git diff --stat

Expected branch:

296-full-suite-green-signal-restoration

Stop if unrelated uncommitted changes exist.

2. Read Context

.specify/memory/constitution.md
specs/293-post-cutover-suite-stabilization/failure-classification.md
specs/294-provider-verification-runtime-semantics/failure-classification.md
specs/295-full-suite-ci-baseline/failure-classification.md
specs/295-full-suite-ci-baseline/tasks.md

3. Baseline

cd apps/platform
./vendor/bin/sail artisan test --compact

If output is too broad or truncated:

./scripts/platform-test-lane fast-feedback
./scripts/platform-test-lane confidence
./scripts/platform-test-lane heavy-governance
./scripts/platform-test-lane browser

Record groups in failure-inventory.md before repair.

4. Guard Lanes

Run the Spec 288 guard lane from spec.md.

Run the Spec 293 cutover lane from spec.md.

Run:

cd apps/platform
./vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections tests/Feature/Verification

Repair guard failures first.

5. Repair Loop

For every failure group:

cd apps/platform
./vendor/bin/sail artisan test --compact <test-file>

Then:

Read owner code.
Classify the group.
Apply the smallest fix.
Rerun focused file.
Rerun affected lane.
Update failure-inventory.md.
Update fix-log.md.

6. Browser Evidence

Before browser work:

mkdir -p /tmp/tenantpilot-296-browser-evidence
cp -R apps/platform/tests/Browser/Screenshots/* /tmp/tenantpilot-296-browser-evidence/ || true

After browser runs:

git status --short apps/platform/tests/Browser/Screenshots
git diff --stat apps/platform/tests/Browser/Screenshots

Do not commit screenshot baselines unless browser-evidence.md documents the file and reason.

7. Final Validation

cd apps/platform
./vendor/bin/sail artisan test --compact
./vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections tests/Feature/Verification
./vendor/bin/sail bin pint --dirty --format agent
git diff --check

Also run Spec 288 and Spec 293 command blocks from spec.md.

If browser files changed:

./scripts/platform-test-lane browser

8. Final Answer Data

Report:

- Full Suite: green / not green
- Anzahl Tests / Assertions
- Spec 288 Guard Lane: green / not green
- Spec 293 Cutover Lane: green / not green
- Spec 294 Provider/Verification Lane: green / not green
- Browser Lane: green / not green / N/A
- Pint: green / not green
- git diff --check: green / not green
- Runtime files changed
- Test files changed
- Spec artifacts changed
- Screenshots changed? yes/no
- Screenshots committed? yes/no and why
- Welche Root Causes wurden gefixt?
- Welche Tests wurden rebaselined?
- Welche Tests wurden verschoben/skipped?
- Gibt es Restfehler?
- Ist Tenant Cutover formal abgeschlossen?
- Ist Full Suite wieder belastbares CI-Signal?

3.0 KiB Raw Permalink Blame History