ahmido
b159dacd36
## Summary - remove legacy tenant-scoped routing and middleware paths in favor of the current environment/workspace context flow - update Filament pages and resources to use the cleaned-up admin surface and environment filter context - add the related spec 317 artifacts and targeted tests for environment filter state and legacy context cleanup ## Testing - not run as part of this commit/push/PR workflow Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #372
66 lines
3.5 KiB
Markdown
66 lines
3.5 KiB
Markdown
# Specification Quality Checklist: Legacy Tenant / Environment Context Cleanup
|
|
|
|
**Purpose**: Validate preparation completeness and quality before implementation
|
|
**Created**: 2026-05-16
|
|
**Feature**: [spec.md](/Users/ahmeddarrazi/Documents/projects/wt-plattform/specs/317-legacy-tenant-environment-context-cleanup/spec.md)
|
|
|
|
## Candidate Selection
|
|
|
|
- [x] CHK001 The selected candidate was directly supplied by the user as Spec 317.
|
|
- [x] CHK002 The selected candidate is not an existing completed spec package.
|
|
- [x] CHK003 Related Specs 313, 314, 315, and 316 are treated as completed historical context and not rewritten.
|
|
- [x] CHK004 The candidate aligns with explicit follow-up notes in Specs 314, 315, and 316.
|
|
- [x] CHK005 The scope is narrowed to legacy Tenant platform-context cleanup and provider-boundary Tenant preservation.
|
|
- [x] CHK006 Durable browser no-drift infrastructure is deferred to Spec 318.
|
|
|
|
## Content Quality
|
|
|
|
- [x] CHK007 `spec.md` exists.
|
|
- [x] CHK008 `plan.md` exists.
|
|
- [x] CHK009 `tasks.md` exists.
|
|
- [x] CHK010 Spec Candidate Check is completed.
|
|
- [x] CHK011 Functional requirements are testable and unambiguous.
|
|
- [x] CHK012 Acceptance criteria include inventory, allowlist, query cleanup, helper/class cleanup, route guard, UI copy cleanup, docs cleanup, regression tests, and browser smoke.
|
|
- [x] CHK013 Provider-boundary Tenant terminology is explicitly preserved.
|
|
- [x] CHK014 Hard cutover/no-compatibility posture is explicit.
|
|
|
|
## Repository Alignment
|
|
|
|
- [x] CHK015 Laravel, Filament, Livewire, Pest, and PostgreSQL context is recorded.
|
|
- [x] CHK016 Provider registration location remains `apps/platform/bootstrap/providers.php`.
|
|
- [x] CHK017 Filament v5 / Livewire v4 compliance is recorded.
|
|
- [x] CHK018 Global search behavior is not intentionally changed and has a verification task if resources are touched.
|
|
- [x] CHK019 Destructive actions are not added or changed and have a verification task if touched.
|
|
- [x] CHK020 Asset strategy is unchanged and no new `filament:assets` requirement is planned.
|
|
- [x] CHK021 Likely affected repo surfaces are named in the plan.
|
|
- [x] CHK022 No migration, seeder, package, env var, queue, scheduler, or storage change is planned by default.
|
|
|
|
## Artifact Requirements
|
|
|
|
- [x] CHK023 `legacy-inventory.md` is required as an implementation artifact and assigned to tasks.
|
|
- [x] CHK024 `tenant-usage-allowlist.md` is required as an implementation artifact and assigned to tasks.
|
|
- [x] CHK025 Classification values for inventory entries are specified.
|
|
- [x] CHK026 Browser screenshot artifact path is specified.
|
|
- [x] CHK027 Historical completed specs are protected from preparation rewrite.
|
|
|
|
## Test and Validation Readiness
|
|
|
|
- [x] CHK028 Static legacy guard is required.
|
|
- [x] CHK029 Workspace hub legacy query alias guard is required.
|
|
- [x] CHK030 Filament tenant / remembered Tenant fallback guard is required.
|
|
- [x] CHK031 Route guard for `/admin/t` and TenantPanelProvider is required.
|
|
- [x] CHK032 UI copy guard/browser verification is required.
|
|
- [x] CHK033 Spec 314, 315, and 316 regressions are required.
|
|
- [x] CHK034 `git diff --check` and formatting/static checks are required.
|
|
|
|
## Open Questions
|
|
|
|
- [x] CHK035 No blocking preparation questions remain.
|
|
- [x] CHK036 Ambiguous implementation occurrences are handled through `needs_product_decision` inventory classification instead of guessing.
|
|
|
|
## Review Outcome
|
|
|
|
- [x] CHK037 Candidate Selection Gate passes.
|
|
- [x] CHK038 Spec Readiness Gate passes for preparation.
|
|
- [x] CHK039 No application implementation was performed during preparation.
|