ahmido
ec4ff1074c
## Summary - add the Spec 322 artifact set for the browser no-drift regression guard - add Feature navigation guards for admin surface scope, environment CTA URLs, and legacy alias rejection - add Browser smoke coverage for workspace hubs, environment-owned surfaces, workspace-owned analysis surfaces, and alerts/audit flows - add the Spec 322 browser support harness used by the new smoke coverage ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test tests/Feature/Navigation/Spec322AdminSurfaceScopeContractTest.php tests/Feature/Navigation/Spec322LegacyQueryAliasGuardTest.php tests/Feature/Navigation/Spec322EnvironmentCtaUrlContractTest.php --compact` - `cd apps/platform && ./vendor/bin/sail artisan test tests/Browser/Spec322WorkspaceHubNoDriftSmokeTest.php tests/Browser/Spec322EnvironmentOwnedSurfaceSmokeTest.php tests/Browser/Spec322WorkspaceOwnedAnalysisSmokeTest.php tests/Browser/Spec322AlertsAuditNoDriftSmokeTest.php --compact` - `cd apps/platform && ./vendor/bin/sail pint --dirty` - `git diff --check` ## Notes - a broader filtered regression run still reports existing Baseline Compare feature-test failures outside this diff Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #379
60 lines
2.9 KiB
Markdown
60 lines
2.9 KiB
Markdown
# Specification Quality Checklist: Browser No-Drift Regression Guard
|
|
|
|
**Purpose**: Validate preparation completeness and quality before implementation.
|
|
**Created**: 2026-05-17
|
|
**Feature**: `specs/322-browser-no-drift-regression-guard/spec.md`
|
|
|
|
## Content Quality
|
|
|
|
- [x] Spec Candidate Check is completed.
|
|
- [x] The selected candidate is direct user-provided manual promotion.
|
|
- [x] Related completed specs are treated as historical context and not rewritten.
|
|
- [x] The scope is focused on durable guards and no-drift regression coverage.
|
|
- [x] No application implementation is included in preparation artifacts.
|
|
- [x] No migration, seeder, package, env var, queue, scheduler, storage, or deployment asset change is planned.
|
|
|
|
## Requirement Completeness
|
|
|
|
- [x] No `[NEEDS CLARIFICATION]` markers remain.
|
|
- [x] Functional requirements are testable and unambiguous.
|
|
- [x] Non-functional requirements cover browser stability, lane cost, fixture cost, and no Playwright MCP dependency.
|
|
- [x] Success criteria are measurable by artifacts and test results.
|
|
- [x] All user stories include independent test descriptions and acceptance scenarios.
|
|
- [x] Edge cases cover cross-workspace IDs, legacy aliases, stale state, back/forward, old clean URLs, and browser blockers.
|
|
- [x] Dependencies and assumptions are identified.
|
|
|
|
## Feature Readiness
|
|
|
|
- [x] `spec.md` exists.
|
|
- [x] `plan.md` exists.
|
|
- [x] `tasks.md` exists.
|
|
- [x] `test-plan.md` exists.
|
|
- [x] `coverage-manifest.md` exists.
|
|
- [x] Screenshots artifact directory is represented by `.gitkeep`.
|
|
- [x] Tasks are ordered, small, and verifiable.
|
|
- [x] Tasks include Feature/static guards and Browser guard coverage.
|
|
- [x] Tasks include validation commands and final report obligations.
|
|
- [x] Tasks include explicit non-goals and stop conditions.
|
|
|
|
## Constitution / Repo Alignment
|
|
|
|
- [x] Workspace isolation and cross-workspace rejection are explicit.
|
|
- [x] Legacy Tenant aliases remain invalid and no compatibility layer is allowed.
|
|
- [x] Provider Tenant terminology remains provider-boundary only.
|
|
- [x] Proportionality review covers the new test/manifest ownership cost.
|
|
- [x] Test governance names Browser lane expansion and fixture/helper cost controls.
|
|
- [x] Filament v5 / Livewire v4 compliance is explicitly addressed.
|
|
- [x] Provider registration location remains `apps/platform/bootstrap/providers.php`; no provider change is planned.
|
|
- [x] Global search and destructive action output-contract points are addressed.
|
|
- [x] Asset strategy is explicit; no `filament:assets` deployment change is planned.
|
|
|
|
## Preparation Analysis Outcome
|
|
|
|
- [x] Preparation artifacts are internally consistent after review.
|
|
- [x] No preparation issue requires application implementation.
|
|
- [x] No open question blocks implementation.
|
|
|
|
## Notes
|
|
|
|
Runtime acceptance remains pending until implementation, targeted Feature/static tests, targeted Browser tests, formatting, and `git diff --check` are completed.
|