ahmido
4c661f18f0
## Summary - align the Baseline Compare landing page with the shared Product Process Flow contract introduced by Spec 332 - add the horizontal flow rendering primitive and update the landing view/state presentation for readiness, proof, evidence, and next action - add Spec 336 artifacts, screenshots, focused feature coverage, and browser smoke coverage for the aligned states ## Testing - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Filament/BaselineCompareEnvironmentRouteContractTest.php tests/Feature/Filament/Spec330EnvironmentDashboardBaselineCompareProductizationTest.php tests/Feature/Filament/Spec336BaselineCompareProductProcessFlowAlignmentTest.php tests/Browser/Spec330EnvironmentDashboardBaselineCompareSmokeTest.php tests/Browser/Spec336BaselineCompareProductProcessFlowAlignmentSmokeTest.php` ## Notes - Filament v5 / Livewire v4 stack remains unchanged - no panel provider registration changes; `bootstrap/providers.php` is unaffected - no global-search resource behavior changes - no new destructive actions and no asset registration/deployment changes Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #406
2.8 KiB
2.8 KiB
Spec 336 Requirements Checklist
- Purpose: Preparation-quality validation for Spec 336 before runtime implementation.
- Created: 2026-05-29
- Feature: spec.md
Content Quality
- Spec Candidate Check is filled and justifies why this is Core Enterprise alignment work.
- Scope is bounded to Baseline Compare Landing UX alignment; explicit non-goals exclude backend compare/evidence rewrites.
- Acceptance criteria are testable (Feature + Browser smoke + screenshots).
- Spec includes truthful-copy constraints (no healthy/compliant/customer-safe claim).
Repo Truth
- Spec number/branch reconciled to repo numbering:
335-restore-run-detail-post-execution-proof-productizationalready exists.- This package is correctly created as
336-baseline-compare-product-process-flow-alignment.
- Confirmed scope paths exist:
apps/platform/app/Filament/Pages/BaselineCompareLanding.phpapps/platform/resources/views/filament/pages/baseline-compare-landing.blade.phpapps/platform/app/Support/Baselines/BaselineCompareStats.phpapps/platform/app/Services/Baselines/BaselineSnapshotTruthResolver.phpapps/platform/app/Services/Baselines/BaselineCompareService.phpapps/platform/app/Jobs/CompareBaselineToTenantJob.php
- Repo-truth artifacts exist and constrain state invention:
Security / Isolation / RBAC
- Capability-first RBAC is explicitly required for all actions and deep links.
- Cross-workspace/environment leakage is explicitly tested and forbidden.
- No
/admin/troutes, no legacy tenant query aliases, and no remembered environment as authority are introduced.
UI Guardrail / Disclosure
- Decision-first ordering is explicit (decision card → flow → proof → diagnostics collapsed).
- Exactly one dominant primary next action per state is required.
- Diagnostics are collapsed by default; raw diff/payload is never default-visible.
Test And Smoke Readiness
- Plan includes the intended lane mix (Feature + Browser).
- Tasks are ordered, small, and verifiable with explicit file targets.
- Minimal validation commands are listed in spec/tasks.
- Screenshot list is explicit and scoped to this spec directory.
Preparation Analysis Outcome
- Preparation artifacts are internally consistent (spec ↔ plan ↔ tasks ↔ truth map ↔ state contract).
- Every requirement in the spec maps to one or more tasks.
- No preparation issue requires application implementation to resolve.
- Candidate Selection Gate result: PASS (user-provided candidate + referenced as follow-up in Spec 333; not a completed spec package).
- Spec Readiness Gate result: PASS for later implementation.