ahmido
12ea7f9924
Implemented the output contract and readiness semantics for review packs. Also added spec 348. Includes changes to ChooseEnvironment, CustomerReviewWorkspace, GenerateReviewPackJob and related blade views. Added comprehensive tests. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #419
38 lines
1.6 KiB
Markdown
38 lines
1.6 KiB
Markdown
# Tasks: Spec 348 - Choose Environment Enterprise Selector
|
|
|
|
**Input**: `specs/348-choose-environment-enterprise-selector/spec.md`, `plan.md`
|
|
|
|
## Phase 1: Implementation
|
|
|
|
- [x] T001 Add a local Livewire search property to `ChooseEnvironment`.
|
|
- [x] T002 Add a filtered collection helper that reuses the already authorized/selectable environment collection.
|
|
- [x] T003 Replace the dynamic multi-column grid with a single-column selector layout.
|
|
- [x] T004 Move `Add environment` and `Switch workspace` to the top selector header.
|
|
- [x] T005 Add localized search, result count, clear action, and no-results copy.
|
|
- [x] T006 Hide the default raw `managed_environment` kind label while preserving non-default short labels.
|
|
- [x] T007 Add stable `data-testid` attributes for the selector surface.
|
|
|
|
## Phase 2: Tests
|
|
|
|
- [x] T008 Extend HTTP Feature assertions for selector search/action test IDs.
|
|
- [x] T009 Add Livewire Feature coverage for search filtering and no-results state.
|
|
- [x] T010 Run focused Feature tests.
|
|
|
|
## Phase 3: Browser Verification
|
|
|
|
- [x] T011 Verify `/admin/choose-environment` in the in-app browser at the current viewport.
|
|
- [x] T012 Verify no overflow at mobile and desktop viewport sizes.
|
|
|
|
## Phase 4: Final Checks
|
|
|
|
- [x] T013 Run focused Pint formatting for the changed PHP files.
|
|
- [x] T014 Run `git diff --check`.
|
|
- [x] T015 Report final Filament/Livewire/global-search/action/assets/testing/deployment posture.
|
|
|
|
## Non-Goals
|
|
|
|
- [x] NT001 No migration, persisted entity, or new source of truth.
|
|
- [x] NT002 No new route or panel provider change.
|
|
- [x] NT003 No new selector framework or shared UI taxonomy.
|
|
- [x] NT004 No destructive/high-impact action change.
|