ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity
platform-dev
TenantAtlas/specs/351-review-output-resolve-actions-v1/checklists/requirements.md
ahmido d4e4d2d109 feat: review output resolve actions v1 (spec 351) (#422) 
Implemented the first version of review output resolve actions. Included a ReviewOutputResolveActionMapper, commands to seed browser fixtures, updated CustomerReviewWorkspace, EnvironmentReviewResource, UI enforcement, and related views. Also added extensive unit, feature, and browser tests, and updated the design coverage matrix.

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #422
2026-06-04 00:55:02 +00:00

3.9 KiB
Raw Permalink Blame History

Requirements Checklist: Spec 351 - Review Output Resolve Actions v1

Purpose: Validate that Spec 351 is bounded, repo-based, constitution-aligned, and ready for a later implementation loop.
Created: 2026-06-03
Feature: specs/351-review-output-resolve-actions-v1/spec.md

Candidate Selection And Guardrail

  • CHK001 The package names the direct user-provided Spec 351 draft as the source and ties it to the review-output productization lane instead of reopening framework work.
  • CHK002 Specs 347, 349, and 350 are treated as completed or historical context only and are not rewritten or normalized.
  • CHK003 The prep explicitly documents repo-truth deviations from the user draft, especially the lack of a generic workspace-level draft-open helper and the current URL-only guidance rendering.
  • CHK004 The scope is narrowed to review-output resolve actions on workspace and detail surfaces only; provider, inbox, dashboard, portal, PDF, PSA, and AI lanes stay deferred.

Repo Truth And Architecture

  • CHK005 The spec and plan anchor the work to existing guidance producers, existing detail lifecycle actions, and the existing workspace page-action mounting pattern.
  • CHK006 The artifacts state that any new mapper or action metadata remains derived-only and request-scoped; no persistence is introduced.
  • CHK007 The plan forbids direct Blade-to-service calls and requires reuse of source-owned Filament actions plus existing lifecycle services.
  • CHK008 The action map documents which candidate actions are fully repo-backed, partially repo-backed, fallback-only, or deferred.
  • CHK009 The prep explicitly records the current create_next_review confirmation gap instead of hiding it behind optimistic wording.

UI/Productization Coverage

  • CHK010 UI Surface Impact is explicit and consistent with changing the dominant CTA semantics on CustomerReviewWorkspace and Environment Review detail.
  • CHK011 UI/Productization Coverage reuses the existing page-report identities ui-006 and ui-040 and does not invent a new route taxonomy.
  • CHK012 The spec requires one dominant next action plus honest fallback and keeps diagnostics/evidence secondary.
  • CHK013 Customer-workspace detail-mode CTA suppression remains an explicit invariant.

Testing And Validation

  • CHK014 Planned tests cover deterministic action selection, workspace integration, detail suppression/alignment, and one bounded browser smoke.
  • CHK015 Validation commands explicitly rerun Specs 347, 349, 350, and CustomerReviewWorkspace regressions.
  • CHK016 The artifacts name pint --dirty and git diff --check as final validation steps.

Readiness Gate

  • CHK017 Candidate Selection Gate passes.
  • CHK018 Spec Readiness Gate passes.
  • CHK019 No blocking product question remains; the only remaining implementation choice is whether copy retains current repo-real labels or adopts clearer wording while keeping shared behavior consistent.
  • CHK020 No application implementation has been performed in this preparation step.
  • CHK021 Preparation analyze result: pass via repo-based artifact review checklist; no standalone local speckit.analyze command is available in this repo surface.

Review Outcome

  • CHK022 Review outcome class: confirmation-required-before-executable-cta
  • CHK023 Workflow outcome: keep
  • CHK024 Final note location is the active feature PR close-out entry Guardrail / Confirmation / Smoke Coverage.

Notes

  • The executable guidance bridge is acceptable only because the spec keeps it review-output-only, reuses source-owned Filament actions, forbids a second workflow/action runtime, and requires confirmation before any dominant executable create_next_review CTA.
  • This checklist validates preparation readiness only. No application implementation, runtime test execution, or browser smoke has been performed in this prep step.