ahmido
564da05096
This PR introduces the Operation Run Actionability System. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #439
80 lines
4.5 KiB
Markdown
80 lines
4.5 KiB
Markdown
# Requirements Checklist: OperationRun Actionability System v1
|
|
|
|
**Purpose**: Validate that Spec 367 is complete, bounded, constitution-aligned, and ready for implementation.
|
|
**Created**: 2026-06-08
|
|
**Feature**: `specs/367-operationrun-actionability-system/spec.md`
|
|
|
|
## Applicability And Low-Impact Gate
|
|
|
|
- [x] CHK001 The change explicitly says reachable operator-facing surfaces are affected.
|
|
- [x] CHK002 The spec, plan, and tasks carry forward the same monitoring/dashboard/shared-detail classification.
|
|
- [x] CHK003 UI Surface Impact is coherent and does not combine `No UI surface impact` with UI changes.
|
|
- [x] CHK004 UI/Productization Coverage names affected routes/pages/widgets and coverage-artifact decision.
|
|
- [x] CHK005 Navigation and Filament panel/provider changes are explicitly no-impact.
|
|
|
|
## Requirements Quality
|
|
|
|
- [x] CHK006 The spec states the operator problem and confirmed Provider Connection CTA loop.
|
|
- [x] CHK007 Functional requirements distinguish historical execution truth, current domain truth, and UI actionability truth.
|
|
- [x] CHK008 Acceptance criteria cover provider loop, repeatable superseding, high-risk manual review, history preservation, and unknown type coverage.
|
|
- [x] CHK009 Non-goals exclude manual acknowledge UI, persistence, historical rewrite, notification redesign, and destructive actions.
|
|
- [x] CHK010 Open questions do not block implementation; ProviderConnection proof fields are an implementation-verification task.
|
|
|
|
## Constitution And Proportionality
|
|
|
|
- [x] CHK011 The proportionality review is complete for the new derived status/resolver/registry layer.
|
|
- [x] CHK012 The spec explains why a provider-only local fix is insufficient.
|
|
- [x] CHK013 No new persisted truth is introduced.
|
|
- [x] CHK014 New derived statuses have clear behavioral consequences.
|
|
- [x] CHK015 High-risk restore/promotion/purge families fail closed as manual-review.
|
|
- [x] CHK016 LEAN-001 compatibility posture is explicit.
|
|
|
|
## Shared Pattern Reuse
|
|
|
|
- [x] CHK017 Existing `OperationCatalog` remains the operation-type source.
|
|
- [x] CHK018 Existing `OperationRunActionEligibility` is reused/aligned instead of replaced.
|
|
- [x] CHK019 Existing `OperationRunLinks`, `OperationUxPresenter`, and reconciliation registry are named as shared paths.
|
|
- [x] CHK020 The allowed new actionability layer is bounded and derived-only.
|
|
- [x] CHK021 The spec forbids a parallel UI action framework.
|
|
|
|
## OperationRun UX Contract
|
|
|
|
- [x] CHK022 The feature does not create new run-start, queued notification, browser event, or terminal notification behavior.
|
|
- [x] CHK023 Historical `OperationRun` status/outcome remains execution truth.
|
|
- [x] CHK024 Current dashboard follow-up truth is separate from historical terminal truth.
|
|
- [x] CHK025 OperationRun lifecycle state remains service-owned.
|
|
|
|
## RBAC, Isolation, And Provider Boundary
|
|
|
|
- [x] CHK026 Same-workspace and same-managed-environment proof is required for superseded/resolved outcomes.
|
|
- [x] CHK027 Cross-workspace and cross-environment proof is forbidden.
|
|
- [x] CHK028 Non-member leakage is explicitly guarded by existing RBAC and scoped evaluation.
|
|
- [x] CHK029 Provider-specific consent/health semantics are bounded to provider-connection policy.
|
|
- [x] CHK030 No Graph calls are allowed during actionability evaluation or render.
|
|
|
|
## Testing And Validation
|
|
|
|
- [x] CHK031 Unit, Feature, Guard, and optional Browser lanes are named.
|
|
- [x] CHK032 Tasks include failing tests before runtime changes where practical.
|
|
- [x] CHK033 Tasks include registry coverage for all known operation types.
|
|
- [x] CHK034 Tasks include guards against direct UI use of historical terminal-follow-up methods.
|
|
- [x] CHK035 Tasks include provider-loop, repeatable superseded, high-risk manual-review, cross-scope, and DB-only tests.
|
|
- [x] CHK036 Validation commands are explicit and bounded.
|
|
|
|
## Deployment / Ops
|
|
|
|
- [x] CHK037 No migrations are planned.
|
|
- [x] CHK038 No env vars are planned.
|
|
- [x] CHK039 No queues, workers, scheduler, storage, package, asset, or panel-provider changes are planned.
|
|
- [x] CHK040 Staging validation is noted because operator attention routing changes.
|
|
|
|
## Review Outcome
|
|
|
|
- [x] CHK041 Review outcome class: `acceptable-special-case`.
|
|
- [x] CHK042 Workflow outcome: `keep`.
|
|
- [x] CHK043 Final note location: implementation close-out / active PR close-out for UI coverage and guardrail proof.
|
|
|
|
## Notes
|
|
|
|
Spec 367 is ready for implementation prep-wise. The main implementation risk is over-aggressive superseding; the tasks deliberately default incomplete proof to actionable/manual-review.
|