ahmido
94877c9a66
Applied the decision-first diagnostic surface IA contract to EnvironmentDiagnostics and SupportDiagnostics bundles. Added recommended_first_check and separated technical metadata as per Spec 373. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #444
20 lines
2.4 KiB
Markdown
20 lines
2.4 KiB
Markdown
# Diagnostic Safety Checklist
|
|
|
|
Status: complete after source review, focused tests, and browser smoke.
|
|
|
|
| Surface | Safety item | Status | Evidence |
|
|
|---|---|---|---|
|
|
| Environment Diagnostics | Single top summary leads before blocker details | pass | `TenantDiagnosticsRepairsTest`; browser screenshot `001-environment-diagnostics-after.png` |
|
|
| Environment Diagnostics | Missing-owner path, when repo-backed, states failed condition, impact, and next check | pass | `TenantDiagnosticsRepairsTest` state-driven presentation path |
|
|
| Environment Diagnostics | Duplicate-membership path states supportability/access-scope issue and preserves merge action | pass | `TenantDiagnosticsRepairsTest` duplicate membership tests |
|
|
| Environment Diagnostics | Both-blocker path shows both blockers with one dominant next action | pass | `TenantDiagnosticsRepairsTest` both-blocker test |
|
|
| Environment Diagnostics | No-action path says one calm no-action message and avoids broad health claims | pass | `TenantDiagnosticsRepairsTest`; browser screenshot |
|
|
| Environment Diagnostics | Repair actions retain `->action(...)`, `->requiresConfirmation()`, destructive styling, `TENANT_MANAGE`, `UiEnforcement`, server-side service ownership, and audit | pass | Source review plus confirmation/action/audit tests |
|
|
| Environment Diagnostics | Render remains DB-local with no Graph/provider HTTP | pass | `bindFailHardGraphClient()` render tests and source review |
|
|
| Support diagnostics modal | Summary, dominant issue, first check, redaction, freshness/completeness precede reference sections | pass | Support diagnostics action tests; browser screenshot `002-support-diagnostics-after-or-blocked.png` |
|
|
| Support diagnostics modal | Redaction markers and raw/support details remain lower priority and redacted | pass | Existing redaction tests and updated modal tests |
|
|
| Support diagnostics modal | Unavailable context is not rendered as a fake link | pass | Builder fallback unit test |
|
|
| Support diagnostics modal | Authorization, telemetry, audit, and redaction behavior remain unchanged | pass | `SupportDiagnostics` filter: 39 passed |
|
|
| Provider Connections / Required Permissions | No reimplementation or shared-helper regression | pass | Final diff review: no Spec 353 runtime files touched |
|
|
| System panel | Remains deferred; no auth/fixture work added | pass | Final diff review: no system route/auth fixture changes |
|