ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity
platform-dev
TenantAtlas/specs/373-diagnostic-surface-separation/artifacts/source-audit-summary.md
ahmido 94877c9a66 feat(ui): implement diagnostic surface separation (#444) 
Applied the decision-first diagnostic surface IA contract to EnvironmentDiagnostics and SupportDiagnostics bundles. Added recommended_first_check and separated technical metadata as per Spec 373.

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #444
2026-06-12 20:31:17 +00:00

3.9 KiB
Raw Permalink Blame History

Source Audit Summary

Status: complete source audit; implementation close-out is recorded in sibling artifacts.

Repo Safety

  • Active branch: 373-diagnostic-surface-separation.
  • Base HEAD before implementation: 22214f22 feat(ui): implement customer auditor surface safety pass (#443).
  • Initial dirty state: untracked active spec package only.
  • Runtime edits are expected to stay inside Environment Diagnostics, support diagnostics modal/bundle presentation, focused tests, active spec artifacts, and proportional UI audit artifacts.

Source Inputs

Source Availability Verification Class Use In Spec 373
Active spec.md, plan.md, tasks.md, checklist available repo-verified Governing scope and gates
Spec 368 audit/findings/scorecard/browser notes available browser-verified where screenshots exist Before-state and source finding
Spec 370 surface contract artifacts available repo-verified completed spec artifact Diagnostic page contract
Spec 353 provider-readiness artifacts available repo-verified completed implementation artifacts Completed Provider Connections and Required Permissions boundary
Spec 371 validation/browser artifacts available repo-verified completed implementation artifacts Summary-first implementation close-out pattern
Spec 372 validation/browser artifacts available repo-verified completed implementation artifacts Customer/support raw-detail separation pattern

Spec 368 Findings Used

Surface Evidence Result For Spec 373
Environment Diagnostics UI-AUDIT-368-F08, screenshot artifacts/screenshots/admin/015-diagnostic-surface-diagnostics-environment-diagnostics.png, score 3.3 Primary implementation target
Required Permissions blocked screenshot 016-configuration-surface-settings-required-permissions-error.png Completed by Spec 353; fixture gaps are context only
System panel blocked screenshot 031-system-surface-dashboard-system-dashboard-error.png Deferred; do not fix system auth or fixtures

Current Runtime Truth

  • EnvironmentDiagnostics is a Filament page with no navigation registration and two existing capability-gated repair actions: bootstrapOwner and mergeDuplicateMemberships.
  • Both repair actions use Action::make(...)->action(...), ->requiresConfirmation(), UiEnforcement, Capabilities::TENANT_MANAGE, and destructive treatment.
  • ManagedEnvironmentDiagnosticsService::tenantHasNoOwners() currently returns false, so the missing-owner presentation path exists but is not the repo-default repair path; current tests preserve that workspace roles own role recovery.
  • environment-diagnostics.blade.php currently renders a sparse header, one blocker card per issue, or All good.
  • SupportDiagnosticBundleBuilder already composes redacted support bundles from stored workspace/environment/provider/operation/finding/report/review/audit truth.
  • support-diagnostic-bundle.blade.php already uses Filament sections, badges, redaction notes, and repo-backed links. The gap is hierarchy and recommended first-check clarity.

Completed-Spec Guardrail

Related spec Status signal Treatment
Spec 353 Provider Connections / Required Permissions checked tasks and UI reports context/regression only
Spec 371 operator surfaces validation and browser proof complete pattern/context only
Spec 372 customer/auditor surfaces validation and browser proof complete pattern/context only
Spec 370 IA contract completed preparation artifact consumed as contract

Scope Decision

Active implementation is limited to Environment Diagnostics first-viewport guidance, support diagnostics modal hierarchy, focused tests, browser smoke, and Spec 373 artifacts. Provider Connections, Required Permissions, System panel, OperationRun lifecycle, provider health, permission calculation, Graph contracts, migrations, assets, and panel providers are out of scope.