ahmido
94877c9a66
Applied the decision-first diagnostic surface IA contract to EnvironmentDiagnostics and SupportDiagnostics bundles. Added recommended_first_check and separated technical metadata as per Spec 373. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #444
76 lines
4.8 KiB
Markdown
76 lines
4.8 KiB
Markdown
# Validation Report
|
|
|
|
Status: complete.
|
|
|
|
## Repo Safety
|
|
|
|
- Active branch: `373-diagnostic-surface-separation`.
|
|
- Base HEAD before implementation: `22214f22 feat(ui): implement customer auditor surface safety pass (#443)`.
|
|
- Initial dirty state: untracked active spec package only.
|
|
- Spec Readiness Gate: PASS.
|
|
- Implementation Scope Gate: PASS.
|
|
- Post-Implementation Analysis Gate: PASS after one bounded implementation/test/browser/artifact cycle.
|
|
- Merge Readiness Gate: PASS for manual review.
|
|
|
|
## Commands
|
|
|
|
| Command | Purpose | Result |
|
|
|---|---|---|
|
|
| `cd apps/platform && ./vendor/bin/sail artisan test tests/Feature/Filament/TenantDiagnosticsRepairsTest.php tests/Feature/SupportDiagnostics/TenantSupportDiagnosticActionTest.php tests/Feature/SupportDiagnostics/OperationRunSupportDiagnosticActionTest.php` | Initial focused red/green test pack | First run failed on missing new hierarchy; final run passed: 11 tests, 108 assertions |
|
|
| `cd apps/platform && ./vendor/bin/sail artisan test tests/Unit/Support/SupportDiagnostics/SupportDiagnosticBundleBuilderTest.php` | Builder fallback and unavailable-link behavior | passed: 5 tests, 26 assertions |
|
|
| `cd apps/platform && ./vendor/bin/sail artisan test --compact --filter=EnvironmentDiagnostics` | Required Environment Diagnostics filter from tasks | completed but returned `No tests found` because Pest descriptions are named around tenant diagnostics repairs |
|
|
| `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantDiagnosticsRepairsTest.php` | Effective Environment Diagnostics hierarchy and action safety | passed: 6 tests, 49 assertions |
|
|
| `cd apps/platform && ./vendor/bin/sail artisan test --compact --filter=SupportDiagnostics` | Support diagnostics modal hierarchy, redaction, authorization, audit/telemetry | passed: 39 tests, 228 assertions |
|
|
| `cd apps/platform && ./vendor/bin/sail pint --dirty` | Formatting after PHP changes | passed: 0 files changed |
|
|
| `git diff --check` | Static diff whitespace check | passed |
|
|
| Browser smoke for Environment Diagnostics and support diagnostics modal | Real-browser hierarchy and runtime check | passed with screenshots |
|
|
|
|
## Browser Results
|
|
|
|
- Environment Diagnostics URL: `http://localhost/admin/workspaces/spec-352-guidance-browser-audit/environments/spec-352-audit-no-urgent/diagnostics`.
|
|
- Support diagnostics host URL: `http://localhost/admin/workspaces/spec-352-guidance-browser-audit/environments/spec-352-audit-no-urgent`.
|
|
- Fixture: existing `/admin/local/smoke-login` route with `smoke-requester+352@tenantpilot.local`, workspace `spec-352-guidance-browser-audit`, environment `spec-352-audit-no-urgent`.
|
|
- Screenshots:
|
|
- `specs/373-diagnostic-surface-separation/artifacts/screenshots/001-environment-diagnostics-after.png`
|
|
- `specs/373-diagnostic-surface-separation/artifacts/screenshots/002-support-diagnostics-after-or-blocked.png`
|
|
- Console: in-app Browser tab reported zero current console errors. Boost browser log feed returned stale unrelated entries dated June 6-8, 2026.
|
|
|
|
## Runtime Files Changed
|
|
|
|
- `apps/platform/app/Filament/Pages/EnvironmentDiagnostics.php`
|
|
- `apps/platform/resources/views/filament/pages/environment-diagnostics.blade.php`
|
|
- `apps/platform/app/Support/SupportDiagnostics/SupportDiagnosticBundleBuilder.php`
|
|
- `apps/platform/resources/views/filament/modals/support-diagnostic-bundle.blade.php`
|
|
- `apps/platform/tests/Feature/Filament/TenantDiagnosticsRepairsTest.php`
|
|
- `apps/platform/tests/Feature/SupportDiagnostics/TenantSupportDiagnosticActionTest.php`
|
|
- `apps/platform/tests/Feature/SupportDiagnostics/OperationRunSupportDiagnosticActionTest.php`
|
|
- `apps/platform/tests/Unit/Support/SupportDiagnostics/SupportDiagnosticBundleBuilderTest.php`
|
|
|
|
## Documentation And Artifact Files Changed
|
|
|
|
- `docs/ui-ux-enterprise-audit/page-reports/ui-012-environment-diagnostics.md`
|
|
- `docs/ui-ux-enterprise-audit/route-inventory.md`
|
|
- `specs/373-diagnostic-surface-separation/` artifacts, tasks, and screenshots.
|
|
|
|
## Final Dirty State
|
|
|
|
- Tracked runtime/docs files are modified.
|
|
- `docs/ui-ux-enterprise-audit/page-reports/ui-012-environment-diagnostics.md` is untracked.
|
|
- `specs/373-diagnostic-surface-separation/` remains untracked as the active spec package from the start of the session.
|
|
|
|
## Deployment Impact
|
|
|
|
- No migration.
|
|
- No env var.
|
|
- No queue or scheduler change.
|
|
- No storage change.
|
|
- No package change.
|
|
- No panel provider registration change.
|
|
- No global search change.
|
|
- No Filament asset registration change; existing deployment reminder remains `cd apps/platform && php artisan filament:assets` only when registered Filament assets change.
|
|
|
|
## Recommended Next Spec
|
|
|
|
- No immediate follow-up is required for Spec 373 scope.
|
|
- Deferred items remain as already scoped: System panel auth/fixture reachability and any future blocker-state browser fixture should be handled by separate specs if product priority warrants it.
|