ahmido
94877c9a66
Applied the decision-first diagnostic surface IA contract to EnvironmentDiagnostics and SupportDiagnostics bundles. Added recommended_first_check and separated technical metadata as per Spec 373. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #444
61 lines
4.5 KiB
Markdown
61 lines
4.5 KiB
Markdown
# Requirements Checklist: Spec 373 - Diagnostic Surface Separation v1
|
|
|
|
**Purpose**: Validate preparation readiness only. This checklist does not certify implementation, runtime tests, or browser proof.
|
|
**Created**: 2026-06-12
|
|
**Feature**: `specs/373-diagnostic-surface-separation/spec.md`
|
|
|
|
## Candidate Selection Gate
|
|
|
|
- [x] CHK001 The selected candidate is directly provided by the user and is also present as Spec 368 Candidate D.
|
|
- [x] CHK002 Spec 370 explicitly deferred Diagnostic Surface Separation as a follow-up consumer of the global IA contract.
|
|
- [x] CHK003 The prepared slice is narrowed to remaining diagnostic/support surfaces after completed Spec 353 provider-readiness work.
|
|
- [x] CHK004 Completed Spec 353, Spec 371, and Spec 372 packages are treated as historical/context artifacts only.
|
|
- [x] CHK005 The spec does not rewrite, normalize, or remove completed-spec implementation close-out, validation, browser, or checked-task evidence.
|
|
- [x] CHK006 Close alternatives are deferred with rationale: Provider Connections, Required Permissions, System panel auth/fixtures, OperationRun detail, and UI bloat guard automation.
|
|
|
|
## Scope And Constitution Alignment
|
|
|
|
- [x] CHK007 `spec.md` states problem, user value, smallest viable slice, non-goals, acceptance criteria, assumptions, and risks.
|
|
- [x] CHK008 `spec.md` includes the mandatory Spec Candidate Check and approval score.
|
|
- [x] CHK009 `spec.md` includes UI Surface Impact, UI/Productization Coverage, Shared Pattern Reuse, OperationRun UX Impact, Provider Boundary, Decision-First, Audience-Aware Disclosure, UI/UX Surface Classification, Operator Surface Contract, Proportionality Review, and Testing/Lane impact sections.
|
|
- [x] CHK010 No new persisted entity, table, enum/status family, provider framework, permission engine, or cross-domain UI framework is planned.
|
|
- [x] CHK011 Existing destructive Environment Diagnostics repair actions are identified and must preserve confirmation, capability gating, server authorization, and audit ownership.
|
|
- [x] CHK012 Filament v5 / Livewire v4 compliance, `apps/platform/bootstrap/providers.php` provider location, global search posture, and asset strategy are explicit.
|
|
- [x] CHK013 Provider/platform vocabulary keeps provider-specific terms in provider-owned or technical/support detail.
|
|
|
|
## Plan Readiness
|
|
|
|
- [x] CHK014 `plan.md` names the concrete repo surfaces likely affected.
|
|
- [x] CHK015 `plan.md` states no migration, env var, queue, scheduler, storage, package, panel/provider, or global-search change is expected.
|
|
- [x] CHK016 `plan.md` identifies the narrow reuse paths and forbids a generic diagnostic framework.
|
|
- [x] CHK017 `plan.md` includes a bounded test strategy with Feature/Livewire and Browser lanes.
|
|
- [x] CHK018 `plan.md` includes rollout and review controls for browser fixture gaps, completed-spec boundaries, and UI audit artifacts.
|
|
|
|
## Task Readiness
|
|
|
|
- [x] CHK019 `tasks.md` is ordered by preparation, tests, implementation, browser proof, validation, and close-out.
|
|
- [x] CHK020 Tests are listed before runtime implementation tasks.
|
|
- [x] CHK021 Tasks include source-audit, affected-files, diagnostic-contracts, screenshot-index, implementation-notes, browser-verification, diagnostic-safety, and validation artifacts.
|
|
- [x] CHK022 Tasks explicitly protect Provider Connections and Required Permissions as completed Spec 353 context.
|
|
- [x] CHK023 Tasks include targeted validation commands and browser proof without requiring a full suite by default.
|
|
- [x] CHK024 Non-goals are listed as checkable implementation constraints.
|
|
|
|
## Open Questions And Risks
|
|
|
|
- [x] CHK025 No open question blocks safe implementation preparation.
|
|
- [x] CHK026 Browser reachability for Environment Diagnostics and support diagnostics modal is intentionally deferred to implementation verification and has a documented blocked-path rule.
|
|
- [x] CHK027 `/system` auth/fixture reachability is explicitly deferred and must not be solved in this spec.
|
|
- [x] CHK028 Required Permissions reachability is treated as Spec 353-completed unless a fresh shared-code regression appears.
|
|
|
|
## Review Outcome
|
|
|
|
- [x] CHK029 Candidate Selection Gate result: pass.
|
|
- [x] CHK030 Spec Readiness Gate result: pass for implementation handoff.
|
|
- [x] CHK031 Preparation scope only: no application implementation was performed by this package.
|
|
|
|
## Notes
|
|
|
|
- Review outcome class: `acceptable-special-case`.
|
|
- Workflow outcome: `keep`.
|
|
- Main caveat: the later implementation must prove browser reachability with existing fixtures and must not broaden into fixture/auth infrastructure if a scoped modal/page is blocked.
|