ahmido
0b5cadc234
## Summary - add a shared diff presentation layer under `app/Support/Diff` with deterministic row classification, summary derivation, and value stringification - centralize diff-state badge semantics through `BadgeCatalog` with a dedicated `DiffRowStatusBadge` - add reusable Filament diff partials, focused Pest coverage, and the full SpecKit artifact set for spec 141 ## Testing - `vendor/bin/sail artisan test --compact tests/Unit/Support/Diff/DiffRowStatusTest.php tests/Unit/Support/Diff/DiffRowTest.php tests/Unit/Support/Diff/DiffPresenterTest.php tests/Unit/Support/Diff/ValueStringifierTest.php tests/Unit/Badges/DiffRowStatusBadgeTest.php tests/Feature/Support/Diff/SharedDiffSummaryPartialTest.php tests/Feature/Support/Diff/SharedDiffRowPartialTest.php tests/Feature/Support/Diff/SharedInlineListDiffPartialTest.php` - `vendor/bin/sail bin pint --dirty --format agent` ## Filament / Livewire Contract - Livewire v4.0+ compliance: unchanged and respected; this feature adds presentation support only within the existing Filament v5 / Livewire v4 stack - Provider registration: unchanged; no panel/provider changes were required, so `bootstrap/providers.php` remains the correct registration location - Global search: unchanged; no Resource or global-search behavior was added or modified - Destructive actions: none introduced in this feature - Asset strategy: no new registered Filament assets; shared Blade partials rely on the existing asset pipeline and standard deploy step for `php artisan filament:assets` when assets change generally - Testing coverage: presenter, DTOs, stringifier, badge semantics, summary partial, row partial, and inline-list partial are covered by focused Pest unit and feature tests ## Notes - Spec checklist status is complete for `specs/141-shared-diff-presentation-foundation/checklists/requirements.md` - This PR preserves specialized diff renderers and documents incremental adoption rather than forcing migration in the same change Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #170
48 lines
1.6 KiB
PHP
48 lines
1.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Support\Diff\DiffRow;
|
|
use App\Support\Diff\DiffRowStatus;
|
|
|
|
it('renders inline list fragments with semantic labels muted unchanged items and stable reading order', function (): void {
|
|
$baseline = array_map(
|
|
static fn (int $index): string => sprintf('Group %02d', $index),
|
|
range(1, 24),
|
|
);
|
|
|
|
$current = array_map(
|
|
static fn (int $index): string => sprintf('Group %02d', $index),
|
|
range(2, 25),
|
|
);
|
|
|
|
$html = (string) $this->view('filament.partials.diff.inline-list', [
|
|
'row' => new DiffRow(
|
|
key: 'group_assignments',
|
|
label: 'Group assignments',
|
|
status: DiffRowStatus::Changed,
|
|
oldValue: $baseline,
|
|
newValue: $current,
|
|
isListLike: true,
|
|
addedItems: ['Group 25'],
|
|
removedItems: ['Group 01'],
|
|
unchangedItems: array_values(array_intersect($current, $baseline)),
|
|
),
|
|
'compact' => false,
|
|
'dimUnchanged' => true,
|
|
]);
|
|
|
|
expect($html)->toContain('Added items')
|
|
->and($html)->toContain('Removed items')
|
|
->and($html)->toContain('Unchanged items')
|
|
->and($html)->toContain('Group 25')
|
|
->and($html)->toContain('Group 01')
|
|
->and($html)->toContain('Group 12')
|
|
->and($html)->toContain('text-gray-500')
|
|
->and($html)->toContain('dark:text-gray-400')
|
|
->and(substr_count($html, 'rounded-full'))->toBe(25);
|
|
|
|
expect(strpos($html, 'Added items'))->toBeLessThan(strpos($html, 'Removed items'));
|
|
expect(strpos($html, 'Removed items'))->toBeLessThan(strpos($html, 'Unchanged items'));
|
|
});
|