ahmido
73a3a62451
## Summary - unify empty-state UX across the six in-scope Filament list pages - move empty-state ownership toward resource `table()` definitions while preserving existing RBAC behavior - add focused Pest coverage for empty-state rendering, CTA outcomes, populated-state regression behavior, and action-surface compliance - add the Spec 122 planning artifacts and product discovery documents used for this pass ## Changed surfaces - `PolicyResource` - `BackupSetResource` - `RestoreRunResource` - `BackupScheduleResource` - `WorkspaceResource` - `AlertDeliveryResource` ## Tests - `vendor/bin/sail artisan test --compact tests/Feature/Filament/EmptyStateConsistencyTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/Filament/Alerts/AlertDeliveryViewerTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/Filament/CreateCtaPlacementTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/PolicySyncStartSurfaceTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/BackupScheduling/BackupScheduleLifecycleAuthorizationTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/Filament/BackupSetUiEnforcementTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/Filament/RestoreRunUiEnforcementTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/Guards/ActionSurfaceContractTest.php` - `vendor/bin/sail bin pint --dirty --format agent` ## Notes - Filament v5 / Livewire v4.0+ compliance is preserved. - Panel provider registration remains unchanged in `bootstrap/providers.php`. - No new globally searchable resources were added. - Destructive actions were not introduced by this pass. - Alert Deliveries is documented as the explicit no-header-action exemption for the empty-state CTA relocation rule. - Manual light/dark visual QA evidence is still expected in the PR/review artifact set for the remaining checklist items (`T018`, `T025`). Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #148
92 lines
4.1 KiB
Markdown
92 lines
4.1 KiB
Markdown
# Discoveries
|
|
|
|
> Things found during implementation that don't belong in the current spec.
|
|
> Review weekly. Promote to [spec-candidates.md](spec-candidates.md) or discard.
|
|
|
|
**Last reviewed**: 2026-03-08
|
|
|
|
---
|
|
|
|
## 2026-03-08 — Alert `sla_due` event type is dead code
|
|
- **Source**: Spec 109 (Review Pack Export)
|
|
- **Observation**: `sla_due` alert rule event type exists in the schema but no producer dispatches it. Dead code path.
|
|
- **Category**: cleanup
|
|
- **Priority**: low
|
|
- **Suggested follow-up**: Remove or implement. If SLA alerting is a future feature, document the intent; otherwise delete.
|
|
|
|
---
|
|
|
|
## 2026-03-08 — Alert Deliveries header-action exemption needs permanent documentation
|
|
- **Source**: Spec 122 (Empty State Consistency)
|
|
- **Observation**: Alert Deliveries is the first resource with an explicit UX-001 relocation exemption — its CTA exists only in the empty state and does NOT relocate to the header. This needs to remain documented so future developers don't "fix" it.
|
|
- **Category**: documentation
|
|
- **Priority**: low
|
|
- **Suggested follow-up**: Ensure the exemption is captured in the Action Surface Contract guard tests and/or resource-level comments.
|
|
|
|
---
|
|
|
|
## 2026-03-08 — Historical findings backfill for `source` field
|
|
- **Source**: Spec 101 (Golden Master Baseline Governance)
|
|
- **Observation**: The `source` field on findings was added but historical findings may not be backfilled. Reporting accuracy depends on this.
|
|
- **Category**: data integrity
|
|
- **Priority**: medium
|
|
- **Suggested follow-up**: One-time migration or backfill job to classify existing findings by source.
|
|
|
|
---
|
|
|
|
## 2026-03-08 — Baseline profile hard-delete deferred
|
|
- **Source**: Spec 101 (Golden Master Baseline Governance)
|
|
- **Observation**: Baseline profiles can only be archived, not hard-deleted, in v1. If archive accumulation becomes a problem, a hard-delete with cascade needs to be built.
|
|
- **Category**: feature gap
|
|
- **Priority**: low
|
|
- **Suggested follow-up**: Monitor archive count. Spec only if it becomes a user-reported issue.
|
|
|
|
---
|
|
|
|
## 2026-03-08 — Drift engine hard-fail when no Inventory Sync exists
|
|
- **Source**: Spec 119 (Baseline Drift Engine Cutover)
|
|
- **Observation**: Currently drift capture does NOT hard-fail when no completed Inventory Sync exists. This was deferred as a "larger product behavior change."
|
|
- **Category**: hardening
|
|
- **Priority**: medium
|
|
- **Suggested follow-up**: Evaluate whether capturing drift without a baseline sync produces misleading results. If so, enforce the prerequisite.
|
|
|
|
---
|
|
|
|
## 2026-03-08 — Inventory landing page may be redundant
|
|
- **Source**: Product review, dashboard analysis
|
|
- **Observation**: The Inventory nav section has a landing "Home" page that may not add value beyond what the Policies and Policy Versions pages provide directly.
|
|
- **Category**: UX polish
|
|
- **Priority**: low
|
|
- **Suggested follow-up**: Consider making Inventory a pure navigation group (no landing page) in a future IA cleanup.
|
|
|
|
---
|
|
|
|
## 2026-03-08 — Dashboard lacks enterprise-grade visual hierarchy
|
|
- **Source**: Product review 2026-03-08
|
|
- **Observation**: Stat widgets show raw numbers without trends. "Needs Attention" zone is visually equal to other content. Baseline Governance card is small and easy to miss. Operations table lacks duration/count columns.
|
|
- **Category**: UX polish
|
|
- **Priority**: medium
|
|
- **Suggested follow-up**: Promoted to spec-candidates.md as "Dashboard Polish (Enterprise-grade)".
|
|
|
|
---
|
|
|
|
## 2026-03-08 — Performance indexes for system console windowed queries
|
|
- **Source**: Spec 114 (System Console Control Tower)
|
|
- **Observation**: EXPLAIN baselines don't show pressure yet, but windowed queries on operation_runs could become slow at scale. Indexes were explicitly deferred.
|
|
- **Category**: performance
|
|
- **Priority**: low
|
|
- **Suggested follow-up**: Monitor query times. Add indexes proactively if run count exceeds ~100k.
|
|
|
|
---
|
|
|
|
## Template
|
|
|
|
```md
|
|
## YYYY-MM-DD — Short title
|
|
- **Source**: Spec NNN (Name) | chat | audit | coding
|
|
- **Observation**:
|
|
- **Category**: feature gap | cleanup | hardening | UX polish | performance | documentation | data integrity
|
|
- **Priority**: low | medium | high
|
|
- **Suggested follow-up**:
|
|
```
|