ahmido
2bf5de4663
Summary Consolidates the “Tenant Operate Hub” work (Spec 085) and the follow-up adjustments from the 086 session merge into a single branch ready to merge into dev. Primary focus: stabilize Ops/Operate Hub UX flows, tighten/align authorization semantics, and make the full Sail test suite green. Key Changes Ops UX / Verification Readonly members can view verification operation runs (reports) while starting verification remains restricted. Normalized failure reason-code handling and aligned UX expectations with the provider reason-code taxonomy. Onboarding wizard UX “Start verification” CTA is hidden while a verification run is active; “Refresh” is shown during in-progress runs. Treats provider_permission_denied as a blocking reason (while keeping legacy compatibility). Test + fixture hardening Standardized use of default provider connection fixtures in tests where sync/restore flows require it. Fixed multiple Filament URL/tenant-context test cases to avoid 404s and reduce tenancy routing brittleness. Policy sync / restore safety Enrollment configuration type collision classification tests now exercise the real sync path (with required provider connection present). Restore edge-case safety tests updated to reflect current provider-connection requirements. Testing vendor/bin/sail artisan test --compact (green) vendor/bin/sail bin pint --dirty (green) Notes Includes merged 086 session work already (no separate PR needed). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@ebc83aaa-d947-4a08-b88e-bd72ac9645f7.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.fritz.box> Reviewed-on: #103
42 lines
1.6 KiB
Markdown
42 lines
1.6 KiB
Markdown
# Contracts (Spec 086)
|
|
|
|
This spec does not introduce a new public HTTP API surface.
|
|
|
|
## Canonical OperationRun contract (internal)
|
|
|
|
Spec 086 tightens and standardizes the internal contract for how operations are created, identified, and displayed.
|
|
|
|
### Run creation contract
|
|
|
|
- Start surfaces must create the `operation_runs` row **before** dispatching asynchronous work.
|
|
- Jobs must receive the `OperationRun` (or its id) and must **not** attempt a fallback-create.
|
|
|
|
### Identity / idempotency contract
|
|
|
|
Operation run identity is enforced by a partial unique index for active states.
|
|
|
|
Planned identity rules by type:
|
|
- `inventory.sync` and `directory_groups.sync`: deterministic identity (while-active dedupe)
|
|
- `backup_schedule.run_now` and `backup_schedule.retry`: unique-per-click identity (nonce)
|
|
- `backup_schedule.scheduled`: deterministic identity by `(backup_schedule_id, scheduled_for)` (strict)
|
|
|
|
### Context contract (selected keys)
|
|
|
|
The `operation_runs.context` JSON is used for:
|
|
- “Target” display (via `target_scope`)
|
|
- “Related” deep links (via `OperationRunLinks::related`)
|
|
- provenance (trigger source, schedule id, initiating user)
|
|
|
|
Keys referenced in existing UI code:
|
|
- `provider_connection_id`
|
|
- `backup_schedule_id`
|
|
- `backup_schedule_run_id`
|
|
- `restore_run_id`
|
|
- `target_scope`
|
|
|
|
## Graph Contract Registry
|
|
|
|
All Microsoft Graph calls remain required to go through `GraphClientInterface` and be modeled in `config/graph_contracts.php`.
|
|
|
|
Spec 086 removes Graph calls from Filament render/search/label callbacks (DB-only rendering), and moves those lookups behind cached tables + asynchronous sync operations.
|