ahmido
6a5b8a3a11
Some checks failed
Main Confidence / confidence (push) Failing after 50s
## Summary - add a config-seeded canonical control catalog plus shared resolution primitives and Microsoft subject bindings - propagate canonical control references into findings-derived evidence snapshots and tenant review composition - add the feature spec artifacts and focused Pest coverage, plus the supporting workspace and Sail helper adjustments included in this branch ## Testing - cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Governance/CanonicalControlCatalogTest.php tests/Unit/Governance/CanonicalControlResolverTest.php tests/Feature/Governance/CanonicalControlResolutionIntegrationTest.php tests/Feature/Evidence/EvidenceSnapshotCanonicalControlReferenceTest.php tests/Feature/TenantReview/TenantReviewCanonicalControlReferenceTest.php tests/Feature/PlatformRelocation/CommandModelSmokeTest.php - cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #272
1.7 KiB
1.7 KiB
Specification Quality Checklist: Canonical Control Catalog Foundation
Purpose: Capture specification completeness and quality at planning handoff while keeping post-plan status aligned with the current artifact set
Created: 2026-04-24
Feature: spec.md
Content Quality
- No implementation algorithms, code diffs, or migration steps
- Focused on user value and business needs
- Repo-specific constitutional and provider-boundary references remain intentional and bounded
- All mandatory sections completed
Requirement Completeness
- No [NEEDS CLARIFICATION] markers remain
- Requirements are testable and unambiguous
- Success criteria are measurable
- Success criteria are technology-agnostic
- All acceptance scenarios are defined
- Edge cases are identified
- Scope is clearly bounded
- Dependencies and assumptions identified
Feature Readiness
- All functional requirements have clear acceptance criteria
- User scenarios cover primary flows
- Feature meets measurable outcomes defined in Success Criteria
- No implementation algorithms or file-by-file execution steps leak into specification
Notes
- This checklist records readiness at planning handoff;
plan.md,research.md,data-model.md,quickstart.md,contracts/, andtasks.mdare the implementation-facing artifacts for this feature. - The first slice remains product-seeded, persistence-neutral, and bounded to shared control resolution plus downstream evidence and tenant review adoption.
- No clarification markers remain, and the current scope is aligned across spec, plan, tasks, and supporting artifacts for implementation.