## Summary - remove tenant-based Graph options access from runtime service paths and enforce provider-only resolution - add `MicrosoftGraphOptionsResolver` and `ProviderConfigurationRequiredException` for centralized, actionable provider-config errors - turn `Tenant::graphOptions()` into a fail-fast kill switch to prevent legacy runtime usage - add and update tests (including guardrail) to enforce no reintroduction in `app/` - update Spec 088 artifacts (`spec`, `plan`, `research`, `tasks`, checklist) ## Validation - `vendor/bin/sail bin pint --dirty` - `vendor/bin/sail artisan test --compact --filter=NoLegacyTenantGraphOptions` - `vendor/bin/sail artisan test --compact tests/Feature/Filament` - `CI=1 vendor/bin/sail artisan test --compact` ## Notes - Branch includes the guardrail test for legacy callsite detection in `app/`. - Full suite currently green: 1227 passed, 5 skipped. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #105
973 B
973 B
Quickstart — Remove Legacy Tenant Graph Options
Preconditions
- Sail is running:
vendor/bin/sail up -d
What to run (during implementation)
1) Run the guardrail test (fast)
Once implemented, run the guard that enforces no deprecated accessor usage:
vendor/bin/sail artisan test --compact --filter=NoLegacyTenantGraphOptions
2) Run the most relevant test subset
After refactoring Graph option sourcing, run tests touching provider resolution / Graph-enabled flows:
vendor/bin/sail artisan test --compact tests/Feature/Guards
Manual sanity checks (optional)
- If a tenant has no default provider connection, Graph-enabled flows should fail with a clear “provider connection required” style error.
- If a tenant has a configured default provider connection, flows should continue to work using
ProviderGateway::graphOptions($connection).
Formatting
Before finalizing the implementation PR:
vendor/bin/sail bin pint --dirty