Some checks failed
Main Confidence / confidence (push) Failing after 1m1s
## Summary - integrate the current `platform-dev` branch into `dev` - bring the latest platform work from the integration branch into the main development branch - include the recent findings lifecycle backfill removal slice together with the already accumulated `platform-dev` changes ## Scope - source branch: `platform-dev` - target branch: `dev` - branch role: integration PR, not a single-feature PR ## Validation - branch state reviewed before PR creation - `platform-dev` is ahead of `dev` with the expected integration history - this PR intentionally carries the accumulated `platform-dev` commits into `dev` ## Notes - this is the correct merge direction for the current workflow, where feature branches land in `platform-dev` first and `platform-dev` is then merged into `dev` - after merging, `platform-dev` can be recreated fresh from `dev` as usual Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #295
3.6 KiB
3.6 KiB
Quickstart — Remove Findings Lifecycle Backfill Runtime Surfaces
Prereqs
- Docker running
- Laravel Sail dependencies installed
- Existing platform-operator and tenant-user factories available for targeted tests
- Existing findings workflow fixtures available for regression coverage
Run locally
- Start containers:
cd apps/platform && ./vendor/bin/sail up -d - No schema change is expected, but use the normal repo baseline before running tests:
export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && cd apps/platform && ./vendor/bin/sail artisan migrate --no-interaction - Run targeted tests after implementation:
export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/System/OpsRunbooks/RemoveFindingsLifecycleBackfillRunbookSurfaceTest.php tests/Feature/System/OpsControls/RemoveFindingsLifecycleBackfillControlTraceTest.php tests/Feature/Findings/RemoveFindingsLifecycleBackfillActionTest.php tests/Feature/Console/RemoveFindingsLifecycleBackfillCommandsTest.phpexport PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Support/OperationCatalog/RemoveFindingsLifecycleBackfillCatalogTraceTest.php tests/Unit/Support/Auth/RemoveFindingsLifecycleBackfillCapabilityTraceTest.phpexport PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/OperationalControls/NoAdHocOperationalControlBypassTest.phpexport PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings/FindingWorkflowRegressionTest.php
- Format after implementation:
export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent
Manual smoke after implementation
- Sign in to
/systemas a platform operator and confirm/system/ops/runbooksno longer showsRebuild Findings Lifecycle, its preflight action, or its run modal. - Sign in to
/admin/t/{tenant}/findingsas an entitled tenant operator and confirm there is noBackfill findings lifecycleheader action while canonical findings workflow actions still render according to current capability rules. - Open
/system/ops/controlsand confirm there is no findings lifecycle backfill control row, action, or history affordance. - Check the supported Artisan command catalog and confirm
tenantpilot:findings:backfill-lifecycleis gone, andtenantpilot:run-deploy-runbooksis also gone if backfill was its only remaining shipped responsibility. - Exercise representative findings actions such as
Triage,Start progress,Assign,Resolve, andRisk acceptand confirm the existing workflow behavior is unchanged. - Open Monitoring or Operations and confirm no supported surface can create a new
findings.lifecycle.backfillrun; historical rows, if any remain in local data, must not receive new special retry or cancel affordances.
Notes
- Filament v5 remains on Livewire v4.0+ in this repo; the cleanup stays inside existing native Filament pages and actions.
- No panel or provider registration changes are planned;
bootstrap/providers.phpremains the authoritative location if any provider work is ever needed later. - No new global-search resource, searchable surface, or global-search contract change is involved.
- No new asset pipeline work is expected, so there is no added
filament:assetsdeployment step. - LEAN-001 applies directly: the cleanup should delete obsolete runtime surfaces rather than keeping aliases, no-op command shells, or compatibility branches for historical data.