ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity
33a2b1a242
TenantAtlas/.github/agents/copilot-instructions.md
ahmido 33a2b1a242 feat(106): Required Permissions sidebar stays on workspace nav (#129) 
## Summary

Fixes the sidebar context bug where navigating to the **Required Permissions** page (`/admin/tenants/{id}/required-permissions`) would switch the sidebar from workspace navigation to tenant-scoped navigation, confusing users.

## Problem

The `EnsureFilamentTenantSelected` middleware detected a tenant ID in the URL and called `setTenant()`, which switched the entire sidebar to tenant-scoped navigation. The Required Permissions page is logically a **workspace-level** page that happens to reference a tenant — it should keep showing workspace nav.

## Changes

### Middleware (`EnsureFilamentTenantSelected.php`)
- **`isWorkspaceScopedPageWithTenant()`** — new private helper that detects workspace-scoped pages containing a tenant parameter via regex
- **Livewire referer bypass** — checks if a Livewire request originates from a workspace-scoped page and preserves workspace nav
- **`setTenant()` bypass** — skips tenant activation and `rememberLastTenantId()` for workspace-scoped pages

### Tests
- **`RequiredPermissionsSidebarTest.php`** (NEW) — 7 tests covering:
  - Workspace nav visible on required-permissions page
  - Tenant nav absent on required-permissions page
  - Direct URL access preserves workspace nav
  - 404 for non-member tenants
  - 404 for tenants without entitlement
  - Tenant pages still show tenant sidebar (regression guard)
  - Scoped tenant resolves correctly on tenant pages

### Pre-existing test fixes
- **`RequiredPermissionsEmptyStateTest`** — fixed URL assertion (dynamic `TenantResource::getUrl()` instead of hardcoded `/admin/onboarding`)
- **`RequiredPermissionsLinksTest`** — fixed URL assertion + multiline HTML `data-testid` assertion
- **`RequiredPermissionsFiltersTest`** — fixed `entra_permissions` config leak from branch 105

## Test Results

| Suite | Result |
|-------|--------|
| RequiredPermissions (26 tests) | **26 pass** (73 assertions) |
| Full regression (1571 tests) | **1562 pass**, 2 fail (pre-existing OpsUx), 7 skipped |

The 2 failures are pre-existing in `OpsUx/OperationCatalogCoverageTest` and `OpsUx/OperationSummaryKeysSpecTest` — unrelated to this feature.

## Spec Artifacts

- `specs/106-required-permissions-sidebar-context/plan.md`
- `specs/106-required-permissions-sidebar-context/tasks.md`
- `specs/106-required-permissions-sidebar-context/research.md`
- `specs/106-required-permissions-sidebar-context/data-model.md`
- `specs/106-required-permissions-sidebar-context/quickstart.md`

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #129
2026-02-22 02:42:44 +00:00

3.9 KiB
Raw Blame History

TenantAtlas Development Guidelines

Auto-generated from all feature plans. Last updated: 2025-12-22

Active Technologies

  • PHP 8.4.15 + Laravel 12, Filament v4, Livewire v3 (feat/005-bulk-operations)

  • PostgreSQL (app), SQLite in-memory (tests) (feat/005-bulk-operations)

  • PostgreSQL (Sail locally) (feat/032-backup-scheduling-mvp)

  • PHP 8.4.x + Laravel 12, Filament v4, Livewire v3 (feat/042-inventory-dependencies-graph)

  • PostgreSQL (JSONB) (feat/042-inventory-dependencies-graph)

  • PHP 8.4.x (Laravel 12) + Laravel 12, Filament v4, Livewire v3 (feat/047-inventory-foundations-nodes)

  • PostgreSQL (JSONB for InventoryItem.meta_jsonb) (feat/047-inventory-foundations-nodes)

  • PostgreSQL (JSONB in operation_runs.context, operation_runs.summary_counts) (056-remove-legacy-bulkops)

  • PHP 8.4.15 (Laravel 12.47.0) + Filament v5.0.0, Livewire v4.0.1 (058-tenant-ui-polish)

  • PHP 8.4 (per repo guidelines) + Laravel 12, Filament v5, Livewire v4 (067-rbac-troubleshooting)

  • PostgreSQL (via Laravel Sail) (067-rbac-troubleshooting)

  • PHP 8.4.x (Composer constraint: ^8.2) + Laravel 12, Filament 5, Livewire 4+, Pest 4, Sail 1.x (073-unified-managed-tenant-onboarding-wizard)

  • PostgreSQL (Sail) + SQLite in tests where applicable (073-unified-managed-tenant-onboarding-wizard)

  • PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, Filament Infolists (schema-based) (078-operations-tenantless-canonical)

  • PostgreSQL (no new migrations — read-only model changes) (078-operations-tenantless-canonical)

  • PHP 8.4.15 (Laravel 12) + Filament v5, Livewire v4, Tailwind v4 (080-workspace-managed-tenant-admin)

  • PostgreSQL (via Sail) (080-workspace-managed-tenant-admin)

  • PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Socialite v5 (081-provider-connection-cutover)

  • PHP 8.4.x + Laravel 12, Filament v5, Livewire v4 (082-action-surface-contract)

  • PHP 8.4 (Laravel 12) + Filament v5 (Livewire v4), Queue/Jobs (Laravel), Microsoft Graph via GraphClientInterface (084-verification-surfaces-unification)

  • PostgreSQL (JSONB-backed OperationRun.context) (084-verification-surfaces-unification)

  • PHP 8.4.15 (Laravel 12) + Filament v5, Livewire v4, Pest v4, Tailwind CSS v4, Laravel Sail (085-tenant-operate-hub)

  • PostgreSQL (primary) + session (workspace context + last-tenant memory) (085-tenant-operate-hub)

  • PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, Laravel Sail, Tailwind CSS v4 (085-tenant-operate-hub)

  • PostgreSQL (Sail), SQLite in tests (087-legacy-runs-removal)

  • PHP 8.4.x + Laravel 12, Filament v5, Livewire v4, Microsoft Graph integration via GraphClientInterface (095-graph-contracts-registry-completeness)

  • PHP 8.4.15 (Laravel 12) + Filament v5, Livewire v4, Laravel Queue, Laravel Notifications (100-alert-target-test-actions)

  • PostgreSQL (Sail locally); SQLite is used in some tests (101-golden-master-baseline-governance-v1)

  • PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, OperateHubShell support class (103-ia-scope-filter-semantics)

  • PostgreSQL — no schema changes (103-ia-scope-filter-semantics)

  • PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, Pest v4 (104-provider-permission-posture)

  • PostgreSQL (via Sail), JSONB for stored report payloads and finding evidence (104-provider-permission-posture)

  • PHP 8.4.15 (feat/005-bulk-operations)

Project Structure

src/
tests/

Commands

Add commands for PHP 8.4.15

Code Style

PHP 8.4.15: Follow standard conventions

Recent Changes

  • 106-required-permissions-sidebar-context: Middleware sidebar-context fix for workspace-scoped pages
  • 105-entra-admin-roles-evidence-findings: Added PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, Pest v4
  • 104-provider-permission-posture: Added PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, Pest v4
  • 103-ia-scope-filter-semantics: Added PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, OperateHubShell support class