Kurzbeschreibung Implementiert Tenant RBAC v1 (specs/062-tenant-rbac-v1): tenant_memberships, Capability registry/resolver, gates, Filament RelationManager für Tenant→Members, Last‑Owner‑Guard, bootstrap assign/recover (break‑glass), Audit-Logging. Wichtige Änderungen Migration: create_tenant_memberships_table (T004) — ausgeführt Models/Services: TenantMembership, Capabilities, RoleCapabilityMap, CapabilityResolver (T008–T013) Auth: Gates registriert in AuthServiceProvider.php (T011) Filament: RelationManager unter Settings → Tenants (Members CRUD + Last‑Owner‑Guard) (T017–T018) Break‑glass: lokale platform superadmin + persistent banner + bootstrap_recover action (T024–T026) Audit: Audit‑Einträge für membership actions mit canonical action_ids (T022) Tests: neue/aktualisierte Feature- und Unit‑Tests (siehe Test‑Abschnitt) Migrations / Deploy Run migrations: vendor/bin/sail artisan migrate Keine neuen Panel‑Assets registriert (kein php artisan filament:assets nötig) Wenn Frontend nicht sichtbar: vendor/bin/sail npm run dev oder vendor/bin/sail npm run build Tests (geprüft / neu) Fokus-Suite ausgeführt für Tenant RBAC (T031). Neu / aktualisiert: CapabilitiesRegistryTest CapabilityResolverTest TenantSwitcherScopeTest TenantRouteDenyAsNotFoundTest TenantMembershipCrudTest LastOwnerGuardTest TenantBootstrapAssignTest MembershipAuditLogTest BreakGlassRecoveryTest Befehl zum lokalen Ausführen (minimal): vendor/bin/sail artisan test tests/Feature/TenantRBAC --stop-on-failure Filament / Sicherheits‑Contract (erforderliche Punkte) Livewire v4.0+ compliance: bestätigt (Filament v5 target). Provider registration: keine neue Panel‑Provider-Änderung; falls nötig: providers.php (Laravel 11+). Globale Suche: keine neuen Ressourcen für Global Search hinzugefügt; vorhandene Ressourcen behalten Edit/View‑Pages unverändert. Destructive actions: tenant_membership.remove und role‑demote sind destruktive — implemented via Action::make(...)->action(...)->requiresConfirmation() + policy checks. Asset strategy: keine globalen Assets; on‑demand/load as before. Deployment: filament:assets nicht erforderlich für diese PR. Testing plan: Livewire/Filament Komponenten + actions abgedeckt — RelationManager CRUD, Last‑Owner‑Guard, BreakGlassRecovery, CapabilityResolver/Registry, Tenant switcher + deny‑as‑not‑found route tests. Offene/optionale Punkte T005/T028/T029 (tenant_role_mappings migration + UI + Tests) sind optional und noch nicht umgesetzt. Checklist (aus tasks.md) T001–T003 Discovery T004, T006–T007 Migrations (T005 optional) T008–T013 Models/Capabilities/Gates T014–T016 Tenant isolation & route enforcement T017–T021 Membership UI + bootstrap flows T022–T023 Audit logging + tests T024–T027 Break‑glass flows & tests T005, T028, T029 Optional mappings T030–T031 Formatting + focused tests Migration / Test commands to run locally vendor/bin/sail up -d vendor/bin/sail artisan migrate vendor/bin/sail artisan tinker (falls manuell Benutzer/Flags setzen) vendor/bin/sail artisan test tests/Feature/TenantRBAC --stop-on-failure Wenn du einen PR‑Titel und Labels willst, schlage ich vor: Title: feat(062): Tenant RBAC v1 — memberships, capability resolver, break‑glass recovery Labels: feature, tests, migration Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #74
104 lines
4.0 KiB
Markdown
104 lines
4.0 KiB
Markdown
# Implementation Plan: Tenant RBAC v1
|
|
|
|
**Branch**: `062-tenant-rbac-v1` | **Date**: 2026-01-25 | **Spec**: [specs/062-tenant-rbac-v1/spec.md](specs/062-tenant-rbac-v1/spec.md)
|
|
**Input**: Feature specification from `specs/062-tenant-rbac-v1/spec.md`
|
|
|
|
## Summary
|
|
|
|
This feature introduces a comprehensive Role-Based Access Control (RBAC) system for TenantAtlas. It leverages Microsoft Entra ID for authentication and manages authorization on a per-Suite-Tenant basis. The core of this feature is the `tenant_memberships` table, which will be the source of truth for authorization. The implementation will follow a capabilities-first approach, where permissions are checked using Gates and Policies rather than direct role comparisons.
|
|
|
|
### Clarifications
|
|
- No Entra user credentials are stored; only the dedicated break-glass platform superadmin may have local credentials.
|
|
- All access control decisions must be auditable.
|
|
- Non-member access to tenant-scoped routes (including direct `/t/{tenant}` URLs) MUST be deny-as-not-found (404).
|
|
- A canonical capability registry (e.g., `app/Support/Auth/Capabilities.php` or an enum) will be the source of truth. Role → capability mapping MUST reference only registry entries; tests must fail if unknown capabilities are used.
|
|
- Audit action_ids will be standardized:
|
|
- `tenant_membership.add`
|
|
- `tenant_membership.role_change`
|
|
- `tenant_membership.remove`
|
|
- `tenant_membership.bootstrap_assign`
|
|
- `tenant_membership.bootstrap_recover`
|
|
- `tenant_role_mapping.create`
|
|
- `tenant_role_mapping.update`
|
|
- `tenant_role_mapping.delete`
|
|
- The system MUST prevent removing or demoting the last remaining `owner` membership for a Suite Tenant.
|
|
|
|
## Technical Context
|
|
|
|
**Language/Version**: PHP 8.4
|
|
**Primary Dependencies**: Laravel 12, Filament v5, Livewire v4
|
|
**Storage**: PostgreSQL
|
|
**Testing**: Pest
|
|
**Target Platform**: Web
|
|
**Project Type**: Web Application
|
|
**Performance Goals**:
|
|
- User login and tenant selection should be completed in under 3 seconds.
|
|
- Membership changes should be reflected in under 2 seconds.
|
|
- Audit log entries should be created in under 1 second.
|
|
**Constraints**:
|
|
- No Entra user credentials are stored; only the dedicated break-glass platform superadmin may have local credentials.
|
|
- All access control decisions must be auditable.
|
|
**Scale/Scope**:
|
|
- The system should be designed to handle up to 1,000 tenants and 10,000 users.
|
|
|
|
## Constitution Check
|
|
|
|
*GATE: Must pass before Phase 0 research. Re-check after Phase 1 design.*
|
|
|
|
- **Inventory-first**: Not directly applicable.
|
|
- **Read/write separation**: **PASS**.
|
|
- **Graph contract path**: **PASS**.
|
|
- **Deterministic capabilities**: **PASS**.
|
|
- **Tenant isolation**: **PASS**.
|
|
- **Run observability**: **PASS**.
|
|
- **Automation**: **PASS**.
|
|
- **Data minimization**: **PASS**.
|
|
- **Badge semantics (BADGE-001)**: Not applicable.
|
|
|
|
## Project Structure
|
|
|
|
### Documentation (this feature)
|
|
|
|
```text
|
|
specs/062-tenant-rbac-v1/
|
|
├── plan.md # This file
|
|
├── research.md # Phase 0 output
|
|
├── data-model.md # Phase 1 output
|
|
├── quickstart.md # Phase 1 output
|
|
├── contracts/ # Phase 1 output
|
|
└── tasks.md # Phase 2 output
|
|
```
|
|
|
|
### Source Code (repository root)
|
|
|
|
```text
|
|
app/
|
|
├── Models/
|
|
│ ├── User.php
|
|
│ ├── Tenant.php
|
|
│ ├── TenantMembership.php
|
|
│ └── TenantRoleMapping.php
|
|
├── Policies/
|
|
│ └── TenantMembershipPolicy.php
|
|
├── Providers/
|
|
│ └── AuthServiceProvider.php
|
|
└── Support/
|
|
└── Auth/
|
|
└── Capabilities.php
|
|
database/
|
|
└── migrations/
|
|
├── XXXX_XX_XX_XXXXXX_create_tenant_memberships_table.php
|
|
└── XXXX_XX_XX_XXXXXX_create_tenant_role_mappings_table.php
|
|
routes/
|
|
└── web.php
|
|
tests/
|
|
└── Feature/
|
|
└── TenantRBAC.php
|
|
```
|
|
|
|
**Structure Decision**: The project is a standard Laravel application. New files will be created in the appropriate directories.
|
|
|
|
## Complexity Tracking
|
|
|
|
No violations to the constitution.
|