ahmido
421261a517
Some checks failed
Main Confidence / confidence (push) Failing after 48s
## Summary - implement the finding outcome taxonomy end-to-end with canonical resolve, close, reopen, and verification semantics - align finding UI, filters, audit metadata, review summaries, and export/read-model consumers to the shared outcome semantics - add focused Pest coverage and complete the spec artifacts for feature 231 ## Details - manual resolve is limited to the canonical `remediated` outcome - close and reopen flows now use bounded canonical reasons - trusted system clear and reopen distinguish verified-clear from verification-failed and recurrence paths - duplicate lifecycle backfill now closes findings canonically as `duplicate` - accepted-risk recording now uses the canonical `accepted_risk` reason - finding detail and list surfaces now expose terminal outcome and verification summaries - review, snapshot, and review-pack consumers now propagate the same outcome buckets ## Filament / Platform Contract - Livewire v4.0+ compatibility remains intact - provider registration is unchanged and remains in `bootstrap/providers.php` - no new globally searchable resource was introduced; `FindingResource` still has a View page and `TenantReviewResource` remains globally searchable false - lifecycle mutations still run through confirmed Filament actions with capability enforcement - no new asset family was added; the existing `filament:assets` deploy step is unchanged ## Verification - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings/FindingWorkflowServiceTest.php tests/Feature/Findings/FindingRecurrenceTest.php tests/Feature/Findings/FindingsListFiltersTest.php tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Findings/FindingOutcomeSummaryReportingTest.php tests/Feature/Findings/FindingRiskGovernanceProjectionTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Models/FindingResolvedTest.php tests/Unit/Findings/FindingWorkflowServiceTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewExplanationSurfaceTest.php tests/Feature/TenantReview/TenantReviewRegisterTest.php tests/Feature/ReviewPack/TenantReviewDerivedReviewPackTest.php` - browser smoke: `/admin/findings/my-work` -> finding detail resolve flow -> queue regression check passed ## Notes - this commit also includes the existing `.github/agents/copilot-instructions.md` workspace change that was already present in the worktree when all changes were committed Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #267 |
||
|---|---|---|
| .. | ||
| AlertDeliveryResource/Pages | ||
| AlertDestinationResource/Pages | ||
| AlertRuleResource/Pages | ||
| BackupScheduleResource | ||
| BackupSetResource | ||
| BaselineProfileResource | ||
| BaselineSnapshotResource/Pages | ||
| EntraGroupResource/Pages | ||
| EvidenceSnapshotResource/Pages | ||
| FindingExceptionResource/Pages | ||
| FindingResource/Pages | ||
| InventoryItemResource/Pages | ||
| PolicyResource | ||
| PolicyVersionResource/Pages | ||
| ProviderConnectionResource/Pages | ||
| RestoreRunResource/Pages | ||
| ReviewPackResource/Pages | ||
| TenantResource | ||
| TenantReviewResource/Pages | ||
| Workspaces | ||
| AlertDeliveryResource.php | ||
| AlertDestinationResource.php | ||
| AlertRuleResource.php | ||
| BackupScheduleResource.php | ||
| BackupSetResource.php | ||
| BaselineProfileResource.php | ||
| BaselineSnapshotResource.php | ||
| EntraGroupResource.php | ||
| EvidenceSnapshotResource.php | ||
| FindingExceptionResource.php | ||
| FindingResource.php | ||
| InventoryItemResource.php | ||
| OperationRunResource.php | ||
| PolicyResource.php | ||
| PolicyVersionResource.php | ||
| ProviderConnectionResource.php | ||
| RestoreRunResource.php | ||
| ReviewPackResource.php | ||
| TenantResource.php | ||
| TenantReviewResource.php | ||