ahmido
421261a517
Some checks failed
Main Confidence / confidence (push) Failing after 48s
## Summary - implement the finding outcome taxonomy end-to-end with canonical resolve, close, reopen, and verification semantics - align finding UI, filters, audit metadata, review summaries, and export/read-model consumers to the shared outcome semantics - add focused Pest coverage and complete the spec artifacts for feature 231 ## Details - manual resolve is limited to the canonical `remediated` outcome - close and reopen flows now use bounded canonical reasons - trusted system clear and reopen distinguish verified-clear from verification-failed and recurrence paths - duplicate lifecycle backfill now closes findings canonically as `duplicate` - accepted-risk recording now uses the canonical `accepted_risk` reason - finding detail and list surfaces now expose terminal outcome and verification summaries - review, snapshot, and review-pack consumers now propagate the same outcome buckets ## Filament / Platform Contract - Livewire v4.0+ compatibility remains intact - provider registration is unchanged and remains in `bootstrap/providers.php` - no new globally searchable resource was introduced; `FindingResource` still has a View page and `TenantReviewResource` remains globally searchable false - lifecycle mutations still run through confirmed Filament actions with capability enforcement - no new asset family was added; the existing `filament:assets` deploy step is unchanged ## Verification - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings/FindingWorkflowServiceTest.php tests/Feature/Findings/FindingRecurrenceTest.php tests/Feature/Findings/FindingsListFiltersTest.php tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Findings/FindingOutcomeSummaryReportingTest.php tests/Feature/Findings/FindingRiskGovernanceProjectionTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Models/FindingResolvedTest.php tests/Unit/Findings/FindingWorkflowServiceTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewExplanationSurfaceTest.php tests/Feature/TenantReview/TenantReviewRegisterTest.php tests/Feature/ReviewPack/TenantReviewDerivedReviewPackTest.php` - browser smoke: `/admin/findings/my-work` -> finding detail resolve flow -> queue regression check passed ## Notes - this commit also includes the existing `.github/agents/copilot-instructions.md` workspace change that was already present in the worktree when all changes were committed Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #267
78 lines
3.2 KiB
PHP
78 lines
3.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Services\TenantReviews;
|
|
|
|
use App\Models\EvidenceSnapshot;
|
|
use App\Models\TenantReview;
|
|
use App\Support\TenantReviewStatus;
|
|
|
|
final class TenantReviewComposer
|
|
{
|
|
public function __construct(
|
|
private readonly TenantReviewFingerprint $fingerprint,
|
|
private readonly TenantReviewSectionFactory $sectionFactory,
|
|
private readonly TenantReviewReadinessGate $readinessGate,
|
|
) {}
|
|
|
|
/**
|
|
* @return array{
|
|
* fingerprint: string,
|
|
* completeness_state: string,
|
|
* status: string,
|
|
* summary: array<string, mixed>,
|
|
* sections: list<array<string, mixed>>
|
|
* }
|
|
*/
|
|
public function compose(EvidenceSnapshot $snapshot, ?TenantReview $review = null): array
|
|
{
|
|
$tenant = $snapshot->tenant;
|
|
|
|
if ($tenant === null) {
|
|
throw new \RuntimeException('Evidence snapshot tenant is required for review composition.');
|
|
}
|
|
|
|
$sections = $this->sectionFactory->make($snapshot);
|
|
$blockers = $this->readinessGate->blockersForSections($sections);
|
|
$sectionStateCounts = $this->readinessGate->sectionStateCounts($sections);
|
|
$completeness = $this->readinessGate->completenessForSections($sections);
|
|
$status = $this->readinessGate->statusForSections($sections);
|
|
|
|
if ($review instanceof TenantReview && $review->isPublished()) {
|
|
$status = TenantReviewStatus::Published;
|
|
}
|
|
|
|
return [
|
|
'fingerprint' => $this->fingerprint->forSnapshot($tenant, $snapshot),
|
|
'completeness_state' => $completeness->value,
|
|
'status' => $status->value,
|
|
'summary' => [
|
|
'evidence_basis' => [
|
|
'snapshot_id' => (int) $snapshot->getKey(),
|
|
'snapshot_fingerprint' => (string) $snapshot->fingerprint,
|
|
'snapshot_completeness_state' => (string) $snapshot->completeness_state,
|
|
'snapshot_generated_at' => $snapshot->generated_at?->toIso8601String(),
|
|
],
|
|
'section_count' => count($sections),
|
|
'section_state_counts' => $sectionStateCounts,
|
|
'publish_blockers' => $blockers,
|
|
'has_ready_export' => false,
|
|
'finding_count' => (int) data_get($sections, '0.summary_payload.finding_count', 0),
|
|
'finding_outcomes' => is_array(data_get($sections, '0.summary_payload.finding_outcomes'))
|
|
? data_get($sections, '0.summary_payload.finding_outcomes')
|
|
: [],
|
|
'finding_report_buckets' => is_array(data_get($sections, '0.summary_payload.finding_report_buckets'))
|
|
? data_get($sections, '0.summary_payload.finding_report_buckets')
|
|
: [],
|
|
'report_count' => 2,
|
|
'operation_count' => (int) data_get($sections, '5.summary_payload.operation_count', 0),
|
|
'highlights' => data_get($sections, '0.render_payload.highlights', []),
|
|
'recommended_next_actions' => data_get($sections, '0.render_payload.next_actions', []),
|
|
'last_composed_at' => now()->toIso8601String(),
|
|
],
|
|
'sections' => $sections,
|
|
];
|
|
}
|
|
}
|