Some checks failed
Main Confidence / confidence (push) Failing after 48s
## Summary - implement the finding outcome taxonomy end-to-end with canonical resolve, close, reopen, and verification semantics - align finding UI, filters, audit metadata, review summaries, and export/read-model consumers to the shared outcome semantics - add focused Pest coverage and complete the spec artifacts for feature 231 ## Details - manual resolve is limited to the canonical `remediated` outcome - close and reopen flows now use bounded canonical reasons - trusted system clear and reopen distinguish verified-clear from verification-failed and recurrence paths - duplicate lifecycle backfill now closes findings canonically as `duplicate` - accepted-risk recording now uses the canonical `accepted_risk` reason - finding detail and list surfaces now expose terminal outcome and verification summaries - review, snapshot, and review-pack consumers now propagate the same outcome buckets ## Filament / Platform Contract - Livewire v4.0+ compatibility remains intact - provider registration is unchanged and remains in `bootstrap/providers.php` - no new globally searchable resource was introduced; `FindingResource` still has a View page and `TenantReviewResource` remains globally searchable false - lifecycle mutations still run through confirmed Filament actions with capability enforcement - no new asset family was added; the existing `filament:assets` deploy step is unchanged ## Verification - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings/FindingWorkflowServiceTest.php tests/Feature/Findings/FindingRecurrenceTest.php tests/Feature/Findings/FindingsListFiltersTest.php tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Findings/FindingOutcomeSummaryReportingTest.php tests/Feature/Findings/FindingRiskGovernanceProjectionTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Models/FindingResolvedTest.php tests/Unit/Findings/FindingWorkflowServiceTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewExplanationSurfaceTest.php tests/Feature/TenantReview/TenantReviewRegisterTest.php tests/Feature/ReviewPack/TenantReviewDerivedReviewPackTest.php` - browser smoke: `/admin/findings/my-work` -> finding detail resolve flow -> queue regression check passed ## Notes - this commit also includes the existing `.github/agents/copilot-instructions.md` workspace change that was already present in the worktree when all changes were committed Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #267
137 lines
5.1 KiB
PHP
137 lines
5.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Jobs\BackfillFindingLifecycleJob;
|
|
use App\Models\Finding;
|
|
use Carbon\CarbonImmutable;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('backfills legacy findings (ack → triaged, lifecycle fields, due_at from backfill time)', function (): void {
|
|
CarbonImmutable::setTestNow(CarbonImmutable::parse('2026-02-24T10:00:00Z'));
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
$finding = Finding::factory()->for($tenant)->create([
|
|
'severity' => Finding::SEVERITY_MEDIUM,
|
|
'status' => Finding::STATUS_ACKNOWLEDGED,
|
|
'acknowledged_at' => CarbonImmutable::parse('2026-02-20T00:00:00Z'),
|
|
'acknowledged_by_user_id' => (int) $user->getKey(),
|
|
'first_seen_at' => null,
|
|
'last_seen_at' => null,
|
|
'times_seen' => null,
|
|
'sla_days' => null,
|
|
'due_at' => null,
|
|
'triaged_at' => null,
|
|
'created_at' => CarbonImmutable::parse('2026-02-10T00:00:00Z'),
|
|
'updated_at' => CarbonImmutable::parse('2026-02-10T00:00:00Z'),
|
|
]);
|
|
|
|
BackfillFindingLifecycleJob::dispatchSync(
|
|
tenantId: (int) $tenant->getKey(),
|
|
workspaceId: (int) $tenant->workspace_id,
|
|
initiatorUserId: (int) $user->getKey(),
|
|
);
|
|
|
|
$finding->refresh();
|
|
|
|
expect($finding->status)->toBe(Finding::STATUS_TRIAGED)
|
|
->and($finding->triaged_at?->toIso8601String())->toBe('2026-02-20T00:00:00+00:00')
|
|
->and($finding->first_seen_at?->toIso8601String())->toBe('2026-02-10T00:00:00+00:00')
|
|
->and($finding->last_seen_at?->toIso8601String())->toBe('2026-02-10T00:00:00+00:00')
|
|
->and($finding->times_seen)->toBe(1)
|
|
->and($finding->sla_days)->toBe(14)
|
|
->and($finding->due_at?->toIso8601String())->toBe('2026-03-10T10:00:00+00:00')
|
|
->and($finding->acknowledged_at?->toIso8601String())->toBe('2026-02-20T00:00:00+00:00')
|
|
->and((int) $finding->acknowledged_by_user_id)->toBe((int) $user->getKey());
|
|
|
|
CarbonImmutable::setTestNow();
|
|
});
|
|
|
|
it('computes drift recurrence keys and consolidates drift duplicates', function (): void {
|
|
CarbonImmutable::setTestNow(CarbonImmutable::parse('2026-02-24T10:00:00Z'));
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
$scopeKey = hash('sha256', 'scope-drift-backfill-duplicate');
|
|
|
|
$evidence = [
|
|
'change_type' => 'modified',
|
|
'summary' => [
|
|
'kind' => 'policy_snapshot',
|
|
'changed_fields' => ['snapshot_hash'],
|
|
],
|
|
'baseline' => ['policy_id' => 'policy-dupe'],
|
|
'current' => ['policy_id' => 'policy-dupe'],
|
|
];
|
|
|
|
$open = Finding::factory()->for($tenant)->create([
|
|
'finding_type' => Finding::FINDING_TYPE_DRIFT,
|
|
'scope_key' => $scopeKey,
|
|
'subject_type' => 'policy',
|
|
'subject_external_id' => 'policy-dupe',
|
|
'status' => Finding::STATUS_NEW,
|
|
'recurrence_key' => null,
|
|
'evidence_jsonb' => $evidence,
|
|
'first_seen_at' => null,
|
|
'last_seen_at' => null,
|
|
'times_seen' => null,
|
|
'sla_days' => null,
|
|
'due_at' => null,
|
|
'created_at' => CarbonImmutable::parse('2026-02-20T00:00:00Z'),
|
|
'updated_at' => CarbonImmutable::parse('2026-02-20T00:00:00Z'),
|
|
]);
|
|
|
|
$duplicate = Finding::factory()->for($tenant)->create([
|
|
'finding_type' => Finding::FINDING_TYPE_DRIFT,
|
|
'scope_key' => $scopeKey,
|
|
'subject_type' => 'policy',
|
|
'subject_external_id' => 'policy-dupe',
|
|
'status' => Finding::STATUS_RESOLVED,
|
|
'resolved_at' => CarbonImmutable::parse('2026-02-21T00:00:00Z'),
|
|
'resolved_reason' => Finding::RESOLVE_REASON_REMEDIATED,
|
|
'recurrence_key' => null,
|
|
'evidence_jsonb' => $evidence,
|
|
'first_seen_at' => null,
|
|
'last_seen_at' => null,
|
|
'times_seen' => null,
|
|
'created_at' => CarbonImmutable::parse('2026-02-18T00:00:00Z'),
|
|
'updated_at' => CarbonImmutable::parse('2026-02-18T00:00:00Z'),
|
|
]);
|
|
|
|
BackfillFindingLifecycleJob::dispatchSync(
|
|
tenantId: (int) $tenant->getKey(),
|
|
workspaceId: (int) $tenant->workspace_id,
|
|
initiatorUserId: (int) $user->getKey(),
|
|
);
|
|
|
|
$tenantId = (int) $tenant->getKey();
|
|
$expectedRecurrenceKey = hash(
|
|
'sha256',
|
|
sprintf('drift:%d:%s:policy:%s:policy_snapshot:modified', $tenantId, $scopeKey, 'policy-dupe'),
|
|
);
|
|
|
|
expect(Finding::query()
|
|
->where('tenant_id', $tenantId)
|
|
->where('finding_type', Finding::FINDING_TYPE_DRIFT)
|
|
->where('recurrence_key', $expectedRecurrenceKey)
|
|
->count())->toBe(1);
|
|
|
|
$open->refresh();
|
|
$duplicate->refresh();
|
|
|
|
expect($open->recurrence_key)->toBe($expectedRecurrenceKey)
|
|
->and($open->status)->toBe(Finding::STATUS_NEW);
|
|
|
|
expect($duplicate->recurrence_key)->toBeNull()
|
|
->and($duplicate->status)->toBe(Finding::STATUS_CLOSED)
|
|
->and($duplicate->resolved_reason)->toBeNull()
|
|
->and($duplicate->resolved_at)->toBeNull()
|
|
->and($duplicate->closed_reason)->toBe(Finding::CLOSE_REASON_DUPLICATE)
|
|
->and($duplicate->closed_at?->toIso8601String())->toBe('2026-02-24T10:00:00+00:00');
|
|
|
|
CarbonImmutable::setTestNow();
|
|
});
|