Some checks failed
Main Confidence / confidence (push) Failing after 48s
## Summary - implement the finding outcome taxonomy end-to-end with canonical resolve, close, reopen, and verification semantics - align finding UI, filters, audit metadata, review summaries, and export/read-model consumers to the shared outcome semantics - add focused Pest coverage and complete the spec artifacts for feature 231 ## Details - manual resolve is limited to the canonical `remediated` outcome - close and reopen flows now use bounded canonical reasons - trusted system clear and reopen distinguish verified-clear from verification-failed and recurrence paths - duplicate lifecycle backfill now closes findings canonically as `duplicate` - accepted-risk recording now uses the canonical `accepted_risk` reason - finding detail and list surfaces now expose terminal outcome and verification summaries - review, snapshot, and review-pack consumers now propagate the same outcome buckets ## Filament / Platform Contract - Livewire v4.0+ compatibility remains intact - provider registration is unchanged and remains in `bootstrap/providers.php` - no new globally searchable resource was introduced; `FindingResource` still has a View page and `TenantReviewResource` remains globally searchable false - lifecycle mutations still run through confirmed Filament actions with capability enforcement - no new asset family was added; the existing `filament:assets` deploy step is unchanged ## Verification - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings/FindingWorkflowServiceTest.php tests/Feature/Findings/FindingRecurrenceTest.php tests/Feature/Findings/FindingsListFiltersTest.php tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Findings/FindingOutcomeSummaryReportingTest.php tests/Feature/Findings/FindingRiskGovernanceProjectionTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Models/FindingResolvedTest.php tests/Unit/Findings/FindingWorkflowServiceTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewExplanationSurfaceTest.php tests/Feature/TenantReview/TenantReviewRegisterTest.php tests/Feature/ReviewPack/TenantReviewDerivedReviewPackTest.php` - browser smoke: `/admin/findings/my-work` -> finding detail resolve flow -> queue regression check passed ## Notes - this commit also includes the existing `.github/agents/copilot-instructions.md` workspace change that was already present in the worktree when all changes were committed Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #267
133 lines
4.4 KiB
PHP
133 lines
4.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\FindingResource\Pages\ListFindings;
|
|
use App\Models\AuditLog;
|
|
use App\Models\Finding;
|
|
use App\Models\User;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
function findingBulkAuditResourceIds(int $tenantId, string $action): array
|
|
{
|
|
return AuditLog::query()
|
|
->where('tenant_id', $tenantId)
|
|
->where('action', $action)
|
|
->pluck('resource_id')
|
|
->map(static fn (string $resourceId): int => (int) $resourceId)
|
|
->sort()
|
|
->values()
|
|
->all();
|
|
}
|
|
|
|
it('supports bulk workflow actions and audits each record', function (): void {
|
|
[$manager, $tenant] = createUserWithTenant(role: 'manager');
|
|
$this->actingAs($manager);
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$findings = Finding::factory()
|
|
->count(6)
|
|
->for($tenant)
|
|
->create([
|
|
'status' => Finding::STATUS_NEW,
|
|
'triaged_at' => null,
|
|
]);
|
|
|
|
$component = Livewire::test(ListFindings::class);
|
|
|
|
$component
|
|
->callTableBulkAction('triage_selected', $findings)
|
|
->assertHasNoTableBulkActionErrors();
|
|
|
|
$findings->each(fn (Finding $finding) => expect($finding->refresh()->status)->toBe(Finding::STATUS_TRIAGED));
|
|
|
|
expect(findingBulkAuditResourceIds((int) $tenant->getKey(), 'finding.triaged'))
|
|
->toEqual($findings->pluck('id')->sort()->values()->all());
|
|
|
|
$assignee = User::factory()->create();
|
|
createUserWithTenant(tenant: $tenant, user: $assignee, role: 'operator');
|
|
|
|
$assignFindings = Finding::factory()
|
|
->count(3)
|
|
->for($tenant)
|
|
->create([
|
|
'status' => Finding::STATUS_TRIAGED,
|
|
'assignee_user_id' => null,
|
|
'owner_user_id' => null,
|
|
]);
|
|
|
|
$component
|
|
->callTableBulkAction('assign_selected', $assignFindings, data: [
|
|
'assignee_user_id' => (int) $assignee->getKey(),
|
|
'owner_user_id' => (int) $manager->getKey(),
|
|
])
|
|
->assertHasNoTableBulkActionErrors();
|
|
|
|
$assignFindings->each(function (Finding $finding) use ($assignee, $manager): void {
|
|
$finding->refresh();
|
|
|
|
expect((int) $finding->assignee_user_id)->toBe((int) $assignee->getKey())
|
|
->and((int) $finding->owner_user_id)->toBe((int) $manager->getKey());
|
|
});
|
|
|
|
expect(findingBulkAuditResourceIds((int) $tenant->getKey(), 'finding.assigned'))
|
|
->toEqual($assignFindings->pluck('id')->sort()->values()->all());
|
|
|
|
$resolveFindings = Finding::factory()
|
|
->count(2)
|
|
->for($tenant)
|
|
->create([
|
|
'status' => Finding::STATUS_IN_PROGRESS,
|
|
'resolved_at' => null,
|
|
'resolved_reason' => null,
|
|
]);
|
|
|
|
$component
|
|
->callTableBulkAction('resolve_selected', $resolveFindings, data: [
|
|
'resolved_reason' => Finding::RESOLVE_REASON_REMEDIATED,
|
|
])
|
|
->assertHasNoTableBulkActionErrors();
|
|
|
|
$resolveFindings->each(function (Finding $finding): void {
|
|
$finding->refresh();
|
|
|
|
expect($finding->status)->toBe(Finding::STATUS_RESOLVED)
|
|
->and($finding->resolved_reason)->toBe(Finding::RESOLVE_REASON_REMEDIATED)
|
|
->and($finding->resolved_at)->not->toBeNull();
|
|
});
|
|
|
|
expect(findingBulkAuditResourceIds((int) $tenant->getKey(), 'finding.resolved'))
|
|
->toEqual($resolveFindings->pluck('id')->sort()->values()->all());
|
|
|
|
$closeFindings = Finding::factory()
|
|
->count(2)
|
|
->for($tenant)
|
|
->create([
|
|
'status' => Finding::STATUS_TRIAGED,
|
|
'closed_at' => null,
|
|
'closed_reason' => null,
|
|
]);
|
|
|
|
$component
|
|
->callTableBulkAction('close_selected', $closeFindings, data: [
|
|
'closed_reason' => Finding::CLOSE_REASON_NO_LONGER_APPLICABLE,
|
|
])
|
|
->assertHasNoTableBulkActionErrors();
|
|
|
|
$closeFindings->each(function (Finding $finding): void {
|
|
$finding->refresh();
|
|
|
|
expect($finding->status)->toBe(Finding::STATUS_CLOSED)
|
|
->and($finding->closed_reason)->toBe(Finding::CLOSE_REASON_NO_LONGER_APPLICABLE)
|
|
->and($finding->closed_at)->not->toBeNull()
|
|
->and($finding->closed_by_user_id)->not->toBeNull();
|
|
});
|
|
|
|
expect(findingBulkAuditResourceIds((int) $tenant->getKey(), 'finding.closed'))
|
|
->toEqual($closeFindings->pluck('id')->sort()->values()->all());
|
|
});
|