ahmido
2bf5de4663
Summary Consolidates the “Tenant Operate Hub” work (Spec 085) and the follow-up adjustments from the 086 session merge into a single branch ready to merge into dev. Primary focus: stabilize Ops/Operate Hub UX flows, tighten/align authorization semantics, and make the full Sail test suite green. Key Changes Ops UX / Verification Readonly members can view verification operation runs (reports) while starting verification remains restricted. Normalized failure reason-code handling and aligned UX expectations with the provider reason-code taxonomy. Onboarding wizard UX “Start verification” CTA is hidden while a verification run is active; “Refresh” is shown during in-progress runs. Treats provider_permission_denied as a blocking reason (while keeping legacy compatibility). Test + fixture hardening Standardized use of default provider connection fixtures in tests where sync/restore flows require it. Fixed multiple Filament URL/tenant-context test cases to avoid 404s and reduce tenancy routing brittleness. Policy sync / restore safety Enrollment configuration type collision classification tests now exercise the real sync path (with required provider connection present). Restore edge-case safety tests updated to reflect current provider-connection requirements. Testing vendor/bin/sail artisan test --compact (green) vendor/bin/sail bin pint --dirty (green) Notes Includes merged 086 session work already (no separate PR needed). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@ebc83aaa-d947-4a08-b88e-bd72ac9645f7.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.fritz.box> Reviewed-on: #103
43 lines
1.4 KiB
Markdown
43 lines
1.4 KiB
Markdown
# Quickstart (Spec 086)
|
|
|
|
This quickstart is for validating Spec 086 changes locally using Sail.
|
|
|
|
## Prereqs
|
|
|
|
- `vendor/bin/sail up -d`
|
|
|
|
## Run formatting
|
|
|
|
- `vendor/bin/sail bin pint --dirty`
|
|
|
|
## Run targeted tests
|
|
|
|
Use the minimal test subset relevant to the PR slice you are working on:
|
|
|
|
- `vendor/bin/sail artisan test --compact --filter=OperationRun`
|
|
- `vendor/bin/sail artisan test --compact tests/Feature` (narrow further to the new/changed files)
|
|
|
|
## Manual verification checklist
|
|
|
|
### Canonical viewer
|
|
|
|
- Trigger an operation that creates an `OperationRun`.
|
|
- Open the canonical URL (from notification action): `/admin/operations/{runId}`.
|
|
- Confirm the viewer renders from persisted DB state only.
|
|
|
|
### Authorization semantics
|
|
|
|
- As a non-workspace-member user, opening `/admin/operations/{runId}` returns 404.
|
|
- As a workspace member without the required capability for that run type, opening the viewer returns 403.
|
|
|
|
### Dedupe semantics
|
|
|
|
- Inventory sync / directory group sync: attempting to start while active reuses the existing active run and links to it.
|
|
- Manual backup schedule run now/retry: each click produces a distinct `OperationRun`.
|
|
- Scheduled backup: double-fire for the same schedule + intended minute produces at most one `OperationRun`.
|
|
|
|
### DB-only forms
|
|
|
|
- Tenant configuration selectors (directory groups, role definitions) render and search without outbound HTTP calls.
|
|
- “Sync now” actions enqueue operations and provide “View run” link.
|