ahmido
bbc594efbb
## Summary - productize the customer review workspace as a workspace-wide customer-safe review hub - add customer-safe latest review, decision summary, accepted risks, evidence basis, and review-pack presentation updates - update localized copy, focused feature coverage, browser smoke coverage, and Spec 312 artifacts ## Testing - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Reviews/CustomerReviewWorkspacePageTest.php tests/Feature/Reviews/CustomerReviewWorkspacePackAccessTest.php tests/Browser/Reviews/CustomerReviewWorkspaceSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `git diff --check` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #367
60 lines
4.2 KiB
Markdown
60 lines
4.2 KiB
Markdown
# Requirements Checklist: Customer Review Workspace v1 Completion
|
|
|
|
**Purpose**: Preparation-readiness checklist for Spec 312.
|
|
**Created**: 2026-05-15
|
|
**Feature**: `specs/312-customer-review-workspace-v1-completion/spec.md`
|
|
|
|
## Candidate And Scope
|
|
|
|
- [x] CHK001 The selected candidate is directly provided by the user and also appears as the first manual-promotion P1 post-Spec-311 candidate in `docs/product/spec-candidates.md`.
|
|
- [x] CHK002 The scope is narrowed to Customer Review Workspace productization and existing review/detail/pack handoffs.
|
|
- [x] CHK003 Related completed specs 249, 258, 308, and 311 are treated as historical context and dependencies only.
|
|
- [x] CHK004 The spec explicitly forbids shell/sidebar/topbar, RBAC, policy, migration, provider, billing, AI, artifact-lifecycle, OperationRun, and Review Pack generation work.
|
|
- [x] CHK005 Functional requirements are behavior-oriented and testable.
|
|
- [x] CHK006 Acceptance criteria cover latest selection, filter behavior, decision states, accepted risks, evidence basis, pack status, authorization, leakage, links, and legacy fallback.
|
|
|
|
## Truth Sources And Proportionality
|
|
|
|
- [x] CHK007 The spec identifies review, decision, evidence, review-pack, and execution truth owners.
|
|
- [x] CHK008 The proportionality review states no new persisted entity, table, artifact family, abstraction, enum/status family, or cross-domain UI framework is planned.
|
|
- [x] CHK009 Legacy pre-Spec-308 behavior is display-only fallback, not migration/backfill/compatibility persistence.
|
|
- [x] CHK010 The spec requires deriving from released review/governance-package truth and forbids recomputing a second decision source of truth from raw evidence payloads.
|
|
|
|
## UI, Filament, And Disclosure
|
|
|
|
- [x] CHK011 The affected surface is classified as an existing Filament page plus existing Blade view composition.
|
|
- [x] CHK012 Customer-safe disclosure hierarchy is decision-first, diagnostics absent by default, evidence summarized.
|
|
- [x] CHK013 The one-primary-action rule is explicit for latest review, review pack, and filtered empty state contexts.
|
|
- [x] CHK014 Filament v5 / Livewire v4 compliance, provider registration location, global search posture, destructive action posture, and asset strategy are required in implementation close-out.
|
|
- [x] CHK015 The spec forbids ad-hoc styling systems and new assets.
|
|
|
|
## Security, RBAC, And Leakage
|
|
|
|
- [x] CHK016 Existing workspace/environment membership, policies, and capabilities remain authoritative.
|
|
- [x] CHK017 Non-member and missing-capability semantics are preserved rather than redefined.
|
|
- [x] CHK018 Rendered HTML and href leakage assertions are explicitly required.
|
|
- [x] CHK019 The spec distinguishes technical IDs in route parameters from visible raw-ID leakage.
|
|
- [x] CHK020 `/admin/t` legacy URL leakage is explicitly forbidden.
|
|
- [x] CHK021 Operator-only lifecycle and pack mutation actions are explicitly forbidden in the customer-safe workspace.
|
|
|
|
## Testing And Validation
|
|
|
|
- [x] CHK022 Planned Pest coverage uses existing Reviews, EnvironmentReview, and ReviewPack feature families.
|
|
- [x] CHK023 Browser coverage is bounded to the existing CustomerReviewWorkspace smoke because rendered UI changes are expected.
|
|
- [x] CHK024 Fixture/helper cost risks are identified and kept feature-local.
|
|
- [x] CHK025 Validation commands are concrete and scoped.
|
|
- [x] CHK026 Spec 311 regression lane is conditional only if shell/sidebar/topbar-adjacent files are touched.
|
|
|
|
## Review Outcome
|
|
|
|
- [x] CHK027 Review outcome class: `acceptable-special-case`.
|
|
- [x] CHK028 Workflow outcome: `keep`.
|
|
- [x] CHK029 Final note location: active feature PR close-out entry `Guardrail / Exception / Smoke Coverage`.
|
|
- [x] CHK030 Spec Readiness Gate passes for preparation: `spec.md`, `plan.md`, `tasks.md`, and this checklist exist, contain no template placeholders, and keep implementation scope bounded to Spec 312.
|
|
|
|
## Preparation Analyze Notes
|
|
|
|
- Candidate Selection Gate: pass.
|
|
- Spec Readiness Gate: pass.
|
|
- Required implementation stop condition: if implementation appears to require shell/sidebar/topbar, RBAC/policy, migration, OperationRun, persisted status family, asset, or Review Pack generation changes, stop and update the spec/plan before continuing.
|