Summary: - Baseline Compare landing: enterprise UI (stats grid, critical drift banner, better actions), navigation grouping under Governance, and Action Surface Contract declaration. - Baseline Profile view page: switches from disabled form fields to proper Infolist entries for a clean read-only view. - Fixes tenant name column usages (`display_name` → `name`) in baseline assignment flows. - Dashboard: improved baseline governance widget with severity breakdown + last compared. Notes: - Filament v5 / Livewire v4 compatible. - Destructive actions remain confirmed (`->requiresConfirmation()`). Tests: - `vendor/bin/sail artisan test --compact tests/Feature/Baselines` - `vendor/bin/sail artisan test --compact tests/Feature/Guards/ActionSurfaceContractTest.php` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #123
2.2 KiB
2.2 KiB
Specification Quality Checklist: Golden Master / Baseline Governance v1 (R1.1–R1.4)
Purpose: Validate specification completeness and quality before proceeding to planning Created: 2026-02-19 Last Validated: 2026-02-19 (post-analysis remediation) Feature: spec.md
Content Quality
- No implementation details (languages, frameworks, APIs)
- Focused on user value and business needs
- Written for non-technical stakeholders
- All mandatory sections completed
Requirement Completeness
- No [NEEDS CLARIFICATION] markers remain
- Requirements are testable and unambiguous
- Success criteria are measurable
- Success criteria are technology-agnostic (no implementation details)
- All acceptance scenarios are defined
- Edge cases are identified
- Scope is clearly bounded
- Dependencies and assumptions identified
Feature Readiness
- All functional requirements have clear acceptance criteria
- User scenarios cover primary flows
- Feature meets measurable outcomes defined in Success Criteria
- No implementation details leak into specification
Post-Analysis Remediation (2026-02-19)
- D1: Duplicate FR-003 removed (kept complete version with override clause)
- I1: Status lifecycle resolved —
draft ↔ active → archived(deactivate = return to draft); spec.md + data-model.md aligned - I3: "Delete" removed from UI Action Matrix — v1 is archive-only, no hard-delete
- C1: BadgeDomain task (T018a) added for BaselineProfileStatus badge compliance (BADGE-001)
- C2: Factory tasks (T018b) added for all 4 new models
- U1:
findings.sourcedefault resolved — nullable, NULL default, legacy findings unaffected - U2: Empty-scope edge case (EC-005) covered in T031 test description
- U3: Concurrent operation dedup (EC-004) covered in T032 + T040 test descriptions
- U4: T033 amended with explicit manage-capability gating via WorkspaceUiEnforcement
- U5:
scope_jsonbschema defined in data-model.md ({ "policy_types": [...] }) - E1: SC-001/SC-002 performance spot-check added to T060
Notes
- All 12 analysis findings have been remediated
- Task count updated: 60 → 62 (T018a, T018b added in Phase 2)