Some checks failed
PR Fast Feedback / fast-feedback (pull_request) Failing after 3m40s
Productize the evidence overview review-pack process flow: snapshot -> stored report -> review pack -> customer-safe export states with clear gating and copy. Adds feature and browser smoke coverage plus Spec 337 artifacts.
3.7 KiB
3.7 KiB
Requirements Checklist: Spec 337 - Evidence Path / Review Pack Product Process Flow Alignment
Purpose: validate the prepared spec artifacts before runtime implementation begins.
Spec Identity
- Spec number is reconciled to current repo state (
337, because336already exists). - Branch name matches spec directory.
- Input source and numbering reconciliation are documented.
- Runtime posture forbids backend evidence/report/review-pack/export engine rewrites.
Constitution / Spec Candidate Gate
- Spec Candidate Check is completed.
- Problem, today's failure, user-visible improvement, smallest version, non-goals, complexity, why-now, why-not-local, approval class, red flags, score, and decision are filled.
- Proportionality review is included for the possible derived presenter.
- No new persisted truth, enum family, lifecycle family, or generic workflow framework is proposed.
- Shared pattern first is explicit through Spec 332 Product Process Flow reuse.
Repo Truth
repo-truth-map.mdexists.- Evidence snapshot source is classified.
- Stored report source is classified.
- Review pack source is classified.
- Environment review / Customer Review Workspace relationship is classified.
- OperationRun proof relationship is classified.
- Export/download artifact relationship is classified.
- Evidence freshness source is classified.
- Customer-safe state source is classified.
- RBAC/capabilities and routes/surfaces are classified.
- Existing tests are listed.
- Unavailable/deferred states are called out instead of invented.
State Contract
evidence-review-pack-state-contract.mdexists.- Default flow steps are defined.
- Presentation vocabulary is explicitly not a new enum family.
- Missing, generating, failed, stale, report missing, review-pack required, review-pack generating, review-pack failed, customer-safe review required, customer-safe ready, export available, and export unavailable states are covered.
- Each state includes visible status, reason, impact, primary next action, flow gate states, proof, customer-safe state, export state, and diagnostics default.
- False customer-safe, auditor-ready, complete, and export-ready claims are forbidden.
UI / Filament Guardrails
- UI Surface Impact is completed and does not claim "No UI surface impact".
- UI/Productization Coverage is completed.
- Decision-first surface role is completed.
- Audience-aware disclosure is completed.
- UI/UX surface classification is completed.
- Operator surface contract is completed.
- Livewire v4 / Filament v5 posture is explicit.
- Provider registration location remains
apps/platform/bootstrap/providers.php. - Global search state is addressed for relevant resources.
- No new destructive actions are proposed.
- Asset/deployment posture is explicit: no global asset or
filament:assetschange expected.
Testing / Validation
- Feature test file path is specified.
- Browser smoke file path is specified.
- Required screenshots path and filenames are specified.
- Required assertions cover missing evidence, report missing, review-pack required, review-pack available, OperationRun proof, RBAC/context, collapsed diagnostics, and no raw JSON.
- Validation commands are listed.
- Unreachable browser states must be documented rather than faked.
Implementation Readiness
spec.md,plan.md,tasks.md,repo-truth-map.md,evidence-review-pack-state-contract.md,checklists/requirements.md, and screenshot directory are present.- Runtime implementation has not started in this preparation step.
- Recommended next prompt is implementation, not more preparation.