12 KiB
12 KiB
Terminology Audit: Managed Environment Terminology & Copy Cleanup
Feature: 298-managed-environment-terminology-copy-cleanup
Created: 2026-05-13
Status: Implemented close-out. Final scans refreshed on 2026-05-13.
Categories
| Category | Meaning |
|---|---|
fixed |
The implementation replaced or removed the old tenant-first wording. |
allowed-provider-term |
The term describes external Microsoft/Entra provider truth, such as Microsoft tenant ID. |
allowed-internal-model |
The term is an internal model/class/table/column name and DB/model rename is out of scope. |
allowed-historical |
The term appears in historical specs/docs/audit history that this spec does not rewrite. |
allowed-regression-guard |
The term is kept only as a forbidden legacy pattern in a guard test. |
out-of-scope-db-model-rename |
The term requires a structural DB/model rename outside Spec 298. |
needs-follow-up |
The term is real drift but cannot be safely fixed inside Spec 298. |
Implementation Baseline Scan
Read-only implementation scans were refreshed on 2026-05-13 before application edits.
| Command | Result | Decision |
|---|---|---|
git status --short --branch && git diff --stat && git log -1 --oneline |
Active branch is 298-managed-environment-terminology-copy-cleanup; only the active spec package was untracked before audit edit; base commit 3ec582a1 feat: retire legacy tenant route surfaces (#352). |
Safe to continue because the untracked files are the active prepared spec artifacts. |
cd apps/platform && ./vendor/bin/sail artisan route:list | rg "admin/tenants|admin/t/" && exit 1 || true |
No output; no active route-list matches for retired route families. | Route baseline clean. |
cd apps/platform && rg "filament\\.admin\\.resources\\.tenants|/admin/tenants|/admin/t/|TenantResource::getUrl|TenantDashboard::getUrl|TenantRequiredPermissions::getUrl|setTenantPanelContext|panel:\\s*'tenant'|panel:\\s*\\\"tenant\\\"" app resources routes --glob '!vendor' --glob '!node_modules' |
No output; no active runtime source matches in app, resources, or routes. |
Source baseline clean. |
cd apps/platform && rg "setTenantPanelContext|panel:\\s*'tenant'|panel:\\s*\\\"tenant\\\"" tests --glob '!vendor' --glob '!node_modules' |
Five setTenantPanelContext regex literals remain in tests/Feature/Guards/Spec288NoLegacyRouteAndHelperGuardTest.php. |
Allowed only as regression-guard literals after wording clarification. |
cd apps/platform && rg "Tenant dashboard|Tenant detail|Open tenant|Select tenant|Tenant scope|No tenant selected|No active tenants|Remove tenant|Restore tenant|Tenant memberships|tenant blocker" app resources lang tests --glob '!vendor' --glob '!node_modules' |
Targeted active copy/test hits listed below. | In-scope cleanup targets except provider/internal/historical references. |
Baseline Findings To Fix
| Pattern | File | Category | Decision | Reason |
|---|---|---|---|---|
Tenant scope, Select tenant, No tenant selected, No active tenants, Tenant dashboard, tenant blocker |
apps/platform/lang/en/localization.php |
fixed | planned | Active localization values should output environment-first wording. Existing keys may remain if key rename is risky. |
| German tenant-first equivalents for context/dashboard copy | apps/platform/lang/de/localization.php |
fixed | planned | Active DE localization values should output environment-first wording. |
Open tenant detail |
apps/platform/resources/views/filament/pages/monitoring/finding-exceptions-queue.blade.php |
fixed | planned | Active view copy should say Open environment detail unless provider-specific. |
Open tenant compare |
apps/platform/resources/views/filament/pages/baseline-compare-matrix.blade.php |
fixed | planned | Baseline compare is an environment-context action after cutover. |
No tenant selected. |
apps/platform/resources/views/filament/pages/tenant-required-permissions.blade.php |
fixed | planned | Required permissions page should describe missing environment context. |
Restore tenant |
apps/platform/app/Services/Tenants/TenantActionPolicySurface.php |
fixed | planned | Visible operator copy should say restore environment while preserving confirmation/authorization. |
Restore tenant |
apps/platform/app/Support/Ui/GovernanceActions/GovernanceActionCatalog.php |
fixed | planned | Governance action copy should say restore environment while preserving confirmation/authorization. |
Open tenant detail |
apps/platform/app/Filament/Pages/Monitoring/FindingExceptionsQueue.php |
fixed | planned | Active action label should use environment wording. |
Open tenant findings |
apps/platform/app/Filament/Pages/Findings/MyFindingsInbox.php, apps/platform/tests/Feature/Findings/MyWorkInboxTest.php |
fixed | planned | Active action label should use environment wording if it targets environment-scoped findings. |
No tenant selected |
apps/platform/app/Filament/Resources/BackupScheduleResource.php |
fixed | planned | Backup schedule context copy should use environment wording. |
Remove tenant assignment |
apps/platform/app/Filament/Resources/BaselineProfileResource/RelationManagers/BaselineTenantAssignmentsRelationManager.php |
fixed | planned | Visible destructive label should use environment assignment wording while preserving confirmation/authorization. |
No tenant selected. |
apps/platform/app/Support/Baselines/BaselineCompareStats.php |
fixed | planned | Empty compare state should use environment context wording. |
| Old-copy assertions | apps/platform/tests/Feature/Localization/EnvironmentContextTerminologyTest.php, apps/platform/tests/Feature/Guards/EnvironmentCopyNeutralizationGuardTest.php |
fixed | planned | Tests should assert current environment vocabulary and forbid retired product copy. |
setTenantPanelContext regex literals |
apps/platform/tests/Feature/Guards/Spec288NoLegacyRouteAndHelperGuardTest.php |
allowed-regression-guard | clarify | May remain only as explicit forbidden legacy pattern. Test names/messages must not suggest a current helper. |
Final Audit
| Pattern | File | Category | Decision | Reason |
|---|---|---|---|---|
Retired route families /admin/tenants and /admin/t/ |
apps/platform route list |
fixed | clean | Final route scan returned no matches. |
| Retired tenant panel route/helper patterns from T005 | apps/platform/app, apps/platform/resources, apps/platform/routes |
fixed | clean | Final source scan returned no matches for retired route names, helper names, tenant panel provider usage, or tenant-panel route generation. |
setTenantPanelContext |
apps/platform/tests/Feature/Guards/Spec288NoLegacyRouteAndHelperGuardTest.php |
allowed-regression-guard | keep | Remaining hits are forbidden-pattern regex literals and a clarified failure message preventing reintroduction of the retired helper. |
Tenant scope, Select tenant, No tenant selected, No active tenants, Tenant dashboard, tenant blocker |
apps/platform/lang/en/localization.php, apps/platform/lang/de/localization.php, context/support tests |
fixed | complete | Active localization values now use environment/managed-environment wording. Existing key names remain where key renames would broaden scope. |
| Finding queue and governance inbox tenant-first labels | apps/platform/app/Filament/Pages/**, apps/platform/resources/views/filament/pages/**, related tests |
fixed | complete | Active visible labels now say environment detail, environment findings, environment filter, or environment scope as appropriate. |
| Baseline compare tenant-first labels and empty states | apps/platform/app/Filament/Pages/BaselineCompareMatrix.php, apps/platform/app/Filament/Resources/BaselineProfileResource/Pages/ViewBaselineProfile.php, apps/platform/app/Support/Baselines/**, apps/platform/resources/views/filament/pages/baseline-compare-matrix.blade.php, related tests |
fixed | complete | Visible compare labels now say assigned environments, visible assigned environments, and multi-environment scan. Internal action IDs and model names remain unchanged. |
| Destructive governance/environment action copy | apps/platform/app/Services/Tenants/TenantActionPolicySurface.php, apps/platform/app/Support/Ui/GovernanceActions/GovernanceActionCatalog.php, apps/platform/app/Filament/Resources/BaselineProfileResource/RelationManagers/BaselineTenantAssignmentsRelationManager.php |
fixed | complete | Visible copy now says restore/archive/remove environment assignment while existing ->action(...), ->requiresConfirmation(), and authorization surfaces remain intact. |
| Old product-copy strings in copy scan | apps/platform/tests/Feature/Localization/EnvironmentContextTerminologyTest.php, apps/platform/tests/Feature/Guards/EnvironmentCopyNeutralizationGuardTest.php |
allowed-regression-guard | keep | Final copy scan hits are forbidden strings used only by regression guards/assertions to ensure active UI does not reintroduce them. |
| Microsoft tenant / Entra tenant identifiers | Provider/auth/Graph-facing code and tests | allowed-provider-term | keep | These terms describe external Microsoft provider concepts and are not product context labels. |
Tenant, tenant_id, tenantRouteKey, TenantResource, tenant review model/resource names |
Models, resources, relations, fixtures, historical test names | allowed-internal-model | keep | DB/model/resource rename is explicitly out of scope for Spec 298. Runtime routes were not restored. |
| Historical specs, archived decision context, and prior spec names | specs/**, .specify/**, historical tests where applicable |
allowed-historical | keep | This cleanup does not rewrite historical records or prior spec names. |
Final Verification Evidence
| Command | Result |
|---|---|
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Guards |
Passed: 265 tests, 4705 assertions. |
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Localization |
Passed: 16 tests, 95 assertions after updating stale German auth copy expectation. |
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Workspaces |
Passed: 96 tests, 276 assertions. |
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections |
Passed: 78 tests, 588 assertions. |
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/RequiredPermissions |
Passed: 21 tests, 82 assertions. |
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Filament |
Rerun after formatting completed with 764 passed, 5 skipped, 1 failed. The failure was an order-sensitive ReviewPack creation assertion in GovernanceArtifactEnvironmentContextTest, outside changed terminology code. |
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Filament/GovernanceArtifacts/GovernanceArtifactEnvironmentContextTest.php |
Passed: 5 tests, 12 assertions immediately after the full-suite failure. |
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec190BaselineCompareMatrixSmokeTest.php tests/Browser/Spec281ProviderConnectionScopeSmokeTest.php tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php tests/Browser/Dashboard/TenantDashboardProductizationSmokeTest.php |
Passed: 6 tests, 105 assertions. |
cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent |
Passed. |
Residual Risk
The only remaining validation issue is the order-sensitive full Filament lane failure documented above. It does not touch the Spec 298 terminology files and passes in isolation, so it is not treated as an in-scope terminology finding. It should be tracked separately if full-suite determinism is required before merge.