## Summary - add a shared diff presentation layer under `app/Support/Diff` with deterministic row classification, summary derivation, and value stringification - centralize diff-state badge semantics through `BadgeCatalog` with a dedicated `DiffRowStatusBadge` - add reusable Filament diff partials, focused Pest coverage, and the full SpecKit artifact set for spec 141 ## Testing - `vendor/bin/sail artisan test --compact tests/Unit/Support/Diff/DiffRowStatusTest.php tests/Unit/Support/Diff/DiffRowTest.php tests/Unit/Support/Diff/DiffPresenterTest.php tests/Unit/Support/Diff/ValueStringifierTest.php tests/Unit/Badges/DiffRowStatusBadgeTest.php tests/Feature/Support/Diff/SharedDiffSummaryPartialTest.php tests/Feature/Support/Diff/SharedDiffRowPartialTest.php tests/Feature/Support/Diff/SharedInlineListDiffPartialTest.php` - `vendor/bin/sail bin pint --dirty --format agent` ## Filament / Livewire Contract - Livewire v4.0+ compliance: unchanged and respected; this feature adds presentation support only within the existing Filament v5 / Livewire v4 stack - Provider registration: unchanged; no panel/provider changes were required, so `bootstrap/providers.php` remains the correct registration location - Global search: unchanged; no Resource or global-search behavior was added or modified - Destructive actions: none introduced in this feature - Asset strategy: no new registered Filament assets; shared Blade partials rely on the existing asset pipeline and standard deploy step for `php artisan filament:assets` when assets change generally - Testing coverage: presenter, DTOs, stringifier, badge semantics, summary partial, row partial, and inline-list partial are covered by focused Pest unit and feature tests ## Notes - Spec checklist status is complete for `specs/141-shared-diff-presentation-foundation/checklists/requirements.md` - This PR preserves specialized diff renderers and documents incremental adoption rather than forcing migration in the same change Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #170
149 lines
3.6 KiB
PHP
149 lines
3.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Support\Diff;
|
|
|
|
use BackedEnum;
|
|
use Illuminate\Contracts\Support\Arrayable;
|
|
use JsonSerializable;
|
|
use Stringable;
|
|
|
|
final class ValueStringifier
|
|
{
|
|
public function stringify(mixed $value): string
|
|
{
|
|
if ($value === null) {
|
|
return '—';
|
|
}
|
|
|
|
if ($value instanceof BackedEnum) {
|
|
return $this->stringify($value->value);
|
|
}
|
|
|
|
if ($value instanceof Stringable) {
|
|
$value = (string) $value;
|
|
}
|
|
|
|
if (is_bool($value)) {
|
|
return $value ? 'Enabled' : 'Disabled';
|
|
}
|
|
|
|
if (is_string($value)) {
|
|
return $value === '' ? '""' : $value;
|
|
}
|
|
|
|
if (is_int($value) || is_float($value)) {
|
|
return (string) $value;
|
|
}
|
|
|
|
if (is_array($value)) {
|
|
if ($value === []) {
|
|
return '[]';
|
|
}
|
|
|
|
if ($this->isInlineList($value)) {
|
|
return implode(', ', array_map(fn (mixed $item): string => $this->stringify($item), $value));
|
|
}
|
|
|
|
return $this->encodeStructuredValue($value);
|
|
}
|
|
|
|
if ($value instanceof Arrayable) {
|
|
return $this->stringify($value->toArray());
|
|
}
|
|
|
|
if ($value instanceof JsonSerializable) {
|
|
return $this->stringify($value->jsonSerialize());
|
|
}
|
|
|
|
return $this->encodeStructuredValue(['value' => get_debug_type($value)]);
|
|
}
|
|
|
|
/**
|
|
* @param array<int|string, mixed> $value
|
|
*/
|
|
private function encodeStructuredValue(array $value): string
|
|
{
|
|
return json_encode(
|
|
$this->normalizeStructuredValue($value),
|
|
JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE,
|
|
) ?: '{}';
|
|
}
|
|
|
|
/**
|
|
* @param array<int|string, mixed> $value
|
|
* @return array<int|string, mixed>
|
|
*/
|
|
private function normalizeStructuredValue(array $value): array
|
|
{
|
|
$normalized = [];
|
|
|
|
foreach ($value as $key => $item) {
|
|
if ($item instanceof BackedEnum) {
|
|
$normalized[$key] = $item->value;
|
|
|
|
continue;
|
|
}
|
|
|
|
if ($item instanceof Stringable) {
|
|
$normalized[$key] = (string) $item;
|
|
|
|
continue;
|
|
}
|
|
|
|
if ($item instanceof Arrayable) {
|
|
$normalized[$key] = $this->normalizeStructuredValue($item->toArray());
|
|
|
|
continue;
|
|
}
|
|
|
|
if ($item instanceof JsonSerializable) {
|
|
$json = $item->jsonSerialize();
|
|
$normalized[$key] = is_array($json)
|
|
? $this->normalizeStructuredValue($json)
|
|
: $json;
|
|
|
|
continue;
|
|
}
|
|
|
|
if (is_array($item)) {
|
|
$normalized[$key] = $this->normalizeStructuredValue($item);
|
|
|
|
continue;
|
|
}
|
|
|
|
if (is_object($item)) {
|
|
$normalized[$key] = get_debug_type($item);
|
|
|
|
continue;
|
|
}
|
|
|
|
$normalized[$key] = $item;
|
|
}
|
|
|
|
return array_is_list($normalized) ? array_values($normalized) : $normalized;
|
|
}
|
|
|
|
/**
|
|
* @param array<int, mixed> $value
|
|
*/
|
|
private function isInlineList(array $value): bool
|
|
{
|
|
if (! array_is_list($value)) {
|
|
return false;
|
|
}
|
|
|
|
foreach ($value as $item) {
|
|
if ($item !== null
|
|
&& ! is_scalar($item)
|
|
&& ! $item instanceof BackedEnum
|
|
&& ! $item instanceof Stringable) {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
}
|