Some checks failed
Main Confidence / confidence (push) Failing after 48s
## Summary - implement the finding outcome taxonomy end-to-end with canonical resolve, close, reopen, and verification semantics - align finding UI, filters, audit metadata, review summaries, and export/read-model consumers to the shared outcome semantics - add focused Pest coverage and complete the spec artifacts for feature 231 ## Details - manual resolve is limited to the canonical `remediated` outcome - close and reopen flows now use bounded canonical reasons - trusted system clear and reopen distinguish verified-clear from verification-failed and recurrence paths - duplicate lifecycle backfill now closes findings canonically as `duplicate` - accepted-risk recording now uses the canonical `accepted_risk` reason - finding detail and list surfaces now expose terminal outcome and verification summaries - review, snapshot, and review-pack consumers now propagate the same outcome buckets ## Filament / Platform Contract - Livewire v4.0+ compatibility remains intact - provider registration is unchanged and remains in `bootstrap/providers.php` - no new globally searchable resource was introduced; `FindingResource` still has a View page and `TenantReviewResource` remains globally searchable false - lifecycle mutations still run through confirmed Filament actions with capability enforcement - no new asset family was added; the existing `filament:assets` deploy step is unchanged ## Verification - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings/FindingWorkflowServiceTest.php tests/Feature/Findings/FindingRecurrenceTest.php tests/Feature/Findings/FindingsListFiltersTest.php tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Findings/FindingOutcomeSummaryReportingTest.php tests/Feature/Findings/FindingRiskGovernanceProjectionTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings tests/Feature/Filament/FindingResolvedReferencePresentationTest.php tests/Feature/Models/FindingResolvedTest.php tests/Unit/Findings/FindingWorkflowServiceTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewExplanationSurfaceTest.php tests/Feature/TenantReview/TenantReviewRegisterTest.php tests/Feature/ReviewPack/TenantReviewDerivedReviewPackTest.php` - browser smoke: `/admin/findings/my-work` -> finding detail resolve flow -> queue regression check passed ## Notes - this commit also includes the existing `.github/agents/copilot-instructions.md` workspace change that was already present in the worktree when all changes were committed Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #267
100 lines
3.8 KiB
PHP
100 lines
3.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\FindingResource\Pages\ViewFinding;
|
|
use App\Models\Finding;
|
|
use App\Models\User;
|
|
use Filament\Facades\Filament;
|
|
use Filament\Forms\Components\Select;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('shows workflow header actions on the view page for authorized members', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$newFinding = Finding::factory()->for($tenant)->create(['status' => Finding::STATUS_NEW]);
|
|
$triagedFinding = Finding::factory()->for($tenant)->create(['status' => Finding::STATUS_TRIAGED]);
|
|
$resolvedFinding = Finding::factory()->for($tenant)->create([
|
|
'status' => Finding::STATUS_RESOLVED,
|
|
'resolved_at' => now(),
|
|
'resolved_reason' => Finding::RESOLVE_REASON_REMEDIATED,
|
|
]);
|
|
|
|
Livewire::test(ViewFinding::class, ['record' => $newFinding->getKey()])
|
|
->assertActionVisible('triage')
|
|
->assertActionVisible('assign')
|
|
->assertActionVisible('resolve')
|
|
->assertActionVisible('close')
|
|
->assertActionVisible('request_exception');
|
|
|
|
Livewire::test(ViewFinding::class, ['record' => $triagedFinding->getKey()])
|
|
->assertActionVisible('start_progress');
|
|
|
|
Livewire::test(ViewFinding::class, ['record' => $resolvedFinding->getKey()])
|
|
->assertActionVisible('reopen')
|
|
->mountAction('reopen')
|
|
->assertActionMounted('reopen')
|
|
->assertFormFieldExists('reopen_reason', function (Select $field): bool {
|
|
return $field->getLabel() === 'Reopen reason'
|
|
&& array_keys($field->getOptions()) === Finding::reopenReasonKeys();
|
|
});
|
|
});
|
|
|
|
it('executes workflow actions from view header and supports assignment to tenant members only', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$assignee = User::factory()->create();
|
|
createUserWithTenant(tenant: $tenant, user: $assignee, role: 'operator');
|
|
|
|
$outsider = User::factory()->create();
|
|
|
|
$finding = Finding::factory()->for($tenant)->create(['status' => Finding::STATUS_NEW]);
|
|
|
|
$component = Livewire::test(ViewFinding::class, ['record' => $finding->getKey()]);
|
|
|
|
$component
|
|
->callAction('triage')
|
|
->assertHasNoActionErrors()
|
|
->callAction('assign', [
|
|
'assignee_user_id' => (int) $assignee->getKey(),
|
|
'owner_user_id' => (int) $user->getKey(),
|
|
])
|
|
->assertHasNoActionErrors()
|
|
->callAction('resolve', [
|
|
'resolved_reason' => Finding::RESOLVE_REASON_REMEDIATED,
|
|
])
|
|
->assertHasNoActionErrors();
|
|
|
|
$finding->refresh();
|
|
expect($finding->status)->toBe(Finding::STATUS_RESOLVED)
|
|
->and((int) $finding->assignee_user_id)->toBe((int) $assignee->getKey())
|
|
->and((int) $finding->owner_user_id)->toBe((int) $user->getKey());
|
|
|
|
Livewire::test(ViewFinding::class, ['record' => $finding->getKey()])
|
|
->mountAction('reopen')
|
|
->assertActionMounted('reopen')
|
|
->assertFormFieldExists('reopen_reason', function (Select $field): bool {
|
|
return array_keys($field->getOptions()) === Finding::reopenReasonKeys();
|
|
});
|
|
|
|
Livewire::test(ViewFinding::class, ['record' => $finding->getKey()])
|
|
->callAction('reopen', [
|
|
'reopen_reason' => Finding::REOPEN_REASON_MANUAL_REASSESSMENT,
|
|
])
|
|
->assertHasNoActionErrors()
|
|
->callAction('assign', [
|
|
'assignee_user_id' => (int) $outsider->getKey(),
|
|
'owner_user_id' => (int) $user->getKey(),
|
|
]);
|
|
|
|
$finding->refresh();
|
|
expect((int) $finding->assignee_user_id)->toBe((int) $assignee->getKey());
|
|
});
|