99878408ce
Some checks failed
PR Fast Feedback / fast-feedback (pull_request) Failing after 1m12s
Added BaselineSubjectResolution page and supporting logic to visualize missing identities, ambiguous matches, and skipped coverages per Spec 384.
78 lines
4.8 KiB
Markdown
78 lines
4.8 KiB
Markdown
# Specification Quality Checklist: Spec 384 - Baseline Subject Resolution UI and Operator Decisions v1
|
|
|
|
**Purpose**: Validate specification completeness, repo alignment, and implementation readiness before implementation.
|
|
**Created**: 2026-06-16
|
|
**Feature**: `specs/384-baseline-subject-resolution-ui/spec.md`
|
|
|
|
## Candidate Selection and Completion Guardrail
|
|
|
|
- [x] CHK001 The selected candidate is directly user-provided as Spec 384.
|
|
- [x] CHK002 The active auto-candidate queue was not used as a forced source because it currently has no safe automatic next-best-prep target.
|
|
- [x] CHK003 Specs 381, 382, and 383 are treated as completed dependency context only.
|
|
- [x] CHK004 Historical Spec 163 is treated as adjacent/historical context and is not selected or modified.
|
|
- [x] CHK005 No existing Spec 384 package or branch was found before creation.
|
|
|
|
## Content Quality
|
|
|
|
- [x] CHK010 The spec states the operator problem, business value, users, scope, out-of-scope boundaries, assumptions, risks, and success criteria.
|
|
- [x] CHK011 Functional and non-functional requirements are testable and numbered.
|
|
- [x] CHK012 Acceptance criteria map to the selected V1 scope.
|
|
- [x] CHK013 No `[NEEDS CLARIFICATION]` markers remain.
|
|
- [x] CHK014 Open questions are explicitly non-blocking follow-up decisions.
|
|
|
|
## Constitution and Scope Control
|
|
|
|
- [x] CHK020 The spec includes a Spec Candidate Check and scored approval class.
|
|
- [x] CHK021 The spec includes a proportionality review for the new page/query layer and high-impact actions.
|
|
- [x] CHK022 The spec rejects a generic workflow/task/approval engine.
|
|
- [x] CHK023 The spec rejects a new primary decision table by default and reuses `provider_resource_bindings`.
|
|
- [x] CHK024 The spec rejects legacy subject-key UI, old payload readers, display-name identity, and compatibility shims.
|
|
- [x] CHK025 Evidence/Review readiness and customer-facing output are explicitly deferred to Spec 385.
|
|
|
|
## UI and Productization Coverage
|
|
|
|
- [x] CHK030 The spec includes exactly one coherent UI Surface Impact decision with concrete impact boxes checked.
|
|
- [x] CHK031 UI/Productization Coverage is completed for the new strategic operator surface.
|
|
- [x] CHK032 The plan and tasks require updates to `docs/ui-ux-enterprise-audit/route-inventory.md`, `design-coverage-matrix.md`, and a page report during implementation.
|
|
- [x] CHK033 The new page is classified as a Primary Decision Surface.
|
|
- [x] CHK034 Decision-first, audience-aware disclosure, UI/UX surface classification, and operator surface contract tables are present.
|
|
- [x] CHK035 Browser smoke is required because a new strategic high-impact surface is added.
|
|
- [x] CHK036 The spec, plan, and tasks reference `docs/product/standards/list-surface-review-checklist.md` for the new list/table surface.
|
|
|
|
## RBAC, Audit, and Safety
|
|
|
|
- [x] CHK040 The spec defines 404 for non-members and 403 for entitled members missing capability.
|
|
- [x] CHK041 The spec reuses existing baseline capabilities by default and requires a spec update before adding a new capability family.
|
|
- [x] CHK042 All high-impact decision actions require confirmation, server-side authorization, required notes where specified, and audit.
|
|
- [x] CHK043 The spec states that UI visibility/disabled state is not authorization.
|
|
- [x] CHK044 Audit metadata requirements are included.
|
|
|
|
## OperationRun and Provider Boundary
|
|
|
|
- [x] CHK050 Resolution decisions do not create a new OperationRun.
|
|
- [x] CHK051 Rerun/refresh compare must reuse existing baseline compare OperationRun UX.
|
|
- [x] CHK052 The spec forbids local OperationRun lifecycle/status/outcome handling.
|
|
- [x] CHK053 Provider/platform boundary is classified as mixed with provider identifiers retained only as proof/candidate data.
|
|
- [x] CHK054 Display names are labels only and cannot be identity.
|
|
|
|
## Test and Task Readiness
|
|
|
|
- [x] CHK060 `spec.md`, `plan.md`, and `tasks.md` exist.
|
|
- [x] CHK061 Tasks are grouped by setup/foundation/user story/polish phases.
|
|
- [x] CHK062 Tasks include unit, feature, Filament/Livewire, browser, RBAC, audit, and regression validation.
|
|
- [x] CHK063 Tasks include explicit UI coverage artifact work.
|
|
- [x] CHK064 Tasks include final validation commands, Pint, `git diff --check`, and close-out recording.
|
|
- [x] CHK065 Tasks include explicit no-Graph/provider-runtime negative coverage for the DB-only resolution surface.
|
|
- [x] CHK066 Tasks include a `missing_expected` preflight so the optional mode is implemented only if existing service/model support is sufficient.
|
|
|
|
## Review Outcome
|
|
|
|
- [x] CHK070 Review outcome class: `acceptable-special-case`.
|
|
- [x] CHK071 Workflow outcome: `keep`.
|
|
- [x] CHK072 Candidate Selection Gate result: PASS.
|
|
- [x] CHK073 Spec Readiness Gate preparation status: PASS after preparation analysis.
|
|
|
|
## Notes
|
|
|
|
- Preparation-only scope was maintained. No application code, migrations, models, services, jobs, Filament runtime files, routes, tests, or views were modified.
|