ahmido 38523814c2 fix: restore full-suite green signals across platform workflows (#351 )

## Summary
- restore broad full-suite green-signal coverage across platform governance, operations, onboarding, dashboard/productization, and customer review flows
- align related platform tests and supporting behavior with the current expected state for this restoration pass
- update the spec-candidates queue as part of the same suite-restoration sweep

## Validation
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Dashboard/TenantDashboardProductizationSmokeTest.php tests/Browser/Reviews/CustomerReviewWorkspaceSmokeTest.php tests/Browser/Spec194GovernanceFrictionSmokeTest.php tests/Browser/Spec265DecisionRegisterSmokeTest.php`

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #351

2026-05-12 18:50:40 +00:00

4.3 KiB

Raw Blame History

Browser Evidence: Full Suite Green Signal Restoration

Purpose

Record browser screenshots, browser-lane failures, and screenshot baseline decisions during Spec 296. This file distinguishes evidence from committed baseline changes.

Evidence Protocol

Before browser repairs:

mkdir -p /tmp/tenantpilot-296-browser-evidence
cp -R apps/platform/tests/Browser/Screenshots/* /tmp/tenantpilot-296-browser-evidence/ || true

After browser runs:

git status --short apps/platform/tests/Browser/Screenshots
git diff --stat apps/platform/tests/Browser/Screenshots

If screenshots are evidence only:

git restore apps/platform/tests/Browser/Screenshots

Browser Evidence Table

Screenshot or artifact	Generated by command	Shows real bug? yes/no	Committed? yes/no	Baseline updated? yes/no	Reason	Status
N/A during preparation	N/A	no	no	no	No browser command was run during preparation.	prepared
`/tmp/tenantpilot-296-browser-evidence/*.png` (10 files)	`cd apps/platform && ./vendor/bin/sail artisan test --compact`	no	no	no	Raw full-suite browser screenshots were generated while the suite was red and preserved as evidence. They are superseded by the final green browser lane and are not baseline updates.	superseded evidence-only
`/tmp/tenantpilot-296-browser-evidence/browser-lane-current/*.png` (10 files)	`./scripts/platform-test-lane browser`	no	no	no	The initial browser lane remained red and rewrote the same tracked screenshot files. Those images are superseded by the final green browser lane and are not baseline updates.	superseded evidence-only
Tracked `apps/platform/tests/Browser/Screenshots/*.png`	Final `./scripts/platform-test-lane browser`	no	no	no	Final browser lane passed; the run removed ten tracked screenshot files as harness output, but those deletions are evidence-only and were restored with `git restore apps/platform/tests/Browser/Screenshots`.	clean after restore

Browser Failure Table

Test file	Test name or group	Failure type	Evidence path	Fix decision	Validation command	Final status
Browser groups from Spec 295	smoke login, workspace operation route, panel context, dashboard layout, old `/admin/t/...`, tenant membership copy/action	stale route/panel/copy/browser drift	`/tmp/tenantpilot-296-browser-evidence` after implementation rerun	Repaired and rerun; no screenshot baseline update accepted	`./scripts/platform-test-lane browser`	superseded by final green browser lane
Initial Spec 296 browser baseline	smoke-login missing `Dashboard`, workspace operation route parameters, Filament panel context, dashboard spacing, stale `/admin/t/...`, tenant membership copy/action	red baseline evidence	`/tmp/tenantpilot-296-browser-evidence/browser-lane-current/`	Evidence-only; grouped repairs completed and lane rerun green	`./scripts/platform-test-lane browser`	superseded: initial 20 failed, final 49 passed
Final browser lane	smoke login, workspace operation route, Filament panel context, dashboard spacing, managed-environment cutover path, tenant membership copy/action	fixed	N/A; tracked screenshots restored	Browser expectations and runtime route/panel issues are repaired; no screenshot baseline update accepted	`./scripts/platform-test-lane browser`; `git status --short -- apps/platform/tests/Browser/Screenshots`	49 passed, 837 assertions; screenshot status clean

Final Screenshot State

git status --short -- apps/platform/tests/Browser/Screenshots prints no entries after the final restore. No browser screenshot baseline is intentionally updated or committed for Spec 296.

Baseline Update Rule

A screenshot baseline may be committed only when:

The rendered UI is correct current product truth.
The change is not caused by a broken page, missing data, auth failure, stale route, or panel context error.
The browser test intentionally verifies a visual baseline.
The exact file is listed above with a reason.
The browser lane passes after the update.

Non-Commit Rule

Screenshots generated by failing smoke tests are evidence by default. They should be copied under /tmp/tenantpilot-296-browser-evidence and restored from git unless this file explicitly documents a baseline update.

4.3 KiB Raw Blame History