TenantAtlas/specs/296-full-suite-green-signal-restoration/checklists/requirements.md
ahmido 38523814c2 fix: restore full-suite green signals across platform workflows (#351)
## Summary
- restore broad full-suite green-signal coverage across platform governance, operations, onboarding, dashboard/productization, and customer review flows
- align related platform tests and supporting behavior with the current expected state for this restoration pass
- update the spec-candidates queue as part of the same suite-restoration sweep

## Validation
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Dashboard/TenantDashboardProductizationSmokeTest.php tests/Browser/Reviews/CustomerReviewWorkspaceSmokeTest.php tests/Browser/Spec194GovernanceFrictionSmokeTest.php tests/Browser/Spec265DecisionRegisterSmokeTest.php`

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #351
2026-05-12 18:50:40 +00:00

3.5 KiB

Specification Quality Checklist: Full Suite Green Signal Restoration

Purpose: Validate specification completeness and quality before implementation
Created: 2026-05-11
Feature: spec.md

Content Quality

  • No application implementation was performed during preparation.
  • Focused on maintainer/operator value: restore or explicitly control the full-suite CI signal.
  • Written for maintainers and reviewers who must execute a stabilization loop.
  • All mandatory Spec Kit sections are completed or explicitly marked N/A.

Requirement Completeness

  • No unresolved [NEEDS CLARIFICATION] markers remain.
  • Requirements are testable and unambiguous.
  • Success criteria are measurable.
  • Success criteria are repo-aware only where validation commands require it.
  • All acceptance scenarios are defined.
  • Edge cases are identified.
  • Scope is clearly bounded.
  • Dependencies and assumptions are identified.

Feature Readiness

  • All functional requirements have clear acceptance criteria.
  • User scenarios cover baseline inventory, guard lanes, root-cause repairs, lane/browser decisions, and final CI-signal close-out.
  • Feature meets measurable outcomes defined in Success Criteria.
  • No implementation detail expands into new product feature scope.

Spec 296 Specific Checks

  • failure-inventory.md exists and includes the required columns.
  • fix-log.md exists and defines per-file fix logging.
  • lane-decisions.md exists and defines default/browser/heavy/wrong-lane decisions.
  • browser-evidence.md exists and defines screenshot evidence rules.
  • Legacy /admin/t/..., TenantPanelProvider restoration, and /admin/operations fallback routes are explicitly forbidden.
  • Workspace-first route generation and OperationRunLinks are named as current truth.
  • Filament v5 / Livewire v4 compliance is explicitly covered.
  • Provider registration location is explicitly covered as apps/platform/bootstrap/providers.php.
  • Globally searchable resource review requirements are covered for any touched resource.
  • Destructive action confirmation and authorization requirements are covered.
  • Asset strategy is documented as unchanged unless unexpected asset registration changes occur.
  • Testing plan covers focused files, affected lanes, full suite, browser when touched, Pint, and git diff --check.

Candidate Selection Gate

  • Selected candidate is directly provided by the user.
  • specs/296-full-suite-green-signal-restoration/ did not already exist before preparation.
  • No existing completed Spec 296 was modified.
  • Related Specs 293, 294, and 295 were treated as completed/contextual artifacts, not rewritten.
  • Candidate aligns with current repo truth from Spec 295: full suite remains red after classification.
  • Scope is bounded as a stabilization/cleanup pass, not a new product feature.

Spec Readiness Gate

  • spec.md, plan.md, and tasks.md exist.
  • Required additional artifacts exist.
  • Plan identifies likely affected repo surfaces without requiring broad refactors.
  • Tasks are ordered, small, and verifiable.
  • RBAC, workspace/tenant isolation, provider boundary, OperationRun semantics, browser evidence, and test governance are addressed.
  • No open question blocks implementation.

Notes

Preparation analyze found no blocking readiness issue after these artifacts were created.