ahmido
292d555eac
## Summary - consolidate internal platform naming from `Tenant` to `Environment` / `ManagedEnvironment` across models, controllers, services, and Filament resources - rename environment-scoped UI surfaces such as dashboards, chooser flows, navigation, and related widgets to match the updated environment-first domain language - align middleware, onboarding/review lifecycle services, jobs, and route/context controllers with the new environment-scoped architecture ## Validation - not rerun as part of this commit/push/PR request ## Notes - branch is 1 commit ahead of `platform-dev` - main commit: `refactor: consolidate internal tenant model naming` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #355
57 lines
3.3 KiB
Markdown
57 lines
3.3 KiB
Markdown
# Requirements Checklist: Internal Tenant Model Naming Consolidation
|
|
|
|
**Purpose**: Preparation readiness review for Spec 300
|
|
**Created**: 2026-05-13
|
|
**Feature**: `specs/300-internal-tenant-model-naming-consolidation/spec.md`
|
|
|
|
## Candidate And Scope
|
|
|
|
- [x] CHK001 The selected candidate was directly provided by the user as Spec 300.
|
|
- [x] CHK002 The scope is cleanup-only and explicitly follows Specs 297-299.
|
|
- [x] CHK003 Completed-spec guardrail was checked for Specs 297-299; they are dependency context, not rewrite targets.
|
|
- [x] CHK004 The spec does not create a new product feature, navigation redesign, provider framework, OperationRun architecture, or localization sweep.
|
|
- [x] CHK005 The spec uses current repo truth: `ManagedEnvironment` and `managed_environments` already exist.
|
|
|
|
## Constitution And Architecture
|
|
|
|
- [x] CHK006 SPEC-GATE-001 candidate check is filled.
|
|
- [x] CHK007 Proportionality review is filled for the broad structural rename blast radius.
|
|
- [x] CHK008 No new persisted product truth, enum/status family, DTO/presenter layer, registry, resolver, or UI framework is introduced.
|
|
- [x] CHK009 LEAN-001 compatibility posture is explicit: no aliases, no dual-write/read, no route compatibility unless the spec stops for migration risk.
|
|
- [x] CHK010 Provider boundary handling distinguishes platform Managed Environment truth from Microsoft/Entra/Graph tenant truth.
|
|
|
|
## Route, RBAC, And Filament
|
|
|
|
- [x] CHK011 Canonical `/admin/workspaces/{workspace}/environments/...` route contract is explicit.
|
|
- [x] CHK012 Retired `/admin/t/...` and `/admin/tenants/...` route families remain forbidden.
|
|
- [x] CHK013 Workspace membership and Managed Environment membership semantics are preserved.
|
|
- [x] CHK014 Filament v5 / Livewire v4.0+ compliance is explicit.
|
|
- [x] CHK015 Laravel 12 panel provider registration location is `apps/platform/bootstrap/providers.php`.
|
|
- [x] CHK016 Global search impact is explicitly called out for renamed resources.
|
|
- [x] CHK017 Destructive action confirmation, execution via `->action(...)`, authorization, and audit preservation are explicit.
|
|
- [x] CHK018 Asset strategy is unchanged unless implementation unexpectedly registers Filament assets.
|
|
|
|
## Test Governance
|
|
|
|
- [x] CHK019 Runtime/test impact is explicit.
|
|
- [x] CHK020 Focused validation lanes are named.
|
|
- [x] CHK021 Browser smoke anchors are explicit and do not become a hidden broad browser family.
|
|
- [x] CHK022 Fixture/helper cost risk is called out, especially around renamed tenant context helpers.
|
|
- [x] CHK023 Final scans and close-out inventory are required.
|
|
|
|
## Artifact Readiness
|
|
|
|
- [x] CHK024 `spec.md` exists.
|
|
- [x] CHK025 `plan.md` exists.
|
|
- [x] CHK026 `tasks.md` exists.
|
|
- [x] CHK027 `tenant-reference-inventory.md` exists as a preparation baseline.
|
|
- [x] CHK028 `allowed-tenant-references.md` exists as a preparation baseline.
|
|
- [x] CHK029 Tasks are ordered, phased, and verifiable.
|
|
- [x] CHK030 No application implementation was performed during preparation.
|
|
|
|
## Review Outcome
|
|
|
|
- [x] CHK031 Review outcome class: `documentation-required-exception` because provider/framework tenant references must remain allowed and documented.
|
|
- [x] CHK032 Workflow outcome: `keep`.
|
|
- [x] CHK033 Final note location: active feature PR close-out entry `Guardrail / Structural Tenant Naming Consolidation / Smoke Coverage`.
|