ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity
9e435ea91f
TenantAtlas/specs/337-evidence-review-pack-product-process-flow-alignment/checklists/requirements.md
ahmido b7c0dfe0e3 feat: align evidence review pack product process flow (Spec 337) (#407) 
## Summary

Productizes the Evidence Overview review-pack process flow so the operator sees a clear, gated progression:

`evidence snapshot → stored report → review pack → customer-safe export`

with explicit gating, state-appropriate copy, collapsed diagnostics, and dark-mode coverage.

## Changes

- `EvidenceOverview` page + Blade view aligned to the review-pack state contract.
- New feature test: `Spec337EvidenceReviewPackProductFlowTest`.
- New browser smoke: `Spec337EvidenceReviewPackProductFlowSmokeTest`.
- Spec 337 artifacts: `spec.md`, `plan.md`, `tasks.md`, state contract, repo-truth map, checklist, and screenshot evidence.

## Spec Kit

Spec + code in one PR (Variante B). Gate satisfied: includes `specs/337-evidence-review-pack-product-process-flow-alignment/`.

## Notes

Filament v5 / Livewire v4 compliant. No destructive actions added. Tooling scratch (`.playwright-mcp/`) intentionally excluded from the commit.

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #407
2026-05-30 13:41:19 +00:00

3.7 KiB
Raw Blame History

Requirements Checklist: Spec 337 - Evidence Path / Review Pack Product Process Flow Alignment

Purpose: validate the prepared spec artifacts before runtime implementation begins.

Spec Identity

  • Spec number is reconciled to current repo state (337, because 336 already exists).
  • Branch name matches spec directory.
  • Input source and numbering reconciliation are documented.
  • Runtime posture forbids backend evidence/report/review-pack/export engine rewrites.

Constitution / Spec Candidate Gate

  • Spec Candidate Check is completed.
  • Problem, today's failure, user-visible improvement, smallest version, non-goals, complexity, why-now, why-not-local, approval class, red flags, score, and decision are filled.
  • Proportionality review is included for the possible derived presenter.
  • No new persisted truth, enum family, lifecycle family, or generic workflow framework is proposed.
  • Shared pattern first is explicit through Spec 332 Product Process Flow reuse.

Repo Truth

  • repo-truth-map.md exists.
  • Evidence snapshot source is classified.
  • Stored report source is classified.
  • Review pack source is classified.
  • Environment review / Customer Review Workspace relationship is classified.
  • OperationRun proof relationship is classified.
  • Export/download artifact relationship is classified.
  • Evidence freshness source is classified.
  • Customer-safe state source is classified.
  • RBAC/capabilities and routes/surfaces are classified.
  • Existing tests are listed.
  • Unavailable/deferred states are called out instead of invented.

State Contract

  • evidence-review-pack-state-contract.md exists.
  • Default flow steps are defined.
  • Presentation vocabulary is explicitly not a new enum family.
  • Missing, generating, failed, stale, report missing, review-pack required, review-pack generating, review-pack failed, customer-safe review required, customer-safe ready, export available, and export unavailable states are covered.
  • Each state includes visible status, reason, impact, primary next action, flow gate states, proof, customer-safe state, export state, and diagnostics default.
  • False customer-safe, auditor-ready, complete, and export-ready claims are forbidden.

UI / Filament Guardrails

  • UI Surface Impact is completed and does not claim "No UI surface impact".
  • UI/Productization Coverage is completed.
  • Decision-first surface role is completed.
  • Audience-aware disclosure is completed.
  • UI/UX surface classification is completed.
  • Operator surface contract is completed.
  • Livewire v4 / Filament v5 posture is explicit.
  • Provider registration location remains apps/platform/bootstrap/providers.php.
  • Global search state is addressed for relevant resources.
  • No new destructive actions are proposed.
  • Asset/deployment posture is explicit: no global asset or filament:assets change expected.

Testing / Validation

  • Feature test file path is specified.
  • Browser smoke file path is specified.
  • Required screenshots path and filenames are specified.
  • Required assertions cover missing evidence, report missing, review-pack required, review-pack available, OperationRun proof, RBAC/context, collapsed diagnostics, and no raw JSON.
  • Validation commands are listed.
  • Unreachable browser states must be documented rather than faked.

Implementation Readiness

  • spec.md, plan.md, tasks.md, repo-truth-map.md, evidence-review-pack-state-contract.md, checklists/requirements.md, and screenshot directory are present.
  • Runtime implementation has not started in this preparation step.
  • Recommended next prompt is implementation, not more preparation.