Some checks failed
Main Confidence / confidence (push) Failing after 48s
## Summary - add derived onboarding readiness to the managed tenant onboarding workflow and multi-draft picker - keep provider-specific permission diagnostics secondary while preserving canonical `Open operation` and existing onboarding action semantics - add spec-kit artifacts for `240-tenant-onboarding-readiness` and align roadmap/spec-candidate planning notes - unify the required-permissions empty state copy to English ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/RequiredPermissions/RequiredPermissionsEmptyStateTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - browser smoke exercised the onboarding picker, route-bound mismatch readiness state, canonical `Open operation` path, and local fixture cleanup ## Notes - branch includes the generated spec artifacts under `specs/240-tenant-onboarding-readiness/` - temporary browser smoke tenants/drafts/runs were cleaned from the local environment after validation Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #277
3.2 KiB
3.2 KiB
Quickstart — Self-Service Tenant Onboarding & Connection Readiness
Prereqs
- Docker running
- Laravel Sail dependencies installed
- Current feature branch checked out:
240-tenant-onboarding-readiness
Run locally
- Start containers:
cd apps/platform && ./vendor/bin/sail up -d - Run targeted validation after implementation:
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ManagedTenantOnboardingWizardTest.phpcd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Onboarding/OnboardingDraftPickerTest.php tests/Feature/Onboarding/OnboardingDraftAuthorizationTest.phpcd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Policies/TenantOnboardingSessionPolicyTest.php tests/Unit/TenantRequiredPermissionsFreshnessTest.php
- Format after implementation:
cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent
Manual smoke (after implementation)
- Select a workspace and open
/admin/onboarding. - With multiple resumable drafts, confirm each draft card shows current stage, readiness summary, freshness cue, and one primary next action.
- Open a draft with missing consent and confirm the workflow points to consent or permission remediation instead of generic incomplete-state copy.
- Open a draft with a changed provider connection or mismatched verification run and confirm readiness falls back to needs-attention with a canonical
Open operationlink when evidence exists. - Open the workflow as a wrong-workspace actor or actor without linked-tenant entitlement and confirm 404; open as a workspace member without onboarding capability and confirm 403 on protected actions.
Notes
- Filament v5 requires Livewire v4.0+; this repo already satisfies that requirement.
- Laravel 11+ panel providers are registered in
bootstrap/providers.php; this feature does not add or change panel providers. - No new Filament Resource or Global Search surface is planned, so global search behavior is unchanged.
- No new assets are registered. Deployment keeps the existing Filament asset step (
cd apps/platform && php artisan filament:assets) when other asset-bearing changes require it. - Readiness freshness for this slice reuses existing signals only: connection-change / selected-connection mismatch from onboarding lifecycle state plus stored permission freshness from
TenantRequiredPermissionsViewModelBuilder.
Implementation proof — 2026-04-25
- Targeted fast-feedback validation passed:
cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ManagedTenantOnboardingWizardTest.php tests/Feature/Onboarding/OnboardingDraftPickerTest.php tests/Feature/Onboarding/OnboardingDraftAuthorizationTest.php tests/Unit/Policies/TenantOnboardingSessionPolicyTest.php tests/Unit/TenantRequiredPermissionsFreshnessTest.php— 55 tests, 212 assertions. - Formatting passed:
cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent. - Guardrail close-out: keep. No provider-boundary drift, no lane-cost escalation, no new assets, no new persistence, and no follow-up spec required.
- Explicit defers retained: numeric completion score and cross-surface readiness reuse.