## Summary - add decision register summary output to environment review packs - update environment review evidence composition and localized summary rendering - add coverage for executive pack and derived review pack behavior - include spec artifacts for feature 308 ## Testing - cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/EnvironmentReview/EnvironmentReviewExecutivePackTest.php tests/Feature/ReviewPack/EnvironmentReviewDerivedReviewPackTest.php Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #363
3.3 KiB
3.3 KiB
Requirements Checklist: Decision Register Customer-Safe Summary & Review-Pack Inclusion
Purpose: Validate that the preparation artifacts are clear, bounded, testable, and aligned with TenantPilot constitution guardrails before implementation. Created: 2026-05-15 Feature: spec.md
Requirement Quality
- CHK001 The selected candidate is explicitly sourced from the user request, roadmap priority ranking, and manual-promotion backlog.
- CHK002 The scope is narrowed to existing Decision Register context, Environment Review summaries, Customer Review Workspace/review detail, and review-derived Review Pack export.
- CHK003 Functional requirements are testable and avoid implementation-only wording where user behavior is the point.
- CHK004 Acceptance criteria cover positive, empty/none, unavailable/incomplete, redaction, and cross-scope scenarios.
- CHK005 Out-of-scope boundaries explicitly reject new decision persistence, new workflow engines, new customer approval actions, new OperationRun lifecycle, and broad export redesign.
Constitution And Product Truth
- CHK006 The spec identifies the source of truth for decisions, reviews, review packs, evidence, and operation runs.
- CHK007 The proportionality review states no new persisted entity, enum/status family, public framework, or artifact family is planned.
- CHK008 Existing completed specs 265, 306, 307, 109, 258, and 260 are treated as context only and are not modified.
- CHK009 Provider-boundary requirements avoid spreading Microsoft/provider-specific semantics into platform-core review/export truth.
- CHK010 Customer-safe disclosure requirements preserve non-certification wording and avoid raw/debug/internal detail.
UI, RBAC, And Operations
- CHK011 The affected surfaces carry consistent native/shared Filament classification and do not require ad-hoc styling or new assets.
- CHK012 Filament v5 / Livewire v4, provider registration, global search, destructive action confirmation, and asset strategy requirements are explicit.
- CHK013 RBAC requirements preserve workspace/environment isolation, non-member 404, and missing-capability 403 semantics.
- CHK014 OperationRun impact is explicitly bounded to existing review-pack generation behavior with no new run UX.
- CHK015 Auditability requirements preserve existing review and review-pack telemetry/audit semantics and avoid new audit action IDs unless scope changes.
Test Governance
- CHK016 Planned Pest coverage uses existing focused EnvironmentReview, ReviewPack, and Reviews feature families.
- CHK017 Browser coverage is bounded to the existing CustomerReviewWorkspace smoke only if rendered UI changes.
- CHK018 Fixture/helper cost risks are identified and kept feature-local.
- CHK019 Validation commands are concrete and scoped.
- CHK020 The task list includes explicit Filament/RBAC/asset/no-migration contract review tasks.
Preparation Outcome
- Outcome class: acceptable-special-case.
- Workflow outcome: keep.
- Final note location: active feature PR close-out entry
Guardrail / Smoke Coverage. - Spec Readiness Gate passes for preparation:
spec.md,plan.md,tasks.md, and this checklist exist, contain no placeholders, and keep implementation scope bounded to Spec 308.