## Summary - harden finding lifecycle changes behind the canonical `FindingWorkflowService` gateway - route automated resolve and reopen flows through the same audited workflow path - tighten tenant and workspace scope checks on finding actions and audit visibility - add focused spec artifacts, workflow regression coverage, automation coverage, and audit visibility tests - update legacy finding model tests to use the workflow service after direct lifecycle mutators were removed ## Testing - `vendor/bin/sail bin pint --dirty --format agent` - focused findings and audit slices passed during implementation - `vendor/bin/sail artisan test --compact tests/Feature/Models/FindingResolvedTest.php` - full repository suite passed: `2757 passed`, `8 skipped`, `14448 assertions` ## Notes - Livewire v4.0+ compliance preserved - no new Filament assets or panel providers introduced; provider registration remains in `bootstrap/providers.php` - findings stay on existing Filament action surfaces, with destructive actions still confirmation-gated - no global search behavior was changed for findings resources Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #181
147 lines
4.1 KiB
PHP
147 lines
4.1 KiB
PHP
<?php
|
|
|
|
namespace App\Policies;
|
|
|
|
use App\Models\Finding;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Services\Auth\CapabilityResolver;
|
|
use App\Support\Auth\Capabilities;
|
|
use App\Support\OperateHub\OperateHubShell;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Auth\Access\HandlesAuthorization;
|
|
use Illuminate\Auth\Access\Response;
|
|
|
|
class FindingPolicy
|
|
{
|
|
use HandlesAuthorization;
|
|
|
|
public function viewAny(User $user): bool
|
|
{
|
|
$tenant = $this->resolvedTenant();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
return false;
|
|
}
|
|
|
|
if (! $user->canAccessTenant($tenant)) {
|
|
return false;
|
|
}
|
|
|
|
return app(CapabilityResolver::class)->can($user, $tenant, Capabilities::TENANT_FINDINGS_VIEW);
|
|
}
|
|
|
|
public function view(User $user, Finding $finding): Response|bool
|
|
{
|
|
$tenant = $this->authorizedTenantOrNull($user, $finding);
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
return app(CapabilityResolver::class)->can($user, $tenant, Capabilities::TENANT_FINDINGS_VIEW);
|
|
}
|
|
|
|
public function update(User $user, Finding $finding): Response|bool
|
|
{
|
|
return $this->triage($user, $finding);
|
|
}
|
|
|
|
public function triage(User $user, Finding $finding): Response|bool
|
|
{
|
|
return $this->canMutateWithAnyCapability($user, $finding, [
|
|
Capabilities::TENANT_FINDINGS_TRIAGE,
|
|
Capabilities::TENANT_FINDINGS_ACKNOWLEDGE,
|
|
]);
|
|
}
|
|
|
|
public function assign(User $user, Finding $finding): Response|bool
|
|
{
|
|
return $this->canMutateWithCapability($user, $finding, Capabilities::TENANT_FINDINGS_ASSIGN);
|
|
}
|
|
|
|
public function resolve(User $user, Finding $finding): Response|bool
|
|
{
|
|
return $this->canMutateWithCapability($user, $finding, Capabilities::TENANT_FINDINGS_RESOLVE);
|
|
}
|
|
|
|
public function close(User $user, Finding $finding): Response|bool
|
|
{
|
|
return $this->canMutateWithCapability($user, $finding, Capabilities::TENANT_FINDINGS_CLOSE);
|
|
}
|
|
|
|
public function riskAccept(User $user, Finding $finding): Response|bool
|
|
{
|
|
return $this->canMutateWithCapability($user, $finding, Capabilities::TENANT_FINDINGS_RISK_ACCEPT);
|
|
}
|
|
|
|
public function reopen(User $user, Finding $finding): Response|bool
|
|
{
|
|
return $this->triage($user, $finding);
|
|
}
|
|
|
|
private function canMutateWithCapability(User $user, Finding $finding, string $capability): Response|bool
|
|
{
|
|
return $this->canMutateWithAnyCapability($user, $finding, [$capability]);
|
|
}
|
|
|
|
/**
|
|
* @param array<int, string> $capabilities
|
|
*/
|
|
private function canMutateWithAnyCapability(User $user, Finding $finding, array $capabilities): Response|bool
|
|
{
|
|
$tenant = $this->authorizedTenantOrNull($user, $finding);
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
/** @var CapabilityResolver $resolver */
|
|
$resolver = app(CapabilityResolver::class);
|
|
|
|
foreach ($capabilities as $capability) {
|
|
if ($resolver->can($user, $tenant, $capability)) {
|
|
return true;
|
|
}
|
|
}
|
|
|
|
return Response::deny();
|
|
}
|
|
|
|
private function authorizedTenantOrNull(User $user, Finding $finding): ?Tenant
|
|
{
|
|
$tenant = $this->resolvedTenant();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
return null;
|
|
}
|
|
|
|
if (! $user->canAccessTenant($tenant)) {
|
|
return null;
|
|
}
|
|
|
|
if ((int) $finding->tenant_id !== (int) $tenant->getKey()) {
|
|
return null;
|
|
}
|
|
|
|
if ((int) $finding->workspace_id !== (int) $tenant->workspace_id) {
|
|
return null;
|
|
}
|
|
|
|
return $tenant;
|
|
}
|
|
|
|
private function resolvedTenant(): ?Tenant
|
|
{
|
|
if (Filament::getCurrentPanel()?->getId() === 'admin') {
|
|
$tenant = app(OperateHubShell::class)->tenantOwnedPanelContext(request());
|
|
|
|
return $tenant instanceof Tenant ? $tenant : null;
|
|
}
|
|
|
|
$tenant = Tenant::current();
|
|
|
|
return $tenant instanceof Tenant ? $tenant : null;
|
|
}
|
|
}
|