ahmido
ec71c2d4e7
## Summary - harden finding lifecycle changes behind the canonical `FindingWorkflowService` gateway - route automated resolve and reopen flows through the same audited workflow path - tighten tenant and workspace scope checks on finding actions and audit visibility - add focused spec artifacts, workflow regression coverage, automation coverage, and audit visibility tests - update legacy finding model tests to use the workflow service after direct lifecycle mutators were removed ## Testing - `vendor/bin/sail bin pint --dirty --format agent` - focused findings and audit slices passed during implementation - `vendor/bin/sail artisan test --compact tests/Feature/Models/FindingResolvedTest.php` - full repository suite passed: `2757 passed`, `8 skipped`, `14448 assertions` ## Notes - Livewire v4.0+ compliance preserved - no new Filament assets or panel providers introduced; provider registration remains in `bootstrap/providers.php` - findings stay on existing Filament action surfaces, with destructive actions still confirmation-gated - no global search behavior was changed for findings resources Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #181
52 lines
2.0 KiB
PHP
52 lines
2.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\AuditLog;
|
|
use App\Models\Finding;
|
|
use App\Services\Findings\FindingWorkflowService;
|
|
use App\Services\Intune\AuditLogger;
|
|
use App\Support\Audit\AuditActionId;
|
|
use Mockery\MockInterface;
|
|
|
|
use function Pest\Laravel\mock;
|
|
|
|
it('registers canonical findings workflow audit actions', function (): void {
|
|
expect(AuditActionId::knownValues())
|
|
->toContain(AuditActionId::FindingTriaged->value)
|
|
->toContain(AuditActionId::FindingInProgress->value)
|
|
->toContain(AuditActionId::FindingAssigned->value)
|
|
->toContain(AuditActionId::FindingResolved->value)
|
|
->toContain(AuditActionId::FindingClosed->value)
|
|
->toContain(AuditActionId::FindingRiskAccepted->value)
|
|
->toContain(AuditActionId::FindingReopened->value);
|
|
});
|
|
|
|
it('does not expose direct finding lifecycle mutators', function (): void {
|
|
expect(method_exists(Finding::class, 'acknowledge'))->toBeFalse()
|
|
->and(method_exists(Finding::class, 'resolve'))->toBeFalse()
|
|
->and(method_exists(Finding::class, 'reopen'))->toBeFalse();
|
|
});
|
|
|
|
it('rolls back finding workflow persistence when audit logging fails', function (): void {
|
|
[$user, $tenant] = $this->actingAsFindingOperator('owner');
|
|
|
|
$finding = $this->makeFindingForWorkflow($tenant, Finding::STATUS_NEW);
|
|
|
|
mock(AuditLogger::class, function (MockInterface $mock): void {
|
|
$mock->shouldReceive('log')
|
|
->once()
|
|
->andThrow(new \RuntimeException('Audit write unavailable.'));
|
|
});
|
|
|
|
expect(fn () => app(FindingWorkflowService::class)->triage($finding, $tenant, $user))
|
|
->toThrow(\RuntimeException::class, 'Audit write unavailable.');
|
|
|
|
expect($finding->refresh()->status)->toBe(Finding::STATUS_NEW)
|
|
->and(AuditLog::query()
|
|
->where('tenant_id', (int) $tenant->getKey())
|
|
->where('resource_type', 'finding')
|
|
->where('resource_id', (string) $finding->getKey())
|
|
->count())->toBe(0);
|
|
});
|