ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity
b5166c02db
TenantAtlas/.github/agents/copilot-instructions.md
ahmido 9f5c99317b Fix Review Pack generation UX + notifications (#133) 
## Summary
- Fixes misleading “queued / running in background” message when Review Pack generation request reuses an existing ready pack (fingerprint dedupe).
- Improves resilience of Filament/Livewire interactions by ensuring the Livewire intercept shim applies after Livewire initializes.
- Aligns Review Pack operation notifications with Ops-UX patterns (queued + completed notifications) and removes the old ReviewPackStatusNotification.

## Key Changes
- Review Pack generate action now:
  - Shows queued toast only when a new pack is actually created/queued.
  - Shows a “Review pack already available” success notification with a link when dedupe returns an existing pack.

## Tests
- `vendor/bin/sail artisan test --compact tests/Feature/ReviewPack/ReviewPackGenerationTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/ReviewPack/ReviewPackResourceTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/LivewireInterceptShimTest.php`

## Notes
- No global search behavior changes for ReviewPacks (still excluded).
- Destructive actions remain confirmation-gated (`->requiresConfirmation()`).

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #133
2026-02-23 19:42:52 +00:00

4.1 KiB
Raw Blame History

TenantAtlas Development Guidelines

Auto-generated from all feature plans. Last updated: 2025-12-22

Active Technologies

  • PHP 8.4.15 + Laravel 12, Filament v4, Livewire v3 (feat/005-bulk-operations)

  • PostgreSQL (app), SQLite in-memory (tests) (feat/005-bulk-operations)

  • PostgreSQL (Sail locally) (feat/032-backup-scheduling-mvp)

  • PHP 8.4.x + Laravel 12, Filament v4, Livewire v3 (feat/042-inventory-dependencies-graph)

  • PostgreSQL (JSONB) (feat/042-inventory-dependencies-graph)

  • PHP 8.4.x (Laravel 12) + Laravel 12, Filament v4, Livewire v3 (feat/047-inventory-foundations-nodes)

  • PostgreSQL (JSONB for InventoryItem.meta_jsonb) (feat/047-inventory-foundations-nodes)

  • PostgreSQL (JSONB in operation_runs.context, operation_runs.summary_counts) (056-remove-legacy-bulkops)

  • PHP 8.4.15 (Laravel 12.47.0) + Filament v5.0.0, Livewire v4.0.1 (058-tenant-ui-polish)

  • PHP 8.4 (per repo guidelines) + Laravel 12, Filament v5, Livewire v4 (067-rbac-troubleshooting)

  • PostgreSQL (via Laravel Sail) (067-rbac-troubleshooting)

  • PHP 8.4.x (Composer constraint: ^8.2) + Laravel 12, Filament 5, Livewire 4+, Pest 4, Sail 1.x (073-unified-managed-tenant-onboarding-wizard)

  • PostgreSQL (Sail) + SQLite in tests where applicable (073-unified-managed-tenant-onboarding-wizard)

  • PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, Filament Infolists (schema-based) (078-operations-tenantless-canonical)

  • PostgreSQL (no new migrations — read-only model changes) (078-operations-tenantless-canonical)

  • PHP 8.4.15 (Laravel 12) + Filament v5, Livewire v4, Tailwind v4 (080-workspace-managed-tenant-admin)

  • PostgreSQL (via Sail) (080-workspace-managed-tenant-admin)

  • PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Socialite v5 (081-provider-connection-cutover)

  • PHP 8.4.x + Laravel 12, Filament v5, Livewire v4 (082-action-surface-contract)

  • PHP 8.4 (Laravel 12) + Filament v5 (Livewire v4), Queue/Jobs (Laravel), Microsoft Graph via GraphClientInterface (084-verification-surfaces-unification)

  • PostgreSQL (JSONB-backed OperationRun.context) (084-verification-surfaces-unification)

  • PHP 8.4.15 (Laravel 12) + Filament v5, Livewire v4, Pest v4, Tailwind CSS v4, Laravel Sail (085-tenant-operate-hub)

  • PostgreSQL (primary) + session (workspace context + last-tenant memory) (085-tenant-operate-hub)

  • PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, Laravel Sail, Tailwind CSS v4 (085-tenant-operate-hub)

  • PostgreSQL (Sail), SQLite in tests (087-legacy-runs-removal)

  • PHP 8.4.x + Laravel 12, Filament v5, Livewire v4, Microsoft Graph integration via GraphClientInterface (095-graph-contracts-registry-completeness)

  • PHP 8.4.15 (Laravel 12) + Filament v5, Livewire v4, Laravel Queue, Laravel Notifications (100-alert-target-test-actions)

  • PostgreSQL (Sail locally); SQLite is used in some tests (101-golden-master-baseline-governance-v1)

  • PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, OperateHubShell support class (103-ia-scope-filter-semantics)

  • PostgreSQL — no schema changes (103-ia-scope-filter-semantics)

  • PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, Pest v4 (104-provider-permission-posture)

  • PostgreSQL (via Sail), JSONB for stored report payloads and finding evidence (104-provider-permission-posture)

  • PHP 8.4 / Laravel 12 + Filament v5, Livewire v4, Tailwind CSS v4 (107-workspace-chooser)

  • PostgreSQL (existing tables: workspaces, workspace_memberships, users, audit_logs) (107-workspace-chooser)

  • PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, Laravel Framework v12 (109-review-pack-export)

  • PostgreSQL (jsonb columns for summary/options), local filesystem (exports disk) for ZIP artifacts (109-review-pack-export)

  • PHP 8.4.15 (feat/005-bulk-operations)

Project Structure

src/
tests/

Commands

Add commands for PHP 8.4.15

Code Style

PHP 8.4.15: Follow standard conventions

Recent Changes

  • 109-review-pack-export: Added PHP 8.4 (Laravel 12) + Filament v5, Livewire v4, Laravel Framework v12
  • 109-review-pack-export: Added [if applicable, e.g., PostgreSQL, CoreData, files or N/A]
  • 109-review-pack-export: Added [if applicable, e.g., PostgreSQL, CoreData, files or N/A]