ahmido
eae06bfe05
Resolves the targeted Review / Evidence conflict set on top of `platform-dev` without introducing new features. Included scope: - keep `platform-dev` as the newer product truth for Customer Review Workspace and Review / Evidence surfaces - retain the stable `evidence_proof` surface where still needed - update the outdated TenantReview creation expectation to the current 7-section review structure Validation run locally: - `./vendor/bin/sail artisan test --compact --filter=CustomerReviewWorkspace` - `./vendor/bin/sail artisan test --compact --filter=EvidenceSnapshot` - `./vendor/bin/sail artisan test --compact --filter=ReviewPack` - `./vendor/bin/sail artisan test --compact --filter=TenantReview` - `./vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewCreationTest.php` - `./vendor/bin/sail bin pint --dirty --format agent` Follow-up integration path after merge: `platform-dev` -> `dev`. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #314
60 lines
2.3 KiB
PHP
60 lines
2.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\Finding;
|
|
use App\Services\Evidence\EvidenceSnapshotService;
|
|
use App\Support\TenantReviewCompletenessState;
|
|
use App\Support\TenantReviewStatus;
|
|
|
|
it('creates an anchored tenant review from a chosen evidence snapshot and keeps that basis stable after live data changes', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$snapshot = seedTenantReviewEvidence($tenant);
|
|
|
|
$review = composeTenantReviewForTest($tenant, $user, $snapshot);
|
|
|
|
expect($review->evidence_snapshot_id)->toBe((int) $snapshot->getKey())
|
|
->and($review->sections)->toHaveCount(7)
|
|
->and($review->sections->pluck('section_key')->all())->toBe([
|
|
'executive_summary',
|
|
'control_interpretation',
|
|
'open_risks',
|
|
'accepted_risks',
|
|
'permission_posture',
|
|
'baseline_drift_posture',
|
|
'operations_health',
|
|
])
|
|
->and($review->summary['evidence_basis']['snapshot_id'])->toBe((int) $snapshot->getKey());
|
|
|
|
Finding::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'severity' => Finding::SEVERITY_CRITICAL,
|
|
]);
|
|
|
|
$newSnapshotPayload = app(EvidenceSnapshotService::class)->buildSnapshotPayload($tenant);
|
|
|
|
expect($review->fresh()->evidence_snapshot_id)->toBe((int) $snapshot->getKey())
|
|
->and($review->fresh()->summary['evidence_basis']['snapshot_fingerprint'])->toBe((string) $snapshot->fingerprint)
|
|
->and($newSnapshotPayload['fingerprint'])->not->toBe((string) $snapshot->fingerprint);
|
|
});
|
|
|
|
it('records completeness and publish blockers when the evidence basis is partial or missing', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$snapshot = seedTenantReviewEvidence(
|
|
tenant: $tenant,
|
|
permissionPayload: [
|
|
'required_count' => 10,
|
|
'granted_count' => 7,
|
|
],
|
|
operationRunCount: 0,
|
|
);
|
|
|
|
$review = composeTenantReviewForTest($tenant, $user, $snapshot);
|
|
|
|
expect($review->completeness_state)->toBe(TenantReviewCompletenessState::Missing->value)
|
|
->and($review->status)->toBe(TenantReviewStatus::Draft->value)
|
|
->and($review->publishBlockers())->not->toBeEmpty();
|
|
});
|