Some checks failed
PR Fast Feedback / fast-feedback (pull_request) Failing after 3m58s
Applied diagnostic surface contract rules to Audit Log inspect modal and Support Diagnostics action context, consolidating raw diagnostic data into safe modals according to Spec 374.
38 lines
3.6 KiB
Markdown
38 lines
3.6 KiB
Markdown
# Browser Verification Report
|
|
|
|
Status: complete.
|
|
|
|
## Fixture
|
|
|
|
- Browser test: `apps/platform/tests/Browser/Spec374DiagnosticEntrypointSmokeTest.php`
|
|
- Fixture creation: existing `createUserWithTenant(role: 'owner', workspaceRole: 'manager')`
|
|
- User: generated by factory during the browser test
|
|
- Environment: `Spec374 Diagnostics Environment`
|
|
- Login path: existing `/admin/local/smoke-login`
|
|
- Browser command: `php artisan test --compact tests/Browser/Spec374DiagnosticEntrypointSmokeTest.php`
|
|
- Result: passed, 1 test, 36 assertions
|
|
|
|
## Tested Paths
|
|
|
|
| Target | Result | Evidence |
|
|
|---|---|---|
|
|
| Environment Dashboard diagnostic entry | PASS | Opened dashboard, expanded More actions, saw `Open support diagnostics`, did not see `Repair diagnostics` as a dashboard action, screenshot `001-environment-dashboard-diagnostic-entry-after.png` |
|
|
| Support Diagnostics modal | PASS | Opened modal from dashboard action, saw `Support diagnostics`, `Quick support context`, `Recommended first check`, `Redacted support view`, and compact `Support scope` copy; did not see the internal `Boundary` note; reference links expose safe drilldown attributes, screenshot `002-support-diagnostics-modal-after.png` |
|
|
| Support Diagnostics technical exception redaction | PASS | Reopened the user-commented `Spec 352 Audit Provider Blocker` modal after the fix; the header showed `The operation failed and needs follow-up.` and did not show `SQLSTATE`, duplicate-key text, or `environment_reviews_fingerp`. |
|
|
| Direct Repair Diagnostics route | PASS | Opened `/admin/workspaces/{workspace}/environments/{environment}/diagnostics`, saw `Repair diagnostics` and no-action repair-only copy, screenshot `003-environment-repair-diagnostics-after.png` |
|
|
| Repair Diagnostics support handoff | PASS | Confirmed no supported access or membership repair was active, opened `Open support diagnostics` from the repair page, and saw the redacted support modal with compact `Support scope`; reference links expose safe drilldown attributes, screenshot `004-environment-repair-diagnostics-support-modal-after.png` |
|
|
| Integrated Browser current fixture | PASS | Opened `Spec 352 Audit Provider Blocker` Repair Diagnostics in the Integrated Browser, opened `Open support diagnostics`, saw `Redacted support view` and `Support scope`, confirmed no visible `default-redacted`, `SQLSTATE`, `environment_reviews_fingerp`, or internal `Boundary` support-note block, confirmed Status / Why relevant / Observed / Action labels were present, and clicked `Inspect event` through to Audit Log selected-event detail. |
|
|
| Browser console/runtime | PASS | Browser assertions reported no JavaScript errors and no console logs on the scoped flow |
|
|
|
|
## Screenshot Outputs
|
|
|
|
- `specs/374-diagnostic-entry-point-support-diagnostics-consolidation/artifacts/screenshots/001-environment-dashboard-diagnostic-entry-after.png`
|
|
- `specs/374-diagnostic-entry-point-support-diagnostics-consolidation/artifacts/screenshots/002-support-diagnostics-modal-after.png`
|
|
- `specs/374-diagnostic-entry-point-support-diagnostics-consolidation/artifacts/screenshots/003-environment-repair-diagnostics-after.png`
|
|
- `specs/374-diagnostic-entry-point-support-diagnostics-consolidation/artifacts/screenshots/004-environment-repair-diagnostics-support-modal-after.png`
|
|
|
|
## Limitations
|
|
|
|
- A repair/blocker browser state was not created. The existing smoke fixture does not safely create duplicate membership or missing-owner states, and Spec 374 forbids broad fixture/auth repair.
|
|
- Missing-owner and duplicate-membership states remain covered by Feature/Livewire tests in `TenantDiagnosticsRepairsTest.php`.
|