Some checks failed
PR Fast Feedback / fast-feedback (pull_request) Failing after 3m58s
Applied diagnostic surface contract rules to Audit Log inspect modal and Support Diagnostics action context, consolidating raw diagnostic data into safe modals according to Spec 374.
2.8 KiB
2.8 KiB
Requirements Checklist: Spec 374 - Diagnostic Entry Point and Support Diagnostics Consolidation v1
Purpose: Validate preparation readiness for Spec 374 before implementation.
Created: 2026-06-12
Feature: specs/374-diagnostic-entry-point-support-diagnostics-consolidation/spec.md
Spec Quality
- CHK001 The selected candidate is directly provided by the user and aligned with current repo truth.
- CHK002 The completed-spec guardrail excludes Spec 373 as a refresh target and treats it as context.
- CHK003 The spec states the concrete operator workflow: start diagnostics from Environment Dashboard and distinguish Support Diagnostics from Repair Diagnostics.
- CHK004 The spec defines the smallest enterprise-capable slice and rejects a diagnostic hub.
- CHK005 Functional requirements are testable and avoid implementation-only wording where product behavior is enough.
- CHK006 Out-of-scope boundaries are explicit for provider, permission, evidence, system, OperationRun, customer/auditor, and bloat-guard work.
- CHK007 Risks, assumptions, and non-blocking open questions are recorded.
Constitution And Guardrails
- CHK008 UI Surface Impact is completed and does not conflict with no-impact handling.
- CHK009 UI/Productization Coverage classifies the dashboard, support modal, repair diagnostics page, and deferred destinations.
- CHK010 Cross-cutting shared pattern reuse names existing builders/helpers/actions before any new local work.
- CHK011 OperationRun UX impact states no new start/completion behavior and limits usage to existing links.
- CHK012 Provider boundary treatment keeps provider/permission diagnostics out of repair diagnostics.
- CHK013 Proportionality review states no new persisted truth, abstraction, enum/state family, or diagnostic framework.
- CHK014 RBAC and destructive-action safety requirements are explicit for existing repair actions.
- CHK015 Test governance names the narrowest proving lanes and fixture cost controls.
Task Readiness
- CHK016
tasks.mdincludes repo-truth and source-audit tasks before runtime edits. - CHK017
tasks.mdincludes tests before implementation for dashboard entry, repair diagnostics, and support modal behavior. - CHK018
tasks.mdincludes browser smoke and screenshot tasks for reachable surfaces. - CHK019
tasks.mdincludes final validation and artifact close-out tasks. - CHK020
tasks.mdincludes explicit non-goals to prevent scope creep.
Preparation Outcome
- CHK021 Candidate Selection Gate result: pass.
- CHK022 Spec Readiness Gate result: pass for preparation.
- CHK023 Review outcome class: acceptable-special-case.
- CHK024 Workflow outcome: keep.
Notes
This checklist validates preparation only. It does not claim runtime implementation, browser smoke, or test execution.