TenantAtlas/specs/267-artifact-lifecycle-retention/checklists/requirements.md
Ahmed Darrazi d091d84ddf
Some checks failed
PR Fast Feedback / fast-feedback (pull_request) Failing after 4m47s
chore: commit all workspace changes (automated)
2026-05-03 22:26:40 +02:00

4.3 KiB

Specification Quality Checklist: Governance Artifact Lifecycle & Retention v1

Purpose: Validate specification completeness, boundedness, and readiness before implementation
Created: 2026-05-03
Feature: spec.md

Content Quality

  • The package stays on one bounded shared lifecycle and retention contract over existing governance artifact families instead of inventing a registry, workflow console, or customer portal.
  • The spec remains product- and behavior-oriented rather than reading like a low-level implementation diff.
  • The package explicitly names the repo-real anchors it builds on: ArtifactTruthPresenter, review-pack download and suspended-read-only behavior, stored-report fingerprint and prune truth, and append-only accepted-risk decision history.
  • Mandatory repo sections for scope, RBAC, shared-pattern reuse, testing, proportionality, and candidate rationale are completed.

Requirement Completeness

  • No [NEEDS CLARIFICATION] markers remain.
  • Requirements are testable and bounded to current evidence, review, review-pack, customer-workspace, signed-download, stored-report, and accepted-risk aggregate seams only.
  • The package makes the mutation split gate explicit: hold or deletion-request work ships only when it stays on current owning records, otherwise the slice stops at read-only lifecycle truth plus existing download audit.
  • Accepted-risk decision adoption remains headless and leaves current Spec 265 browsing and detail surfaces unchanged in this slice.
  • Canonical proof commands now match across spec.md, plan.md, quickstart.md, and tasks.md.
  • The implementation contract defines reversible deletion requested semantics directly and does not rely on an undefined soft-delete requirement.

Feature Readiness

  • The package forbids new panel, provider, global-search, asset-registration, queue-family, and route-family changes.
  • Stored reports stay headless and no dedicated stored-report browsing surface is hidden inside this slice.
  • CustomerReviewWorkspace stays read-only and scan-first with no mutation console growth.
  • Existing Spec 265 decision surfaces are treated as unchanged boundaries, not as delivery scope for this package.
  • Follow-up ownership stays explicit for Stored Reports Surface, export-before-delete, purge governance, closure lifecycle, and support-access governance.

Test Governance

  • Planned proof stays bounded to one new Unit suite plus focused Feature suites, with browser checking allowed only as a narrow manual exception.
  • No new heavy-governance, discovery, or browser family is introduced by default.
  • Fixture growth remains bounded to current factories and BuildsGovernanceArtifactTruthFixtures instead of a new full-matrix harness.
  • The review outcome, workflow outcome, and test-governance outcome are carried into plan.md, quickstart.md, and tasks.md.

Notes

  • Reviewed against .specify/memory/constitution.md, .specify/templates/checklist-template.md, spec.md, plan.md, research.md, data-model.md, quickstart.md, and tasks.md on 2026-05-03.
  • This checklist is the prep-time outcome record. If implementation later widens mutation scope or requires current Spec 265 surface edits, the workflow outcome must change before merge.
  • Implementation close-out on 2026-05-03 delivered the shared read-only lifecycle and retention contract, validated the existing suspended-read-only and audit seams, and explicitly deferred hold or deletion-request persistence because no bounded current-owner mutation path was implemented in this slice.

Review Outcome

  • Outcome class: acceptable-special-case
  • Workflow outcome: split
  • Test-governance outcome: keep
  • Reason: The shipped implementation stays bounded because current operator-facing adoption is limited to existing evidence, review, review-pack, customer-workspace, and signed-download surfaces, while stored reports and accepted-risk decision history stay headless. Hold and deletion-request persistence were not added because the bounded current-owner mutation gate did not pass in this slice, so that work is explicitly split instead of being widened implicitly.
  • Final note location: This checklist during prep, and the active feature PR close-out entry only if implementation forces split or document-in-feature.