ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity
d90fb0f963
TenantAtlas/specs/054-unify-runs-suitewide/checklists/requirements.md
ahmido 3030dd9af2 054-unify-runs-suitewide (#63) 
Summary

Kurz: Implementiert Feature 054 — canonical OperationRun-flow, Monitoring UI, dispatch-safety, notifications, dedupe, plus small UX safety clarifications (RBAC group search delegated; Restore group mapping DB-only).
What Changed

Core service: OperationRun lifecycle, dedupe and dispatch helpers — OperationRunService.php.
Model + migration: OperationRun model and migration — OperationRun.php, 2026_01_16_180642_create_operation_runs_table.php.
Notifications: queued + terminal DB notifications (initiator-only) — OperationRunQueued.php, OperationRunCompleted.php.
Monitoring UI: Filament list/detail + Livewire pieces (DB-only render) — OperationRunResource.php and related pages/views.
Start surfaces / Jobs: instrumented start surfaces, job middleware, and job updates to use canonical runs — multiple app/Jobs/* and app/Filament/* updates (see tests for full coverage).
RBAC + Restore UX clarifications: RBAC group search is delegated-Graph-based and disabled without delegated token; Restore group mapping remains DB-only (directory cache) and helper text always visible — TenantResource.php, RestoreRunResource.php.
Specs / Constitution: updated spec & quickstart and added one-line constitution guideline about Graph usage:
spec.md
quickstart.md
constitution.md
Tests & Verification

Unit / Feature tests added/updated for run lifecycle, notifications, idempotency, and UI guards: see tests/Feature/* (notably OperationRunServiceTest, MonitoringOperationsTest, OperationRunNotificationTest, and various Filament feature tests).
Full test run locally: ./vendor/bin/sail artisan test → 587 passed, 5 skipped.
Migrations

Adds create_operation_runs_table migration; run php artisan migrate in staging after review.
Notes / Rationale

Monitoring pages are explicitly DB-only at render time (no Graph calls). Start surfaces enqueue work only and return a “View run” link.
Delegated Graph access is used only for explicit user actions (RBAC group search); restore mapping intentionally uses cached DB data only to avoid render-time Graph calls.
Dispatch wrapper marks runs failed immediately if background dispatch throws synchronously to avoid misleading “queued” states.
Upgrade / Deploy Considerations

Run migrations: ./vendor/bin/sail artisan migrate.
Background workers should be running to process queued jobs (recommended to monitor queue health during rollout).
No secret or token persistence changes.
PR checklist

 Tests updated/added for changed behavior
 Specs updated: 054-unify-runs-suitewide docs + quickstart
 Constitution note added (.specify)
 Pint formatting applied

Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local>
Reviewed-on: #63
2026-01-17 22:25:00 +00:00

1.8 KiB
Raw Blame History

Requirements Checklist: Unified Operations Runs

Phase 1 Adoption Set

  • inventory.sync (Inventory “Sync now”) covered in spec
  • policy.sync (Policies “Sync now”) covered in spec
  • directory_groups.sync (Directory → Groups “Sync groups”) covered in spec
  • drift.generate (Drift “Generate drift now”) covered in spec
  • backup_set.add_policies (Backup Sets “Add selected”) covered in spec
  • backup_schedule.run_now (Backup Schedules “Run now”) covered in implementation
  • backup_schedule.retry (Backup Schedules “Retry”) covered in implementation
  • restore.execute (adapter mode) covered in spec

Critical Clarifications (Pinned)

  • Retention policy defined (90 days default)
  • Transition strategy defined (Parallel write: Canonical + Legacy)
  • Concurrency enforcement defined (Partial unique index on active runs)
  • Initiator model defined (Nullable FK + Name Snapshot)
  • Restore integration defined (Physical adapter row pointing to Restore Domain record)

Functional Requirements (Spec Coverage)

  • FR-001 Canonical Operation Run schema defined (see data-model.md)
  • FR-004 Monitoring List UI specified (filters/sort defined in Spec FR-004)
  • FR-005 Monitoring Detail UI specified (content defined in Spec FR-005)
  • FR-007 Start surfaces behavior specified (Spec FR-007)
  • FR-009 Idempotency (Partial Unique Index) strategy defined (Spec FR-009, Plan)
  • FR-015 Notifications for queued/terminal states specified (Spec FR-015)
  • FR-016 Tenant isolation rules specified (Spec FR-016)

Non-Functional (Spec Coverage)

  • SC-002 Start confirmation < 2s target defined (Spec SC-002)
  • SC-003 Deduplication rate > 99% strategy defined (Spec SC-003)
  • SC-004 No secrets in failure logs rule defined (Spec SC-004)